Skip to content

LLM inference in C/C++

C++ ggml

mtmd: fix gemma 4 projector pre_norm (#23822)

Xuan-Son Nguyenc8914ad4f44e
diff --git a/tools/mtmd/models/gemma4v.cpp b/tools/mtmd/models/gemma4v.cpp
index 4068a08aaf..3570d6da13 100644
--- a/tools/mtmd/models/gemma4v.cpp
+++ b/tools/mtmd/models/gemma4v.cpp
@@ -124,12 +124,12 @@ ggml_cgraph * clip_graph_gemma4v::build() {
}
// Gemma4MultimodalEmbedder
- cur = build_mm(model.mm_input_proj_w, cur);
- cb(cur, "projected", -1);
-
- // embedding_post_projection_norm
- cur = ggml_rms_norm(ctx0, cur, hparams.eps);
- cb(cur, "projected_normed", -1);
+ {
+ // embedding_pre_projection_norm
+ cur = ggml_rms_norm(ctx0, cur, hparams.eps);
+ cur = build_mm(model.mm_input_proj_w, cur);
+ cb(cur, "projected", -1);
+ }
ggml_build_forward_expand(gf, cur);
return gf;