LLM inference in C/C++
C++ ggml
server: fix edit_file crash on append at end of file (line_start -1) (#24893)
Pascald0f9d2e5ac5d
diff --git a/tools/server/server-tools.cpp b/tools/server/server-tools.cppindex 95662d4ecb..790ed85a06 100644--- a/tools/server/server-tools.cpp+++ b/tools/server/server-tools.cpp@@ -569,9 +569,13 @@ struct server_tool_edit_file : server_tool {}int n = (int) lines.size();if (e.line_start == -1) {- // -1 means end of file; line_end is ignored — normalize to point past last line- e.line_start = n + 1;- e.line_end = n + 1;+ // -1 targets end of file -> valid for append only; line_end is ignored+ if (e.mode != "append") {+ return {{"error", "line_start -1 (end of file) is only valid for append mode"}};+ }+ // append at end of file: insert position is the current line count+ e.line_start = n;+ e.line_end = n;} else {if (e.line_start < 1 || e.line_end < e.line_start) {return {{"error", string_format("invalid line range [%d, %d]", e.line_start, e.line_end)}};@@ -612,8 +616,8 @@ struct server_tool_edit_file : server_tool {} else if (e.mode == "delete") {lines.erase(lines.begin() + idx_start, lines.begin() + idx_end + 1);} else { // append- // idx_end + 1 may equal lines.size() when line_start == -1 (end of file)- lines.insert(lines.begin() + idx_end + 1, new_lines.begin(), new_lines.end());+ // insert after idx_end; idx_end + 1 == lines.size() for end-of-file append+ lines.insert(lines.begin() + (idx_end + 1), new_lines.begin(), new_lines.end());}}