LLM inference in C/C++
C++ ggml
ui: fix accessibility for hover-gated interactive elements assisted by claude(in debugging and tests) (#24727)
Sanjay Aharided1561b4228
diff --git a/tools/ui/src/lib/components/app/chat/ChatAttachments/ChatAttachmentsList/ChatAttachmentsListItem/ChatAttachmentsListItemMcpPrompt.svelte b/tools/ui/src/lib/components/app/chat/ChatAttachments/ChatAttachmentsList/ChatAttachmentsListItem/ChatAttachmentsListItemMcpPrompt.svelteindex 636e93f221..c55dfdec7b 100644--- a/tools/ui/src/lib/components/app/chat/ChatAttachments/ChatAttachmentsList/ChatAttachmentsListItem/ChatAttachmentsListItemMcpPrompt.svelte+++ b/tools/ui/src/lib/components/app/chat/ChatAttachments/ChatAttachmentsList/ChatAttachmentsListItem/ChatAttachmentsListItemMcpPrompt.svelte@@ -33,7 +33,7 @@{#if !readonly && onRemove}<div- class="absolute top-10 right-2 flex items-center justify-center opacity-0 transition-opacity group-hover:opacity-100"+ class="absolute top-10 right-2 flex items-center justify-center opacity-0 transition-opacity group-focus-within:opacity-100 group-hover:opacity-100"><ActionIcon icon={X} tooltip="Remove" stopPropagationOnClick onclick={() => onRemove?.()} /></div>diff --git a/tools/ui/src/lib/components/app/chat/ChatMessages/ChatMessage/ChatMessageUser/ChatMessageUserPending.svelte b/tools/ui/src/lib/components/app/chat/ChatMessages/ChatMessage/ChatMessageUser/ChatMessageUserPending.svelteindex 4be582b39a..5c2913202c 100644--- a/tools/ui/src/lib/components/app/chat/ChatMessages/ChatMessage/ChatMessageUser/ChatMessageUserPending.svelte+++ b/tools/ui/src/lib/components/app/chat/ChatMessages/ChatMessage/ChatMessageUser/ChatMessageUserPending.svelte@@ -56,7 +56,7 @@<div class="relative flex h-6 items-center justify-between"><div class="right-0 flex items-center gap-2 opacity-100 transition-opacity"><div- class="pointer-events-auto inset-0 flex items-center gap-1 opacity-0 transition-all duration-150 group-hover:opacity-100"+ class="pointer-events-auto inset-0 flex items-center gap-1 opacity-0 transition-all duration-150 group-focus-within:opacity-100 group-hover:opacity-100"><ActionIcon icon={Edit} tooltip="Edit" onclick={editCtx.handleEdit} /><ActionIcon icon={Trash2} tooltip="Delete" onclick={onDelete} />diff --git a/tools/ui/src/lib/components/app/navigation/SidebarNavigation/SidebarNavigationConversationItem.svelte b/tools/ui/src/lib/components/app/navigation/SidebarNavigation/SidebarNavigationConversationItem.svelteindex b1c2b78f65..2c1b9adf21 100644--- a/tools/ui/src/lib/components/app/navigation/SidebarNavigation/SidebarNavigationConversationItem.svelte+++ b/tools/ui/src/lib/components/app/navigation/SidebarNavigation/SidebarNavigationConversationItem.svelte@@ -39,7 +39,6 @@depth = 0}: Props = $props();- let renderActionsDropdown = $state(false);let dropdownOpen = $state(false);let isLoading = $derived(getAllLoadingChats().includes(conversation.id));@@ -71,26 +70,10 @@}}- function handleMouseLeave() {- if (!dropdownOpen) {- renderActionsDropdown = false;- }- }-- function handleMouseOver() {- renderActionsDropdown = true;- }-function handleSelect() {onSelect?.(conversation.id);}- $effect(() => {- if (!dropdownOpen) {- renderActionsDropdown = false;- }- });-onMount(() => {document.addEventListener('edit-active-conversation', handleGlobalEditEvent as EventListener);@@ -103,23 +86,19 @@});</script>-<!-- svelte-ignore a11y_mouse_events_have_key_events -->-<button- class="group flex min-h-9 w-full cursor-pointer items-center justify-between space-x-3 rounded-lg py-1.5 text-left transition-colors hover:bg-foreground/10 {isActive+<div+ class="conversation-item group relative flex min-h-9 w-full items-center justify-between space-x-3 rounded-lg py-1.5 transition-colors hover:bg-foreground/10 {isActive? 'bg-foreground/5 text-accent-foreground': ''} px-3"- onclick={handleSelect}- onmouseover={handleMouseOver}- onmouseleave={handleMouseLeave}- onfocusin={handleMouseOver}- onfocusout={(e) => {- if (!e.currentTarget.contains(e.relatedTarget as Node | null)) {- handleMouseLeave();- }- }}>+ <button+ class="absolute inset-0 z-0 cursor-pointer rounded-lg focus:outline-none focus-visible:ring-2 focus-visible:ring-ring"+ onclick={handleSelect}+ aria-label={conversation.name}+ >+ </button><div- class="flex min-w-0 flex-1 items-center gap-2"+ class="pointer-events-none relative z-10 flex min-w-0 flex-1 items-center gap-2"style:padding-left="{depth * FORK_TREE_DEPTH_PADDING}px">{#if depth > 0}@@ -130,7 +109,7 @@<a{...props}href={RouterService.chat(conversation.forkedFromConversationId)}- class="flex shrink-0 items-center text-muted-foreground transition-colors hover:text-foreground"+ class="pointer-events-auto flex shrink-0 items-center text-muted-foreground transition-colors hover:text-foreground"><GitBranch class="h-3.5 w-3.5" /></a>@@ -146,18 +125,15 @@{#if isLoading}<Tooltip.Root><Tooltip.Trigger>- <div- class="stop-button flex h-4 w-4 shrink-0 cursor-pointer items-center justify-center rounded text-muted-foreground transition-colors hover:text-foreground"+ <button+ class="stop-button pointer-events-auto flex h-4 w-4 shrink-0 cursor-pointer items-center justify-center rounded text-muted-foreground transition-colors hover:text-foreground"onclick={handleStop}- onkeydown={(e) => e.key === 'Enter' && handleStop(e)}- role="button"- tabindex="0"aria-label="Stop generation"><Loader2 class="loading-icon h-3.5 w-3.5 animate-spin" /><Square class="stop-icon hidden h-3 w-3 fill-current text-destructive" />- </div>+ </button></Tooltip.Trigger><Tooltip.Content>@@ -169,52 +145,50 @@<TruncatedText text={conversation.name} class="text-sm font-medium" showTooltip={false} /></div>- {#if renderActionsDropdown}- <div class="actions flex items-center">- <DropdownMenuActions- triggerIcon={MoreHorizontal}- triggerTooltip="More actions"- bind:open={dropdownOpen}- actions={[- {- icon: conversation.pinned ? PinOff : Pin,- label: conversation.pinned ? 'Unpin' : 'Pin',- onclick: (e: Event) => {- e.stopPropagation();- handleTogglePin();- }- },- {- icon: Pencil,- label: 'Edit',- onclick: handleEdit,- shortcut: ['shift', 'cmd', 'e']- },- {- icon: Download,- label: 'Export',- onclick: (e: Event) => {- e.stopPropagation();- conversationsStore.downloadConversation(conversation.id);- },- shortcut: ['shift', 'cmd', 's']- },- {- icon: Trash2,- label: 'Delete',- onclick: handleDelete,- variant: 'destructive',- shortcut: ['shift', 'cmd', 'd'],- separator: true+ <div class="actions pointer-events-auto relative z-20 flex items-center">+ <DropdownMenuActions+ triggerIcon={MoreHorizontal}+ triggerTooltip="More actions"+ bind:open={dropdownOpen}+ actions={[+ {+ icon: conversation.pinned ? PinOff : Pin,+ label: conversation.pinned ? 'Unpin' : 'Pin',+ onclick: (e: Event) => {+ e.stopPropagation();+ handleTogglePin();}- ]}- />- </div>- {/if}-</button>+ },+ {+ icon: Pencil,+ label: 'Edit',+ onclick: handleEdit,+ shortcut: ['shift', 'cmd', 'e']+ },+ {+ icon: Download,+ label: 'Export',+ onclick: (e: Event) => {+ e.stopPropagation();+ conversationsStore.downloadConversation(conversation.id);+ },+ shortcut: ['shift', 'cmd', 's']+ },+ {+ icon: Trash2,+ label: 'Delete',+ onclick: handleDelete,+ variant: 'destructive',+ shortcut: ['shift', 'cmd', 'd'],+ separator: true+ }+ ]}+ />+ </div>+</div><style>- button {+ .conversation-item {:global([data-slot='dropdown-menu-trigger']:not([data-state='open'])) {opacity: 0;}@@ -239,7 +213,8 @@}}- &:is(:hover) .stop-button {+ &:is(:hover) .stop-button,+ &:focus-within .stop-button {:global(.stop-icon) {display: block;}