Skip to content

LLM Wiki is a cross-platform desktop application that turns your documents into an organized, interlinked knowledge base — automatically. Instead of traditional RAG (retrieve-and-answer from scratch every time), the LLM incrementally builds and maintains a persistent wiki from your sources。

TypeScript

fix: resolve reviews after research is saved

nash_su9727dccc2297
diff --git a/src/components/review/review-view.tsx b/src/components/review/review-view.tsx
index 98420b9c..93fd27a5 100644
--- a/src/components/review/review-view.tsx
+++ b/src/components/review/review-view.tsx
@@ -23,6 +23,7 @@ import { makeQueryFileName } from "@/lib/wiki-filename"
import { createReviewPageDrafts } from "@/lib/review-create-page"
import { cleanAssistantContentForWikiSave, titleFromCleanAssistantContent } from "@/lib/chat-save-to-wiki"
import { useTranslation } from "react-i18next"
+import { useResearchStore } from "@/stores/research-store"
const typeConfig: Record<ReviewItem["type"], { icon: typeof AlertTriangle; color: string }> = {
contradiction: { icon: AlertTriangle, color: "text-amber-500" },
@@ -76,8 +77,7 @@ export function ReviewView() {
const llmConfig = useWikiStore.getState().llmConfig
// Use pre-generated search queries if available, otherwise fall back to title
const topic = item.title.replace(/^(Save to Wiki|Create|Research)[:\s]*/i, "").trim() || item.description.split("\n")[0]
- queueResearch(pp, topic, llmConfig, searchConfig, item.searchQueries)
- resolveItem(id, "Queued for research")
+ queueResearch(pp, topic, llmConfig, searchConfig, item.searchQueries, id)
} else {
resolveItem(id, action)
}
@@ -178,8 +178,7 @@ export function ReviewView() {
if (item) {
const llmConfig = useWikiStore.getState().llmConfig
const topic = action.replace(/^research\s*/i, "").trim() || item.description.split("\n")[0]
- queueResearch(pp, topic, llmConfig, searchConfig)
- resolveItem(id, "Queued for deep research")
+ queueResearch(pp, topic, llmConfig, searchConfig, undefined, id)
} else {
resolveItem(id, action)
}
@@ -429,6 +428,21 @@ function ReviewCard({
const { t } = useTranslation()
const config = typeConfig[item.type]
const Icon = config.icon
+ const researchTask = useResearchStore((state) => {
+ const matching = state.tasks.filter((task) => task.sourceReviewId === item.id)
+ return matching.find((task) => (
+ task.status === "queued" ||
+ task.status === "searching" ||
+ task.status === "synthesizing" ||
+ task.status === "saving"
+ )) ?? matching[matching.length - 1]
+ })
+ const researchRunning = researchTask !== undefined && (
+ researchTask.status === "queued" ||
+ researchTask.status === "searching" ||
+ researchTask.status === "synthesizing" ||
+ researchTask.status === "saving"
+ )
return (
<div
@@ -467,12 +481,19 @@ function ReviewCard({
)}
{!item.resolved ? (
- <div className="flex flex-wrap gap-1.5">
+ <div className="space-y-2">
+ {researchRunning && (
+ <div className="text-xs text-muted-foreground">
+ {t(`research.status.${researchTask.status}`)}
+ </div>
+ )}
+ <div className="flex flex-wrap gap-1.5">
{(item.type === "suggestion" || item.type === "missing-page") && (
<Button
variant="default"
size="sm"
className="h-7 text-xs gap-1"
+ disabled={researchRunning}
onClick={() => onResolve(item.id, "__deep_research__")}
>
🔍 {t("research.title")}
@@ -484,11 +505,13 @@ function ReviewCard({
variant="outline"
size="sm"
className="h-7 text-xs"
+ disabled={researchRunning}
onClick={() => onResolve(item.id, opt.action)}
>
{opt.label}
</Button>
))}
+ </div>
</div>
) : (
<div className="flex items-center gap-1 text-xs text-emerald-600">
diff --git a/src/lib/deep-research.test.ts b/src/lib/deep-research.test.ts
index bb69fafa..897be829 100644
--- a/src/lib/deep-research.test.ts
+++ b/src/lib/deep-research.test.ts
@@ -1,7 +1,10 @@
import { describe, expect, it, vi } from "vitest"
-import { collectResearchSources, makeDeepResearchFileName, noResearchSourcesTaskPatch } from "./deep-research"
+import { collectResearchSources, makeDeepResearchFileName, noResearchSourcesTaskPatch, resolveReviewForSavedResearch } from "./deep-research"
import type { SearchApiConfig } from "@/stores/wiki-store"
import type { WebSearchResult } from "./web-search"
+import { useWikiStore } from "@/stores/wiki-store"
+import { useResearchStore } from "@/stores/research-store"
+import { useReviewStore, type ReviewItem } from "@/stores/review-store"
const webResult: WebSearchResult = {
title: "Web",
@@ -66,6 +69,96 @@ describe("noResearchSourcesTaskPatch", () => {
})
})
+describe("review-linked research", () => {
+ const review: ReviewItem = {
+ id: "review-1",
+ type: "suggestion",
+ title: "Research this",
+ description: "Needs evidence",
+ options: [],
+ resolved: false,
+ createdAt: 1,
+ }
+
+ it("resolves the source review only after a saved result exists", () => {
+ useWikiStore.setState({ project: { id: "p1", name: "Project", path: "/project" } })
+ useReviewStore.setState({ items: [review] })
+ useResearchStore.setState({
+ tasks: [{
+ id: "research-1",
+ topic: "topic",
+ sourceReviewId: review.id,
+ status: "done",
+ webResults: [],
+ synthesis: "answer",
+ savedPath: "wiki/queries/research-topic.md",
+ error: null,
+ createdAt: 1,
+ }],
+ })
+
+ expect(resolveReviewForSavedResearch(
+ "/project",
+ "research-1",
+ "wiki/queries/research-topic.md",
+ )).toBe(true)
+ expect(useReviewStore.getState().items[0]).toMatchObject({
+ resolved: true,
+ resolvedAction: "Research saved: wiki/queries/research-topic.md",
+ })
+ })
+
+ it("does not resolve another project's review", () => {
+ useWikiStore.setState({ project: { id: "p2", name: "Other", path: "/other" } })
+ useReviewStore.setState({ items: [review] })
+ useResearchStore.setState({
+ tasks: [{
+ id: "research-1",
+ topic: "topic",
+ sourceReviewId: review.id,
+ status: "done",
+ webResults: [],
+ synthesis: "answer",
+ savedPath: "wiki/queries/research-topic.md",
+ error: null,
+ createdAt: 1,
+ }],
+ })
+
+ expect(resolveReviewForSavedResearch(
+ "/project",
+ "research-1",
+ "wiki/queries/research-topic.md",
+ )).toBe(false)
+ expect(useReviewStore.getState().items[0].resolved).toBe(false)
+ })
+
+ it("rejects callbacks before the linked task reaches the matching saved state", () => {
+ useWikiStore.setState({ project: { id: "p1", name: "Project", path: "/project" } })
+ useReviewStore.setState({ items: [review] })
+ useResearchStore.setState({
+ tasks: [{
+ id: "research-1",
+ topic: "topic",
+ sourceReviewId: review.id,
+ status: "saving",
+ webResults: [],
+ synthesis: "answer",
+ savedPath: null,
+ error: null,
+ createdAt: 1,
+ }],
+ })
+
+ expect(resolveReviewForSavedResearch(
+ "/project",
+ "research-1",
+ "wiki/queries/research-topic.md",
+ )).toBe(false)
+ expect(useReviewStore.getState().items[0].resolved).toBe(false)
+ })
+})
+
describe("collectResearchSources", () => {
it("uses only Web Search when source mode is web", async () => {
const webSearch = vi.fn().mockResolvedValue([webResult])
diff --git a/src/lib/deep-research.ts b/src/lib/deep-research.ts
index 97df64a6..e984d677 100644
--- a/src/lib/deep-research.ts
+++ b/src/lib/deep-research.ts
@@ -9,6 +9,7 @@ import { normalizePath } from "@/lib/path-utils"
import { buildLanguageDirective } from "@/lib/output-language"
import { makeQueryFileName } from "@/lib/wiki-filename"
import { refreshProjectFileTree } from "@/lib/project-file-tree-refresh"
+import { useReviewStore } from "@/stores/review-store"
const MAX_RESEARCH_SOURCES = 20
@@ -65,6 +66,7 @@ export function queueResearch(
llmConfig: LlmConfig,
searchConfig: SearchApiConfig,
searchQueries?: string[],
+ sourceReviewId?: string,
): string {
const store = useResearchStore.getState()
const taskId = store.addTask(topic)
@@ -72,6 +74,7 @@ export function queueResearch(
if (searchQueries && searchQueries.length > 0) {
store.updateTask(taskId, { searchQueries })
}
+ if (sourceReviewId) store.updateTask(taskId, { sourceReviewId })
// Ensure panel is open
store.setPanelOpen(true)
// Start processing on next tick to ensure React has rendered the panel
@@ -81,6 +84,24 @@ export function queueResearch(
return taskId
}
+export function resolveReviewForSavedResearch(
+ projectPath: string,
+ taskId: string,
+ savedPath: string,
+): boolean {
+ if (!isActiveProjectPath(projectPath)) return false
+ const task = useResearchStore.getState().tasks.find((candidate) => candidate.id === taskId)
+ if (
+ !task?.sourceReviewId ||
+ task.status !== "done" ||
+ task.savedPath !== savedPath
+ ) return false
+ const review = useReviewStore.getState().items.find((item) => item.id === task.sourceReviewId)
+ if (!review || review.resolved) return false
+ useReviewStore.getState().resolveItem(task.sourceReviewId, `Research saved: ${savedPath}`)
+ return true
+}
+
export async function collectResearchSources(
queries: string[],
searchConfig: SearchApiConfig,
@@ -328,6 +349,7 @@ async function executeResearch(
status: "done",
savedPath,
})) return
+ resolveReviewForSavedResearch(pp, taskId, savedPath)
try {
await refreshProjectFileTree(pp, { bumpDataVersion: true })
diff --git a/src/stores/research-store.ts b/src/stores/research-store.ts
index 954cb2f6..9987f822 100644
--- a/src/stores/research-store.ts
+++ b/src/stores/research-store.ts
@@ -4,6 +4,9 @@ import type { WebSearchResult } from "@/lib/web-search"
export interface ResearchTask {
id: string
topic: string
+ /** Review item that requested this research. It is resolved only after the
+ * generated page has been written successfully. */
+ sourceReviewId?: string
searchQueries?: string[]
status: "queued" | "searching" | "synthesizing" | "saving" | "done" | "error"
webResults: WebSearchResult[]