Skip to content

~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.

2.3 KB
Raw Blame
"""``change_password`` must reject an invalid password BEFORE it rekeys.

``create_user_database`` and ``open_user_database`` guard the password with
``_is_valid_encryption_key``, but the rekey path did not: rekeying to an empty
or whitespace-only password succeeded and returned ``True``, after which the
open-path guard rejected that same password and the database was permanently
unopenable (#6353).
"""

import pytest

from local_deep_research.database.encrypted_db import DatabaseManager

OLD_PASSWORD = "OldCorrectHorse1!"


@pytest.fixture
def manager(tmp_path, monkeypatch):
    """A DatabaseManager writing to an isolated data directory."""
    monkeypatch.setenv("LDR_DATA_DIR", str(tmp_path))
    mgr = DatabaseManager()
    mgr.data_dir = tmp_path
    if not mgr.has_encryption:
        pytest.skip("SQLCipher not available; rekey path is a no-op")
    yield mgr
    mgr.close_all_databases()


@pytest.fixture
def user(manager):
    username = "rekey_guard_user"
    manager.create_user_database(username, OLD_PASSWORD)
    manager.close_user_database(username)
    return username


@pytest.mark.parametrize("bad_password", ["", "   ", None])
def test_invalid_new_password_is_rejected_before_rekey(
    manager, user, bad_password
):
    with pytest.raises(
        ValueError, match="new password cannot be None or empty"
    ):
        manager.change_password(user, OLD_PASSWORD, bad_password)

    # Nothing was rekeyed: the old password still opens the database.
    engine = manager.open_user_database(user, OLD_PASSWORD)
    assert engine is not None
    manager.close_user_database(user)


@pytest.mark.parametrize("bad_password", ["", "   ", None])
def test_invalid_old_password_is_rejected(manager, user, bad_password):
    with pytest.raises(
        ValueError, match="old password cannot be None or empty"
    ):
        manager.change_password(user, bad_password, "NewCorrectHorse2!")

    engine = manager.open_user_database(user, OLD_PASSWORD)
    assert engine is not None
    manager.close_user_database(user)


def test_valid_new_password_still_rekeys(manager, user):
    assert (
        manager.change_password(user, OLD_PASSWORD, "NewCorrectHorse2!") is True
    )

    assert manager.open_user_database(user, OLD_PASSWORD) is None
    engine = manager.open_user_database(user, "NewCorrectHorse2!")
    assert engine is not None
    manager.close_user_database(user)