Skip to content

~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.

12.9 KB
Raw Blame
/**
 * Login Form Validation Test
 * Tests that the login form correctly validates input and shows appropriate errors
 * CI-compatible: Works in both local and CI environments
 */

const puppeteer = require('puppeteer');
const AuthHelper = require('./auth_helper');
const { getPuppeteerLaunchOptions } = require('./puppeteer_config');
const fs = require('fs');
const path = require('path');

async function testLoginValidation() {
    const isCI = !!process.env.CI;
    console.log(`🧪 Running login form validation test (CI mode: ${isCI})`);

    // Create screenshots directory if it doesn't exist
    const screenshotsDir = path.join(__dirname, 'screenshots');
    if (!fs.existsSync(screenshotsDir)) {
        fs.mkdirSync(screenshotsDir, { recursive: true });
    }

    const browser = await puppeteer.launch(getPuppeteerLaunchOptions());
    const page = await browser.newPage();
    const baseUrl = 'http://127.0.0.1:5000';

    // Increase default timeout in CI
    if (isCI) {
        page.setDefaultTimeout(60000);
        page.setDefaultNavigationTimeout(60000);
    }

    let testsPassed = 0;
    let testsFailed = 0;

    // Create a test user for login tests
    const testUser = {
        username: `logintest_${Date.now()}`,
        password: 'TestPass123!'
    };

    console.log('🧪 Starting login form validation tests...\n');

    try {
        // First, register a test user so we can test valid login
        // NOTE: must register `testUser` specifically (not just "some" session
        // via ensureAuthenticatedWithTimeout()) — Test 5/6 below log in with
        // testUser.username/password, and previously nothing ever created that
        // account, so those tests always fell through their "user may not have
        // been created" no-fail branch without ever exercising a real login.
        console.log('📋 Setup: Registering test user for login tests...');
        const authHelper = new AuthHelper(page, baseUrl);

        try {
            await authHelper.register(testUser.username, testUser.password);
            console.log(`✅ Registered dedicated user: ${testUser.username}`);

            // Logout so we can test login
            await authHelper.logout();
            console.log('✅ Logged out, ready to test login form\n');
        } catch (regError) {
            console.log(`⚠️  Could not register test user: ${regError.message}`);
            console.log('   Continuing with validation tests only...\n');
        }

        // Navigate to login page
        // NOTE: Using 'domcontentloaded' instead of 'networkidle2' because:
        // networkidle2 waits for no network activity for 500ms, but WebSocket
        // connections and polling keep the network active, causing infinite hangs.
        // This was the root cause of "Test 4: Invalid credentials" timing out.
        console.log('📄 Navigating to login page...');
        await page.goto(`${baseUrl}/auth/login`, {
            waitUntil: 'domcontentloaded',
            timeout: 30000
        });

        await page.waitForSelector('input[name="username"]', { timeout: 10000 });
        console.log('✅ Login page loaded\n');

        // Test 1: Check CSS class consistency
        console.log('📋 Test 1: CSS class consistency');
        const usernameInput = await page.$('input[name="username"]');
        const usernameClass = await page.evaluate(el => el.className, usernameInput);

        if (usernameClass.includes('ldr-form-control')) {
            console.log('✅ Username input uses ldr-form-control class');
            testsPassed++;
        } else {
            console.log(`❌ Username input has incorrect class: "${usernameClass}"`);
            testsFailed++;
        }

        const passwordInput = await page.$('input[name="password"]');
        const passwordClass = await page.evaluate(el => el.className, passwordInput);

        if (passwordClass.includes('ldr-form-control')) {
            console.log('✅ Password input uses ldr-form-control class');
            testsPassed++;
        } else {
            console.log(`❌ Password input has incorrect class: "${passwordClass}"`);
            testsFailed++;
        }

        // Test 2: Empty username validation
        console.log('\n📋 Test 2: Empty username validation');

        // Clear fields first
        await page.evaluate(() => {
            document.querySelector('input[name="username"]').value = '';
            document.querySelector('input[name="password"]').value = '';
        });

        // Type only password
        await page.type('input[name="password"]', 'somepassword', { delay: 30 });

        // Check username validity
        let validity = await page.evaluate(el => ({
            valid: el.validity.valid,
            valueMissing: el.validity.valueMissing
        }), usernameInput);

        console.log(`   Username empty - valueMissing: ${validity.valueMissing}`);

        if (validity.valueMissing) {
            console.log('✅ Empty username correctly triggers valueMissing');
            testsPassed++;
        } else {
            console.log('❌ Empty username should trigger valueMissing');
            testsFailed++;
        }

        // Test 3: Empty password validation
        console.log('\n📋 Test 3: Empty password validation');

        // Clear and type only username
        await page.evaluate(() => {
            document.querySelector('input[name="username"]').value = '';
            document.querySelector('input[name="password"]').value = '';
        });

        await page.type('input[name="username"]', 'someuser', { delay: 30 });

        validity = await page.evaluate(el => ({
            valid: el.validity.valid,
            valueMissing: el.validity.valueMissing
        }), passwordInput);

        console.log(`   Password empty - valueMissing: ${validity.valueMissing}`);

        if (validity.valueMissing) {
            console.log('✅ Empty password correctly triggers valueMissing');
            testsPassed++;
        } else {
            console.log('❌ Empty password should trigger valueMissing');
            testsFailed++;
        }

        // Test 4: Invalid credentials show error
        console.log('\n📋 Test 4: Invalid credentials error message');

        // Clear and fill with invalid credentials
        await page.evaluate(() => {
            document.querySelector('input[name="username"]').value = '';
            document.querySelector('input[name="password"]').value = '';
        });

        await page.type('input[name="username"]', 'nonexistent_user_12345', { delay: 30 });
        await page.type('input[name="password"]', 'wrongpassword123', { delay: 30 });

        // Submit the form
        await Promise.all([
            page.waitForNavigation({ waitUntil: 'domcontentloaded', timeout: 15000 }).catch(() => {}),
            page.click('button[type="submit"]')
        ]);

        // Wait a moment for the page to update
        await new Promise(resolve => setTimeout(resolve, 500));

        // Check for error alert
        const errorAlert = await page.$('.alert');
        const currentUrl = page.url();

        if (errorAlert || currentUrl.includes('/auth/login')) {
            let errorText = '';
            if (errorAlert) {
                errorText = await page.evaluate(el => el.textContent, errorAlert);
            }
            console.log(`   Still on login page with alert: "${errorText.trim().substring(0, 50)}..."`);

            if (errorText.toLowerCase().includes('invalid') || errorText.toLowerCase().includes('password')) {
                console.log('✅ Invalid credentials show appropriate error message');
                testsPassed++;
            } else if (currentUrl.includes('/auth/login')) {
                console.log('✅ Invalid credentials keep user on login page');
                testsPassed++;
            } else {
                console.log('⚠️  Error message may not be specific enough');
                testsPassed++; // Still pass since login was rejected
            }
        } else {
            console.log('❌ Invalid credentials should show error or stay on login page');
            testsFailed++;
        }

        // Test 5: Valid login redirects to dashboard
        console.log('\n📋 Test 5: Valid login redirects away from login page');

        // Navigate back to login page
        await page.goto(`${baseUrl}/auth/login`, {
            waitUntil: 'domcontentloaded',
            timeout: 15000
        });

        // Clear and fill with valid credentials
        await page.evaluate(() => {
            document.querySelector('input[name="username"]').value = '';
            document.querySelector('input[name="password"]').value = '';
        });

        await page.type('input[name="username"]', testUser.username, { delay: 30 });
        await page.type('input[name="password"]', testUser.password, { delay: 30 });

        // Submit the form
        await Promise.all([
            page.waitForNavigation({ waitUntil: 'domcontentloaded', timeout: 15000 }).catch(() => {}),
            page.click('button[type="submit"]')
        ]);

        // Wait a moment for redirect
        await new Promise(resolve => setTimeout(resolve, 1000));

        const afterLoginUrl = page.url();
        console.log(`   After login URL: ${afterLoginUrl}`);

        if (!afterLoginUrl.includes('/auth/login')) {
            console.log('✅ Valid login redirects away from login page');
            testsPassed++;
        } else {
            // Check if there's an error (might be rate limited or user not created)
            try {
                const loginError = await Promise.race([
                    page.$('.alert'),
                    new Promise((resolve) => setTimeout(() => resolve(null), 5000))
                ]);
                if (loginError) {
                    const errorText = await page.evaluate(el => el.textContent, loginError);
                    console.log(`⚠️  Login failed with error: ${errorText.trim().substring(0, 50)}`);
                }
            } catch {
                // Ignore errors when checking for alert
            }
            console.log('⚠️  Still on login page - test user may not have been created');
            // Don't fail - this might be expected if registration failed earlier
        }

        // Test 6: Logged in user can access protected pages
        console.log('\n📋 Test 6: Logged in user can access protected pages');

        if (!afterLoginUrl.includes('/auth/login')) {
            try {
                // Try to access settings page with a shorter timeout
                await page.goto(`${baseUrl}/settings/`, {
                    waitUntil: 'domcontentloaded',
                    timeout: 10000
                });

                const settingsUrl = page.url();
                if (settingsUrl.includes('/settings')) {
                    console.log('✅ Logged in user can access protected settings page');
                    testsPassed++;
                } else {
                    console.log('❌ Logged in user was redirected away from settings');
                    testsFailed++;
                }
            } catch (navError) {
                console.log(`⚠️  Could not navigate to settings: ${navError.message.substring(0, 50)}`);
            }
        } else {
            console.log('⚠️  Skipping protected page test - not logged in');
        }

        // Take a screenshot of the final state (skip in CI)
        if (!isCI) {
            try {
                await page.screenshot({
                    path: path.join(screenshotsDir, 'login_validation_test.png'),
                    fullPage: true
                });
                console.log('\n📸 Screenshot saved to screenshots/login_validation_test.png');
            } catch (ssError) {
                console.log(`\n⚠️  Could not take screenshot: ${ssError.message}`);
            }
        }

        // Summary
        console.log('\n' + '='.repeat(50));
        console.log(`📊 Test Summary: ${testsPassed} passed, ${testsFailed} failed`);
        console.log('='.repeat(50));

        if (testsFailed > 0) {
            throw new Error(`${testsFailed} test(s) failed`);
        }

        console.log('\n🎉 All login validation tests passed!');

    } catch (error) {
        console.error('\n❌ Test failed:', error.message);

        // Take error screenshot (skip in CI)
        if (!isCI) {
            try {
                await page.screenshot({
                    path: path.join(screenshotsDir, 'login_validation_error.png'),
                    fullPage: true
                });
                console.log('📸 Error screenshot saved');
            } catch (screenshotError) {
                console.log('⚠️  Could not take error screenshot:', screenshotError.message);
            }
        }

        await browser.close();
        process.exit(1);
    }

    await browser.close();
    console.log('\n✅ Test completed successfully');
    process.exit(0);
}

// Run the test
testLoginValidation().catch(error => {
    console.error('Fatal error:', error);
    process.exit(1);
});