~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.
Python academiaanthropicarxivbravedeep-researchencryptionhome-automationhomeserverlocallocal-deep-researchlocal-llmmistralollamaopenaipubmedresearchresearch-toolretrieval-augmented-generationsearxngself-hosted
fix(ws): lazy-open per-user DB at WebSocket connect (#3697) (#3707)
LearningCircuit2b59cb058cc5
diff --git a/src/local_deep_research/web/services/socket_service.py b/src/local_deep_research/web/services/socket_service.pyindex 26066e3625..2c69241d21 100644--- a/src/local_deep_research/web/services/socket_service.py+++ b/src/local_deep_research/web/services/socket_service.py@@ -7,6 +7,7 @@ from loguru import loggerfrom ...constants import ResearchStatusfrom ...database.encrypted_db import db_manager+from ...database.session_passwords import session_password_storefrom ..routes.globals import get_active_research_snapshot@@ -226,10 +227,31 @@ class SocketIOService:)return Falseif not db_manager.is_user_connected(username):- self.__log_info(- f"Rejected WebSocket connection for {username}: no active DB session"+ # Cookie is valid but the per-user DB engine isn't open yet (race vs first+ # XHR after page load, gunicorn worker restart, or idle eviction). Lazily+ # open it using the password the user authenticated with at login.+ session_id = session.get("session_id")+ password = (+ session_password_store.get_session_password(+ username, session_id+ )+ if session_id+ else None)- return False+ if not password:+ self.__log_info(+ f"Rejected WebSocket connection for {username}: no active DB session and no stored password"+ )+ return False+ try:+ db_manager.open_user_database(username, password)+ except Exception as e:+ # Use __log_error (not __log_exception) so loguru cannot include+ # the `password` local in a diagnose=True traceback.+ self.__log_error(+ f"Lazy DB open failed for {username} at WebSocket connect: {type(e).__name__}"+ )+ return Falseself.__log_info(f"Client connected: {request.sid} (user: {username})")return Truediff --git a/tests/web/services/test_socket_service_coverage.py b/tests/web/services/test_socket_service_coverage.pyindex d171eaff1e..9aeb2b77fb 100644--- a/tests/web/services/test_socket_service_coverage.py+++ b/tests/web/services/test_socket_service_coverage.py@@ -261,17 +261,66 @@ class TestHandleConnect:assert result is False- def test_handle_connect_rejects_no_db_session(self):- """__handle_connect returns False when user has no active DB session."""+ def test_handle_connect_rejects_when_no_db_session_and_no_password(self):+ """No active DB session AND no stored password → reject."""service = _make_service()mock_request = MagicMock()mock_request.sid = "connect_client_999"with (- patch(f"{MODULE}.session", {"username": "alice"}),+ patch(+ f"{MODULE}.session",+ {"username": "alice", "session_id": "sess-1"},+ ),+ patch(f"{MODULE}.db_manager") as mock_db,+ patch(f"{MODULE}.session_password_store") as mock_store,+ ):+ mock_db.is_user_connected.return_value = False+ mock_store.get_session_password.return_value = None+ result = service._SocketIOService__handle_connect(mock_request)++ assert result is False+ mock_db.open_user_database.assert_not_called()++ def test_handle_connect_lazy_opens_db_when_password_available(self):+ """No active DB session but password stored → lazy-open and accept."""+ service = _make_service()+ mock_request = MagicMock()+ mock_request.sid = "connect_client_999"++ with (+ patch(+ f"{MODULE}.session",+ {"username": "alice", "session_id": "sess-1"},+ ),+ patch(f"{MODULE}.db_manager") as mock_db,+ patch(f"{MODULE}.session_password_store") as mock_store,+ ):+ mock_db.is_user_connected.return_value = False+ mock_store.get_session_password.return_value = "pw"+ result = service._SocketIOService__handle_connect(mock_request)++ assert result is True+ mock_db.open_user_database.assert_called_once_with("alice", "pw")++ def test_handle_connect_rejects_when_lazy_open_raises(self):+ """Lazy open raising (e.g., wrong password) → reject."""+ service = _make_service()+ mock_request = MagicMock()+ mock_request.sid = "connect_client_999"++ with (+ patch(+ f"{MODULE}.session",+ {"username": "alice", "session_id": "sess-1"},+ ),patch(f"{MODULE}.db_manager") as mock_db,+ patch(f"{MODULE}.session_password_store") as mock_store,+ patch.object(service, "_SocketIOService__log_error"),):mock_db.is_user_connected.return_value = False+ mock_store.get_session_password.return_value = "pw"+ mock_db.open_user_database.side_effect = ValueError("bad key")result = service._SocketIOService__handle_connect(mock_request)assert result is Falsediff --git a/tests/web_services/test_socket_service.py b/tests/web_services/test_socket_service.pyindex 10058ea4a7..e0e9f40478 100644--- a/tests/web_services/test_socket_service.py+++ b/tests/web_services/test_socket_service.py@@ -591,21 +591,51 @@ class TestSocketIOServiceErrorHandling:service._SocketIOService__handle_connect(mock_request) is False)- def test_connect_handler_rejects_no_db_session(self, service, mock_request):- """Connect handler rejects when user has no active DB session."""+ def test_connect_handler_rejects_no_db_session_and_no_password(+ self, service, mock_request+ ):+ """Connect handler rejects when user has no active DB session and no stored password."""with (patch("local_deep_research.web.services.socket_service.session",- {"username": "alice"},+ {"username": "alice", "session_id": "sess-1"},),patch("local_deep_research.web.services.socket_service.db_manager") as mock_db,+ patch(+ "local_deep_research.web.services.socket_service.session_password_store"+ ) as mock_store,):mock_db.is_user_connected.return_value = False+ mock_store.get_session_password.return_value = Noneassert (service._SocketIOService__handle_connect(mock_request) is False)+ mock_db.open_user_database.assert_not_called()++ def test_connect_handler_lazy_opens_when_password_available(+ self, service, mock_request+ ):+ """Connect handler lazy-opens the DB when the engine isn't open but a password is stored."""+ with (+ patch(+ "local_deep_research.web.services.socket_service.session",+ {"username": "alice", "session_id": "sess-1"},+ ),+ patch(+ "local_deep_research.web.services.socket_service.db_manager"+ ) as mock_db,+ patch(+ "local_deep_research.web.services.socket_service.session_password_store"+ ) as mock_store,+ ):+ mock_db.is_user_connected.return_value = False+ mock_store.get_session_password.return_value = "pw"+ assert (+ service._SocketIOService__handle_connect(mock_request) is True+ )+ mock_db.open_user_database.assert_called_once_with("alice", "pw")def test_connect_handler_accepts_authenticated(self, service, mock_request):"""Connect handler accepts authenticated users with active DB session."""