~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.
Python academiaanthropicarxivbravedeep-researchencryptionhome-automationhomeserverlocallocal-deep-researchlocal-llmmistralollamaopenaipubmedresearchresearch-toolretrieval-augmented-generationsearxngself-hosted
test(ui-tests): real assertions for 4 settings-pages Input tests (dead-field audit PR 2) (#4613)
LearningCircuit2dfb8755ba74
diff --git a/tests/ui_tests/test_settings_pages_ci.js b/tests/ui_tests/test_settings_pages_ci.jsindex 08a72dcb71..f38d734012 100644--- a/tests/ui_tests/test_settings_pages_ci.js+++ b/tests/ui_tests/test_settings_pages_ci.js@@ -8,6 +8,50 @@*/const { setupTest, teardownTest, TestResults, log, delay, waitForVisible, navigateTo, withTimeout } = require('./test_lib');+// Open /settings/ on a clean "All Settings" tab. navigateTo() no-ops when the+// page is already on /settings/, so a prior test's active tab leaks in (e.g.+// the 'llm' tab, which hides search settings). Force the 'all' tab so every+// setting renders before the Input assertions read the DOM.+async function openSettingsAllTab(page, baseUrl) {+ await navigateTo(page, `${baseUrl}/settings/`);+ await page.waitForSelector('#settings-content .ldr-settings-item', { timeout: 15000 });+ // Require the 'all' tab to exist so a missing tab fails here with context,+ // rather than silently proceeding to an opaque downstream timeout.+ await page.waitForSelector('.ldr-settings-tab[data-tab="all"]', { timeout: 5000 });+ const isActive = await page.$eval('.ldr-settings-tab[data-tab="all"]', el => el.classList.contains('active'));+ if (!isActive) {+ await page.click('.ldr-settings-tab[data-tab="all"]');+ await page.waitForFunction(+ () => document.querySelector('.ldr-settings-tab[data-tab="all"]')?.classList.contains('active') === true,+ { timeout: 5000 }+ ).catch(() => {});+ }+}++// llm.provider and search.tool both render as custom dropdowns (custom_dropdown.html):+// a hidden input[name=<key>] carries the form value inside a .ldr-custom-dropdown,+// and the dropdown JS resolves the selection asynchronously after load. Assert a+// real value ends up selected. The .catch on the value-wait lets the assertion+// below report a specific `value=""` message rather than a raw timeout.+async function assertCustomDropdownSelected(page, name, label) {+ await page.waitForSelector(`#settings-content [name="${name}"]`, { timeout: 15000 });+ await page.waitForFunction(+ (n) => (document.querySelector(`[name="${n}"]`)?.value || '').length > 0,+ { timeout: 10000 }, name+ ).catch(() => {});+ const result = await page.evaluate((n) => {+ const hidden = document.querySelector(`[name="${n}"]`);+ return { value: hidden?.value || '', hasDropdown: !!hidden?.closest('.ldr-custom-dropdown') };+ }, name);+ const passed = result.value.length > 0 && result.hasDropdown;+ return {+ passed,+ message: passed+ ? `${label} renders a real selection ("${result.value}") in a custom dropdown`+ : `${label} incomplete (value="${result.value}", customDropdown=${result.hasDropdown})`+ };+}+// ============================================================================// Settings Page Structure Tests// ============================================================================@@ -121,207 +165,69 @@ const SettingsPageTests = {// ============================================================================const SettingsInputTests = {async modelProviderSetting(page, baseUrl) {- await navigateTo(page, `${baseUrl}/settings/`);-- // Wait for settings form to render (inputs are loaded async via JS)- try {- await page.waitForSelector('[name="llm.provider"], select[name*="provider"]', { timeout: 15000 });- } catch {- return { passed: null, skipped: true, message: 'No model provider setting found (form did not render)' };- }-- const result = await page.evaluate(() => {- const providerEl = document.querySelector(- 'select[name*="provider"], ' +- 'select[data-setting*="provider"], ' +- '#llm_provider, ' +- '[name="llm.provider"]'- );-- if (!providerEl) return { exists: false };-- // Accept both <select> and <input> (custom dropdown)- if (providerEl.tagName === 'SELECT') {- const options = Array.from(providerEl.options);- return {- exists: true,- optionCount: options.length,- options: options.map(o => ({ value: o.value, text: o.text })).slice(0, 8),- currentValue: providerEl.value- };- }-- return {- exists: true,- isCustom: true,- currentValue: providerEl.value- };- });-- if (!result.exists) {- return { passed: null, skipped: true, message: 'No model provider setting found' };- }-- if (result.isCustom) {- return {- passed: true,- message: `Model provider setting found (custom input, current: ${result.currentValue || 'default'})`- };- }-- return {- passed: result.optionCount > 0,- message: `Model provider dropdown has ${result.optionCount} options (current: ${result.currentValue})`- };+ // llm.provider renders as a custom dropdown; assert a *real* provider+ // ends up selected (the old test returned passed:true for any input).+ await openSettingsAllTab(page, baseUrl);+ return assertCustomDropdownSelected(page, 'llm.provider', 'Provider setting');},async searchEngineSetting(page, baseUrl) {- await navigateTo(page, `${baseUrl}/settings/`);-- // Ensure "All Settings" tab is active (previous test may have switched tabs)- await page.evaluate(() => {- const allTab = document.querySelector('[data-tab="all"], .ldr-settings-tab');- if (allTab) allTab.click();- });-- // Wait for settings form to render (search.tool is a hidden input in a custom dropdown)- try {- await page.waitForSelector('[name="search.tool"], select[name*="search"]', { timeout: 15000 });- } catch {- return { passed: null, skipped: true, message: 'No search engine setting found (form did not render)' };- }-- const result = await page.evaluate(() => {- // Check for standard <select>- const engineSelect = document.querySelector(- 'select[name*="search"], ' +- 'select[data-setting*="search_tool"]'- );-- if (engineSelect && engineSelect.tagName === 'SELECT') {- const options = Array.from(engineSelect.options);- return {- exists: true,- optionCount: options.length,- options: options.map(o => o.text).slice(0, 8),- currentValue: engineSelect.value- };- }-- // Check for custom dropdown component (used by LDR)- const customInput = document.querySelector(- '#search_tool, ' +- '[name="search.tool"], ' +- 'input[id*="search"][id*="tool"]'- );-- if (customInput) {- const dropdown = customInput.closest('.ldr-custom-dropdown') || customInput.parentElement;- return {- exists: true,- isCustom: true,- currentValue: customInput.value- };- }-- return { exists: false };- });-- if (!result.exists) {- return { passed: null, skipped: true, message: 'No search engine setting found' };- }-- if (result.isCustom) {- return {- passed: true,- message: `Search engine setting found (custom dropdown, current: ${result.currentValue || 'default'})`- };- }-- return {- passed: result.optionCount > 0,- message: `Search engine dropdown has ${result.optionCount} options: ${result.options.slice(0, 4).join(', ')}`- };+ // search.tool also renders as a custom dropdown. The old test's+ // select[name*=search] matched an unrelated country <select> (e.g.+ // SearXNG region); target the real search.tool field instead.+ await openSettingsAllTab(page, baseUrl);+ return assertCustomDropdownSelected(page, 'search.tool', 'Search engine setting');},async temperatureSetting(page, baseUrl) {- await navigateTo(page, `${baseUrl}/settings/`);-- // Wait for settings form to render- try {- await page.waitForSelector('[name="llm.temperature"], input[name*="temperature"]', { timeout: 15000 });- } catch {- return { passed: null, skipped: true, message: 'No temperature setting found (form did not render)' };- }+ // llm.temperature renders as a range slider (settings_form.html). The+ // old test passed as long as any temperature input existed; assert the+ // real control contract: type=range with a numeric value within [min,max].+ await openSettingsAllTab(page, baseUrl);+ await page.waitForSelector('#settings-content [name="llm.temperature"]', { timeout: 15000 });const result = await page.evaluate(() => {- const tempInput = document.querySelector(- 'input[name*="temperature"], ' +- 'input[data-setting*="temperature"], ' +- '#temperature, ' +- '[name="llm.temperature"]'- );-- if (!tempInput) return { exists: false };-- return {- exists: true,- type: tempInput.type,- value: tempInput.value,- min: tempInput.min,- max: tempInput.max- };+ const el = document.querySelector('[name="llm.temperature"]');+ if (!el) return { exists: false };+ return { exists: true, type: el.type, value: el.value, min: el.min, max: el.max, step: el.step };});if (!result.exists) {- return { passed: null, skipped: true, message: 'No temperature setting found' };+ return { passed: false, message: 'llm.temperature input not rendered' };}-+ const val = parseFloat(result.value), min = parseFloat(result.min),+ max = parseFloat(result.max), step = parseFloat(result.step);+ const passed = result.type === 'range'+ && Number.isFinite(val) && Number.isFinite(min) && Number.isFinite(max)+ && val >= min && val <= max+ && Number.isFinite(step) && step > 0; // a real slider has a positive stepreturn {- passed: true,- message: `Temperature input found (type: ${result.type}, value: ${result.value}, range: ${result.min}-${result.max})`+ passed,+ message: passed+ ? `Temperature is a range slider (value=${result.value} in [${result.min}, ${result.max}], step=${result.step})`+ : `Temperature contract failed (type=${result.type}, value=${result.value}, min=${result.min}, max=${result.max}, step=${result.step})`};},async apiKeyFieldMasked(page, baseUrl) {- await navigateTo(page, `${baseUrl}/settings/`);-- // Wait for settings form to render- try {- await page.waitForSelector('input[name*="api_key"], input[type="password"][name*="key"]', { timeout: 15000 });- } catch {- return { passed: null, skipped: true, message: 'No API key fields found (form did not render)' };- }+ // API-key settings render as password inputs (settings_form.html,+ // ui_element == "password"). Assert *every* rendered api_key field is+ // masked, not just that one exists (the old test checked only the first).+ await openSettingsAllTab(page, baseUrl);+ await page.waitForSelector('#settings-content input[name$=".api_key"]', { timeout: 15000 });const result = await page.evaluate(() => {- const apiKeyInputs = document.querySelectorAll(- 'input[name*="api_key"], ' +- 'input[name*="apikey"], ' +- 'input[type="password"][name*="key"], ' +- '[data-setting*="api_key"]'- );-- if (apiKeyInputs.length === 0) return { exists: false };-- const firstKey = apiKeyInputs[0];- return {- exists: true,- count: apiKeyInputs.length,- isMasked: firstKey.type === 'password',- inputType: firstKey.type,- placeholder: firstKey.placeholder- };+ const fields = Array.from(document.querySelectorAll('#settings-content input[name$=".api_key"]'));+ const unmasked = fields.filter(f => f.type !== 'password').map(f => f.name);+ return { count: fields.length, unmasked };});- if (!result.exists) {- return { passed: null, skipped: true, message: 'No API key fields found' };- }-+ const passed = result.count > 0 && result.unmasked.length === 0;return {- passed: result.isMasked,- message: result.isMasked- ? `${result.count} API key field(s) are masked (type=password)`- : `API key fields found but not masked (type=${result.inputType})`+ passed,+ message: passed+ ? `All ${result.count} api_key fields are masked (type=password)`+ : `${result.unmasked.length}/${result.count} api_key fields NOT masked: ${result.unmasked.slice(0, 3).join(', ')}`};}};