Skip to content

~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.

fix(settings): remove redundant bulk save button (#5138)

LearningCircuit503d9b8d907b
diff --git a/src/local_deep_research/web/templates/settings_dashboard.html b/src/local_deep_research/web/templates/settings_dashboard.html
index ae82a84e73..04f713bf24 100644
--- a/src/local_deep_research/web/templates/settings_dashboard.html
+++ b/src/local_deep_research/web/templates/settings_dashboard.html
@@ -122,9 +122,6 @@
<button type="button" id="reset-to-defaults-button" class="btn btn-warning">
<i aria-hidden="true" class="fas fa-sync-alt"></i> Reset to Defaults
</button>
- <button type="submit" class="btn btn-primary">
- <i aria-hidden="true" class="fas fa-save"></i> Save All Settings
- </button>
</div>
</form>
</div>
diff --git a/tests/ui_tests/README.md b/tests/ui_tests/README.md
index 14d6b1850c..394180f040 100644
--- a/tests/ui_tests/README.md
+++ b/tests/ui_tests/README.md
@@ -133,7 +133,7 @@ node tests/ui_tests/test_star_reviews.js
### Settings Page (`/settings/`)
- Forms and input elements exist
-- Save buttons are present
+- Per-setting auto-save controls are available
- Configuration interface loads
## Individual Component Tests
@@ -167,9 +167,10 @@ node tests/ui_tests/test_star_reviews.js
- Validates error handling and user feedback mechanisms
### Settings Save Test (`test_settings_save.js`)
-- Tests the complete settings save workflow
+- Tests the per-setting auto-save workflow
- Monitors network requests to `/research/settings/save_all_settings`
-- Validates save button functionality and form submission
+- Confirms the bulk-submit button is absent
+- Validates checkbox-triggered auto-save
- Checks for proper API response handling (success/error states)
- Monitors console logging during save operations
- Verifies success/error message display to users
diff --git a/tests/ui_tests/test_settings_save.js b/tests/ui_tests/test_settings_save.js
index 4e510c7920..16da5ac46c 100644
--- a/tests/ui_tests/test_settings_save.js
+++ b/tests/ui_tests/test_settings_save.js
@@ -1,17 +1,18 @@
/**
- * Settings Save Functionality UI Test
+ * Settings Auto-Save Functionality UI Test
*
- * Tests the complete settings save workflow by monitoring network requests,
- * console messages, and response handling. Specifically tests the save_all_settings
- * endpoint and validates proper error handling and success feedback.
+ * Tests the settings auto-save workflow by monitoring network requests,
+ * console messages, and response handling. Specifically tests the
+ * save_all_settings endpoint and validates that no bulk-submit button is shown.
*
* What this tests:
- * - Settings save button functionality
+ * - Save All Settings button is absent
+ * - Per-setting auto-save functionality
* - Network request monitoring for save operations
* - API response validation (200 vs 4xx/5xx errors)
* - Success/error message display
* - Console logging during save operations
- * - Form submission workflow
+ * - Checkbox change workflow
*
* Prerequisites: Web server running on http://127.0.0.1:5000
*
@@ -46,52 +47,31 @@ async function testSettingsSave() {
let failed = false;
try {
- console.log('🔧 Testing settings save functionality...');
+ console.log('🔧 Testing settings auto-save functionality...');
await navigateTo(page, `${baseUrl}/settings/`);
- // Wait for page to load completely
- await page.waitForSelector('#save-all-btn, button[type="submit"]', { timeout: 15000 });
+ await page.waitForSelector('#settings-form', { timeout: 15000 });
+ await page.waitForSelector('.ldr-settings-checkbox:not([disabled])', { timeout: 15000 });
- console.log('🔍 Looking for save button...');
-
- // Look for save buttons
- const saveButtons = await page.$$('button[type="submit"], .save-btn, button[onclick*="save"], #save-all-btn');
- console.log(`Found ${saveButtons.length} save buttons`);
-
- if (saveButtons.length > 0) {
- console.log('✅ Clicking save button...');
+ const bulkSubmitButton = await page.$('#settings-form button[type="submit"]');
+ if (bulkSubmitButton) {
+ throw new Error('Save All Settings button should not be present');
+ }
- // Start listening for the save response BEFORE clicking
- const responsePromise = page.waitForResponse(
- r => r.url().includes('/save_all_settings'),
- { timeout: 15000 }
- );
- await saveButtons[0].click();
+ const checkbox = await page.$('.ldr-settings-checkbox:not([disabled])');
+ const responsePromise = page.waitForResponse(
+ r => r.url().includes('/save_all_settings'),
+ { timeout: 15000 }
+ );
- // Wait for the save response
- console.log('⏳ Waiting for save response...');
- try {
- await responsePromise;
- } catch {
- console.log('⚠️ Save response not captured (endpoint may differ)');
- }
-
- // Check for success/error messages
- const messages = await page.$$('.alert, .message, .notification, .success, .error');
- if (messages.length > 0) {
- console.log(`📝 Found ${messages.length} message elements:`);
- for (let i = 0; i < messages.length; i++) {
- const text = await page.evaluate(el => ({
- text: el.textContent.trim(),
- className: el.className
- }), messages[i]);
- console.log(` ${i + 1}. [${text.className}]: ${text.text}`);
- }
- }
- } else {
- console.log('❌ No save buttons found');
+ await checkbox.click();
+ const response = await responsePromise;
+ if (!response.ok()) {
+ throw new Error(`Auto-save failed with HTTP ${response.status()}`);
}
+ console.log('✅ Per-setting auto-save completed without a bulk-submit button');
+
} catch (error) {
console.error('❌ Test error:', error);
failed = true;