~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.
Python academiaanthropicarxivbravedeep-researchencryptionhome-automationhomeserverlocallocal-deep-researchlocal-llmmistralollamaopenaipubmedresearchresearch-toolretrieval-augmented-generationsearxngself-hosted
fix(library): gate filesystem PDF storage option in UI modal (#7402)
S57e9a848c489
diff --git a/changelog.d/7402.bugfix.md b/changelog.d/7402.bugfix.mdnew file mode 100644index 0000000000..76c050dcc5--- /dev/null+++ b/changelog.d/7402.bugfix.md@@ -0,0 +1 @@+Gate the unencrypted filesystem PDF storage option in the library storage mode modal behind `LDR_RESEARCH_LIBRARY_ALLOW_FILESYSTEM_PDF_STORAGE`, and coerce un-gated filesystem mode settings to database storage on library page views.diff --git a/src/local_deep_research/research_library/services/pdf_storage_manager.py b/src/local_deep_research/research_library/services/pdf_storage_manager.pyindex 146506e556..aadb75d5b2 100644--- a/src/local_deep_research/research_library/services/pdf_storage_manager.py+++ b/src/local_deep_research/research_library/services/pdf_storage_manager.py@@ -51,6 +51,9 @@ def filesystem_pdf_storage_allowed() -> bool:)+_COERCION_WARNED = False++def resolve_pdf_storage_mode(mode):"""Resolve the effective PDF storage mode, enforcing the operator gate.@@ -67,18 +70,19 @@ def resolve_pdf_storage_mode(mode):back to the filesystem regardless of ``storage_mode``, so anypreviously-written plaintext files stay readable after coercion."""- if (- isinstance(mode, str)- and mode.strip().lower() == "filesystem"- and not filesystem_pdf_storage_allowed()- ):- logger.warning(- "Unencrypted filesystem PDF storage is operator-gated and "- "disabled; coercing pdf_storage_mode 'filesystem' -> 'database' "- "(set LDR_RESEARCH_LIBRARY_ALLOW_FILESYSTEM_PDF_STORAGE=true to "- "opt in)."- )- return "database"+ global _COERCION_WARNED+ if isinstance(mode, str) and mode.strip().lower() == "filesystem":+ if not filesystem_pdf_storage_allowed():+ if not _COERCION_WARNED:+ _COERCION_WARNED = True+ logger.warning(+ "Unencrypted filesystem PDF storage is operator-gated and "+ "disabled; coercing pdf_storage_mode 'filesystem' -> 'database' "+ "(set LDR_RESEARCH_LIBRARY_ALLOW_FILESYSTEM_PDF_STORAGE=true to "+ "opt in)."+ )+ return "database"+ _COERCION_WARNED = Falsereturn modediff --git a/src/local_deep_research/web/routers/library.py b/src/local_deep_research/web/routers/library.pyindex d9ff7f8472..9e4a99944a 100644--- a/src/local_deep_research/web/routers/library.py+++ b/src/local_deep_research/web/routers/library.py@@ -42,7 +42,10 @@ from ...library.download_management import ResourceFilterfrom ...security.url_validator import URLValidatorfrom ...research_library.services.download_service import DownloadServicefrom ...research_library.services.library_service import LibraryService-from ...research_library.services.pdf_storage_manager import PDFStorageManager+from ...research_library.services.pdf_storage_manager import (+ PDFStorageManager,+ resolve_pdf_storage_mode,+)from ...security import failure_reason_for_log, redact_url_for_logfrom ...research_library.utils import (apply_user_subdir,@@ -203,8 +206,10 @@ def library_page(try:with get_user_db_session(username) as db_session:settings = get_settings_manager(db_session, username)- pdf_storage_mode = settings.get_setting(- "research_library.pdf_storage_mode", "database"+ pdf_storage_mode = resolve_pdf_storage_mode(+ settings.get_setting(+ "research_library.pdf_storage_mode", "database"+ ))shared_library = settings.get_setting("research_library.shared_library", False@@ -357,8 +362,10 @@ def download_manager_page(service = LibraryService(username)with get_user_db_session(username) as db_session:settings = get_settings_manager(db_session, username)- pdf_storage_mode = settings.get_setting(- "research_library.pdf_storage_mode", "database"+ pdf_storage_mode = resolve_pdf_storage_mode(+ settings.get_setting(+ "research_library.pdf_storage_mode", "database"+ ))shared_library = settings.get_setting("research_library.shared_library", Falsediff --git a/src/local_deep_research/web/template_config.py b/src/local_deep_research/web/template_config.pyindex 6ae7750a8d..fe4989ab6e 100644--- a/src/local_deep_research/web/template_config.py+++ b/src/local_deep_research/web/template_config.py@@ -138,6 +138,20 @@ class _LDRTemplates(Jinja2Templates):context["has_encryption"] = db_manager.has_encryptionkwargs["context"] = context+ # Inject filesystem_pdf_storage_allowed for every render so that+ # templates (such as storage_mode_modal.html) can gate the unencrypted+ # filesystem storage option without requiring each route to remember+ # passing it.+ if "filesystem_pdf_storage_allowed" not in context:+ from ..research_library.services.pdf_storage_manager import (+ filesystem_pdf_storage_allowed,+ )++ context["filesystem_pdf_storage_allowed"] = (+ filesystem_pdf_storage_allowed()+ )+ kwargs["context"] = context+# Inject the user's saved egress scope so base.html renders it onto# <body data-scope=…> on EVERY page. Previously only routes going# through dependencies/template_helpers.render_template got this;diff --git a/src/local_deep_research/web/templates/components/storage_mode_modal.html b/src/local_deep_research/web/templates/components/storage_mode_modal.htmlindex ca48bc9435..70a35c8487 100644--- a/src/local_deep_research/web/templates/components/storage_mode_modal.html+++ b/src/local_deep_research/web/templates/components/storage_mode_modal.html@@ -21,6 +21,7 @@</div></label>+ {% if filesystem_pdf_storage_allowed %}<label class="ldr-storage-mode-option" data-mode="filesystem"><input type="radio" name="storage_mode" value="filesystem" {% if pdf_storage_mode == 'filesystem' %}checked{% endif %}><div class="ldr-option-content">@@ -34,6 +35,7 @@</div></div></label>+ {% endif %}<label class="ldr-storage-mode-option" data-mode="none"><input type="radio" name="storage_mode" value="none" {% if pdf_storage_mode == 'none' %}checked{% endif %}>diff --git a/tests/research_library/services/test_pdf_storage_gate.py b/tests/research_library/services/test_pdf_storage_gate.pyindex 8fb074cf3a..2f8b11cad4 100644--- a/tests/research_library/services/test_pdf_storage_gate.py+++ b/tests/research_library/services/test_pdf_storage_gate.py@@ -55,6 +55,24 @@ class TestFilesystemPdfStorageGate:):assert resolve_pdf_storage_mode(value) == "database"+ def test_resolve_coercion_warns_once(self, gate_off, loguru_caplog):+ from local_deep_research.research_library.services import (+ pdf_storage_manager,+ )++ pdf_storage_manager._COERCION_WARNED = False+ with loguru_caplog.at_level("WARNING"):+ assert resolve_pdf_storage_mode("filesystem") == "database"+ assert resolve_pdf_storage_mode("filesystem") == "database"++ coercion_warnings = [+ r+ for r in loguru_caplog.records+ if "coercing pdf_storage_mode 'filesystem' -> 'database'"+ in r.message+ ]+ assert len(coercion_warnings) == 1+def test_resolve_preserves_filesystem_when_gate_on(self, gate_on):assert resolve_pdf_storage_mode("filesystem") == "filesystem"diff --git a/tests/web/routers/test_library_download_outcomes.py b/tests/web/routers/test_library_download_outcomes.pyindex dac51411a8..3de113b63b 100644--- a/tests/web/routers/test_library_download_outcomes.py+++ b/tests/web/routers/test_library_download_outcomes.py@@ -1011,13 +1011,32 @@ PDF_STORAGE_PAGES = [class TestEnablePdfStorage:@pytest.mark.parametrize("handler", PDF_STORAGE_PAGES)@pytest.mark.parametrize("mode", ["database", "filesystem"])- def test_a_storage_mode_enables_the_download_controls(self, handler, mode):+ def test_a_storage_mode_enables_the_download_controls(+ self, monkeypatch, handler, mode+ ):"""Positive control, asserted before the "none" case."""+ if mode == "filesystem":+ monkeypatch.setenv(+ "LDR_RESEARCH_LIBRARY_ALLOW_FILESYSTEM_PDF_STORAGE", "true"+ )context = _page_context(handler, mode)assert context["enable_pdf_storage"] is Trueassert context["pdf_storage_mode"] == mode+ @pytest.mark.parametrize("handler", PDF_STORAGE_PAGES)+ def test_gate_off_coerces_filesystem_mode_to_database(+ self, monkeypatch, handler+ ):+ """When the operator gate is off, stored filesystem mode resolves to database."""+ monkeypatch.delenv(+ "LDR_RESEARCH_LIBRARY_ALLOW_FILESYSTEM_PDF_STORAGE", raising=False+ )+ context = _page_context(handler, "filesystem")++ assert context["enable_pdf_storage"] is True+ assert context["pdf_storage_mode"] == "database"+@pytest.mark.parametrize("handler", PDF_STORAGE_PAGES)def test_mode_none_disables_the_download_controls(self, handler):context = _page_context(handler, "none")diff --git a/tests/web/routers/test_storage_mode_modal_gate.py b/tests/web/routers/test_storage_mode_modal_gate.pynew file mode 100644index 0000000000..fc4e9b9bbf--- /dev/null+++ b/tests/web/routers/test_storage_mode_modal_gate.py@@ -0,0 +1,59 @@+"""Tests for the PDF storage mode gate in the UI modal and library pages."""++from local_deep_research.web.template_config import templates+from starlette.requests import Request+++class TestStorageModeModalGate:+ """Test that the filesystem storage option in storage_mode_modal.html is gated."""++ def test_modal_hides_filesystem_when_gate_off(self):+ t = templates.get_template("components/storage_mode_modal.html")+ html = t.render(+ filesystem_pdf_storage_allowed=False,+ pdf_storage_mode="database",+ )+ assert 'data-mode="filesystem"' not in html+ assert 'value="filesystem"' not in html+ assert 'data-mode="database"' in html+ assert 'data-mode="none"' in html++ def test_modal_shows_filesystem_when_gate_on(self):+ t = templates.get_template("components/storage_mode_modal.html")+ html = t.render(+ filesystem_pdf_storage_allowed=True,+ pdf_storage_mode="filesystem",+ )+ assert 'data-mode="filesystem"' in html+ assert 'value="filesystem"' in html+ assert "checked" in html+ assert 'data-mode="database"' in html+ assert 'data-mode="none"' in html++ def test_template_response_injects_gate_flag_when_off(self, monkeypatch):+ monkeypatch.delenv(+ "LDR_RESEARCH_LIBRARY_ALLOW_FILESYSTEM_PDF_STORAGE", raising=False+ )+ req = Request(scope={"type": "http", "session": {}})+ resp = templates.TemplateResponse(+ request=req,+ name="components/storage_mode_modal.html",+ context={"pdf_storage_mode": "database"},+ )+ body = resp.body.decode("utf-8")+ assert 'data-mode="filesystem"' not in body+ assert 'data-mode="database"' in body++ def test_template_response_injects_gate_flag_when_on(self, monkeypatch):+ monkeypatch.setenv(+ "LDR_RESEARCH_LIBRARY_ALLOW_FILESYSTEM_PDF_STORAGE", "true"+ )+ req = Request(scope={"type": "http", "session": {}})+ resp = templates.TemplateResponse(+ request=req,+ name="components/storage_mode_modal.html",+ context={"pdf_storage_mode": "filesystem"},+ )+ body = resp.body.decode("utf-8")+ assert 'data-mode="filesystem"' in body+ assert 'data-mode="database"' in body