Skip to content

~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.

test(ui): add history delete lifecycle test (#5311)

LearningCircuit5f94aae1fd12
diff --git a/.github/workflows/docker-tests.yml b/.github/workflows/docker-tests.yml
index 1906f346da..3d914bf1f1 100644
--- a/.github/workflows/docker-tests.yml
+++ b/.github/workflows/docker-tests.yml
@@ -824,6 +824,21 @@ jobs:
echo "::endgroup::"
fi
+ if [ "${SHARD}" = "history-news" ]; then
+ echo "::group::Seed history delete fixtures"
+ docker run --rm \
+ -v "${GITHUB_WORKSPACE}":/app \
+ -v "${GITHUB_WORKSPACE}/ci-data":/data \
+ -e TEST_ENV=true \
+ -e LDR_DATA_DIR=/data \
+ -e LDR_DB_CONFIG_KDF_ITERATIONS=1000 \
+ -e LDR_TEST_MODE=1 \
+ -w /app/src \
+ "${TEST_IMAGE}" \
+ python ../scripts/ci/seed_history_delete.py
+ echo "::endgroup::"
+ fi
+
echo "::group::Start application server"
docker run -d \
--name ldr-server \
diff --git a/scripts/ci/seed_history_delete.py b/scripts/ci/seed_history_delete.py
new file mode 100644
index 0000000000..00dcbcbf84
--- /dev/null
+++ b/scripts/ci/seed_history_delete.py
@@ -0,0 +1,70 @@
+#!/usr/bin/env python3
+import json
+import os
+import uuid
+from datetime import UTC, datetime
+from pathlib import Path
+
+from sqlalchemy.orm import Session
+
+TEST_USERNAME = "test_admin"
+TEST_PASSWORD = "testpass123" # pragma: allowlist secret
+_SEED_NS = uuid.UUID("00000000-0000-0000-0000-00000000d5d3")
+
+
+def main():
+ data_dir = Path(
+ os.environ.get(
+ "LDR_DATA_DIR",
+ Path.home() / ".local" / "share" / "local-deep-research",
+ )
+ )
+ print(f"Using data directory: {data_dir}")
+
+ from local_deep_research.database.encrypted_db import db_manager
+ from local_deep_research.database.models.research import ResearchHistory
+
+ engine = db_manager.open_user_database(TEST_USERNAME, TEST_PASSWORD)
+ if engine is None:
+ raise RuntimeError(
+ f"Could not open encrypted database for user '{TEST_USERNAME}'. "
+ "Was init_test_database.py run first with matching "
+ "LDR_TEST_MODE / LDR_DB_CONFIG_KDF_ITERATIONS?"
+ )
+
+ research_id = str(uuid.uuid5(_SEED_NS, "history-delete"))
+ created_at = datetime.now(UTC).isoformat()
+
+ with Session(engine) as session:
+ existing = (
+ session.query(ResearchHistory)
+ .filter(ResearchHistory.id == research_id)
+ .first()
+ )
+ if existing is None:
+ session.add(
+ ResearchHistory(
+ id=research_id,
+ query="Seed: deterministic history deletion research",
+ title="History deletion fixture",
+ mode="quick_summary",
+ status="completed",
+ report_content="# Seeded history deletion report",
+ created_at=created_at,
+ completed_at=created_at,
+ )
+ )
+ session.commit()
+ print(f"Seeded history deletion fixture {research_id}")
+ else:
+ print("History deletion fixture already present — nothing to do.")
+
+ manifest = {"research_id": research_id, "seeded_at": created_at}
+ manifest_path = data_dir / "history_delete_seed.json"
+ manifest_path.parent.mkdir(parents=True, exist_ok=True)
+ manifest_path.write_text(json.dumps(manifest, indent=2), encoding="utf-8")
+ print(f"Wrote seed manifest: {manifest_path}")
+
+
+if __name__ == "__main__":
+ main()
diff --git a/tests/ui_tests/run_all_tests.js b/tests/ui_tests/run_all_tests.js
index 013cbdf5c4..f719046d53 100644
--- a/tests/ui_tests/run_all_tests.js
+++ b/tests/ui_tests/run_all_tests.js
@@ -337,7 +337,7 @@ const tests = [
},
// =====================================================================
- // Shard: history-news (3 tests)
+ // Shard: history-news (4 tests)
// =====================================================================
{
name: 'History Page CI Tests',
@@ -357,6 +357,12 @@ const tests = [
shard: 'history-news',
description: 'Tests news feeds, subscription CRUD, form validation'
},
+ {
+ name: 'History Delete CI Tests',
+ file: 'test_history_delete_ci.js',
+ shard: 'history-news',
+ description: 'Clicks delete button, handles confirm dialog, asserts item removed from DOM and DELETE API fires.'
+ },
// =====================================================================
// Shard: mobile (4 tests)
diff --git a/tests/ui_tests/test_history_delete_ci.js b/tests/ui_tests/test_history_delete_ci.js
new file mode 100644
index 0000000000..d47c443ab7
--- /dev/null
+++ b/tests/ui_tests/test_history_delete_ci.js
@@ -0,0 +1,365 @@
+#!/usr/bin/env node
+const fs = require('fs');
+const path = require('path');
+const { setupTest, teardownTest, TestResults, log, navigateTo, withTimeout } = require('./test_lib');
+
+const CONFIRM_DELETE_MESSAGE = 'Are you sure you want to delete this research? This action cannot be undone.';
+const DELETE_QUIET_PERIOD_MS = 500;
+const LIFECYCLE_WAIT_TIMEOUT_MS = 10000;
+
+function loadManifest() {
+ const dataDir = process.env.LDR_DATA_DIR
+ || path.join(process.env.HOME || '/tmp', '.local', 'share', 'local-deep-research');
+ const manifestPath = path.join(dataDir, 'history_delete_seed.json');
+ let manifestText;
+
+ try {
+ manifestText = fs.readFileSync(manifestPath, 'utf8');
+ } catch (error) {
+ throw new Error(
+ `History deletion seed manifest is missing or unreadable at ${manifestPath}: ${error.message}. ` +
+ 'Run scripts/ci/seed_history_delete.py first.'
+ );
+ }
+
+ let manifest;
+ try {
+ manifest = JSON.parse(manifestText);
+ } catch (error) {
+ throw new Error(
+ `History deletion seed manifest is malformed JSON at ${manifestPath}: ${error.message}. ` +
+ 'Run scripts/ci/seed_history_delete.py first.'
+ );
+ }
+
+ if (!manifest || typeof manifest !== 'object' || Array.isArray(manifest)) {
+ throw new Error(
+ `History deletion seed manifest must be an object at ${manifestPath}. ` +
+ 'Run scripts/ci/seed_history_delete.py first.'
+ );
+ }
+ if (typeof manifest.research_id !== 'string' || manifest.research_id.trim() === '') {
+ throw new Error(
+ `History deletion seed manifest has a blank research_id at ${manifestPath}. ` +
+ 'Run scripts/ci/seed_history_delete.py first.'
+ );
+ }
+
+ return manifest;
+}
+
+async function navigateToSeededResearch(page, baseUrl, researchId) {
+ await navigateTo(page, `${baseUrl}/history`);
+ await page.waitForSelector(`[data-id="${researchId}"]`, { visible: true, timeout: 10000 });
+}
+
+function createEventWaiter(page, event, predicate, label, timeoutMs = LIFECYCLE_WAIT_TIMEOUT_MS) {
+ let settled = false;
+ let resolveWaiter;
+ let rejectWaiter;
+
+ const handler = (candidate) => {
+ try {
+ if (predicate(candidate)) {
+ finish(resolveWaiter, candidate);
+ }
+ } catch (error) {
+ finish(rejectWaiter, error);
+ }
+ };
+
+ const finish = (complete, value) => {
+ if (settled) return;
+ settled = true;
+ clearTimeout(timeoutId);
+ page.off(event, handler);
+ complete(value);
+ };
+
+ const promise = new Promise((resolve, reject) => {
+ resolveWaiter = resolve;
+ rejectWaiter = reject;
+ });
+ page.on(event, handler);
+ const timeoutId = setTimeout(() => {
+ finish(rejectWaiter, new Error(`Timed out waiting for ${label}.`));
+ }, timeoutMs);
+
+ return {
+ promise,
+ dispose() {
+ if (settled) return;
+ settled = true;
+ clearTimeout(timeoutId);
+ page.off(event, handler);
+ }
+ };
+}
+
+function createDialogWaiter(page, action) {
+ let settled = false;
+ let resolveWaiter;
+ let rejectWaiter;
+
+ const finish = (complete, value) => {
+ if (settled) return;
+ settled = true;
+ clearTimeout(timeoutId);
+ page.off('dialog', handler);
+ complete(value);
+ };
+
+ const handler = dialog => {
+ let dialogInfo;
+ try {
+ dialogInfo = {
+ type: dialog.type(),
+ message: dialog.message()
+ };
+ } catch (error) {
+ finish(rejectWaiter, error);
+ return;
+ }
+ Promise.resolve(dialog[action]()).then(
+ () => finish(resolveWaiter, dialogInfo),
+ error => finish(rejectWaiter, error)
+ );
+ };
+
+ const promise = new Promise((resolve, reject) => {
+ resolveWaiter = resolve;
+ rejectWaiter = reject;
+ });
+ page.on('dialog', handler);
+ const timeoutId = setTimeout(() => {
+ finish(rejectWaiter, new Error(`Timed out waiting to ${action} delete confirmation.`));
+ }, LIFECYCLE_WAIT_TIMEOUT_MS);
+
+ return {
+ promise,
+ dispose() {
+ if (settled) return;
+ settled = true;
+ clearTimeout(timeoutId);
+ page.off('dialog', handler);
+ }
+ };
+}
+
+function createBoundedDelay(delayMs) {
+ let timeoutId;
+ const promise = new Promise(resolve => {
+ timeoutId = setTimeout(resolve, delayMs);
+ });
+
+ return {
+ promise,
+ dispose() {
+ clearTimeout(timeoutId);
+ }
+ };
+}
+
+function deleteEndpoint(baseUrl, researchId) {
+ return new URL(`/api/delete/${encodeURIComponent(researchId)}`, baseUrl).href;
+}
+
+function isExactRequest(request, method, url) {
+ return request.method() === method && request.url() === url;
+}
+
+const HistoryDeleteTests = {
+ async deleteButtonExists(page, baseUrl, researchId) {
+ await navigateToSeededResearch(page, baseUrl, researchId);
+
+ const visible = await page.$eval(
+ `[data-id="${researchId}"] .ldr-delete-item-btn`,
+ button => !!(button.offsetWidth || button.offsetHeight || button.getClientRects().length)
+ );
+ return {
+ passed: visible,
+ message: visible
+ ? 'Delete button is visible on the seeded history item.'
+ : 'Delete button is not visible on the seeded history item.'
+ };
+ },
+
+ async cancelDeletePreservesItem(page, baseUrl, researchId) {
+ await navigateToSeededResearch(page, baseUrl, researchId);
+
+ const deleteUrl = deleteEndpoint(baseUrl, researchId);
+ const deleteRequests = [];
+ const requestHandler = request => {
+ if (request.method() === 'DELETE') {
+ deleteRequests.push(request);
+ }
+ };
+ const dialogWaiter = createDialogWaiter(page, 'dismiss');
+ let quietPeriod;
+ page.on('request', requestHandler);
+
+ try {
+ await page.click(`[data-id="${researchId}"] .ldr-delete-item-btn`);
+ const dialogInfo = await dialogWaiter.promise;
+ quietPeriod = createBoundedDelay(DELETE_QUIET_PERIOD_MS);
+ await quietPeriod.promise;
+ const itemExists = await page.$(`[data-id="${researchId}"]`) !== null;
+ const passed = itemExists &&
+ deleteRequests.length === 0 &&
+ dialogInfo.type === 'confirm' &&
+ dialogInfo.message === CONFIRM_DELETE_MESSAGE;
+
+ return {
+ passed,
+ message: passed
+ ? `Canceling the delete confirmation preserved the seeded history item without a DELETE request to ${deleteUrl}.`
+ : `Cancel delete failed (itemExists=${itemExists}, deleteRequests=${deleteRequests.length}, type="${dialogInfo.type}", dialog="${dialogInfo.message}").`
+ };
+ } finally {
+ quietPeriod?.dispose();
+ dialogWaiter.dispose();
+ page.off('request', requestHandler);
+ }
+ },
+
+ async clickDeleteRemovesItem(page, baseUrl, researchId) {
+ await navigateToSeededResearch(page, baseUrl, researchId);
+
+ const deleteUrl = deleteEndpoint(baseUrl, researchId);
+ const historyUrl = new URL('/history/api', baseUrl).href;
+ const deleteRequests = [];
+ const requestHandler = request => {
+ if (request.method() === 'DELETE') {
+ deleteRequests.push(request);
+ }
+ };
+ const dialogWaiter = createDialogWaiter(page, 'accept');
+ const deleteResponseWaiter = createEventWaiter(
+ page,
+ 'response',
+ response => isExactRequest(response.request(), 'DELETE', deleteUrl),
+ `DELETE ${deleteUrl}`
+ );
+ let historyResponseWaiter;
+ page.on('request', requestHandler);
+
+ try {
+ await page.click(`[data-id="${researchId}"] .ldr-delete-item-btn`);
+ const [dialogInfo, response] = await Promise.all([
+ dialogWaiter.promise,
+ deleteResponseWaiter.promise
+ ]);
+ await page.waitForSelector(`[data-id="${researchId}"]`, { hidden: true, timeout: 10000 });
+ await page.waitForFunction(
+ () => document.querySelector('#notification-banner-polite span')?.textContent?.trim() === 'Research deleted successfully',
+ { timeout: 10000 }
+ );
+ const itemRemoved = await page.$(`[data-id="${researchId}"]`) === null;
+ const toastText = await page.$eval(
+ '#notification-banner-polite span',
+ banner => banner.textContent?.trim() || ''
+ );
+
+ historyResponseWaiter = createEventWaiter(
+ page,
+ 'response',
+ historyResponse => historyResponse.status() === 200 &&
+ isExactRequest(historyResponse.request(), 'GET', historyUrl),
+ `GET ${historyUrl}`
+ );
+ await page.reload({ waitUntil: 'domcontentloaded', timeout: 10000 });
+ const historyResponse = await historyResponseWaiter.promise;
+ const historyData = await historyResponse.json();
+ if (!historyData || typeof historyData !== 'object' || Array.isArray(historyData) || !Array.isArray(historyData.items)) {
+ throw new Error('History API returned an invalid response: expected an object with an items array.');
+ }
+ const historyContainsResearch = historyData.items.some(item =>
+ item && typeof item === 'object' && String(item.id) === String(researchId)
+ );
+ await page.waitForFunction(
+ () => {
+ const historyItems = document.getElementById('history-items');
+ if (!historyItems || historyItems.querySelector('.ldr-loading-spinner')) return false;
+ if (historyItems.querySelector('.ldr-history-item')) return true;
+
+ const emptyMessage = document.getElementById('history-empty-message');
+ if (!emptyMessage) return false;
+ const emptyMessageStyle = window.getComputedStyle(emptyMessage);
+ return !!(emptyMessage.offsetWidth || emptyMessage.offsetHeight || emptyMessage.getClientRects().length) &&
+ emptyMessageStyle.display !== 'none' &&
+ emptyMessageStyle.visibility !== 'hidden' &&
+ Number(emptyMessageStyle.opacity) !== 0;
+ },
+ { timeout: 10000 }
+ );
+ const itemStillRemoved = await page.$(`[data-id="${researchId}"]`) === null;
+ const passed = deleteRequests.length === 1 &&
+ isExactRequest(deleteRequests[0], 'DELETE', deleteUrl) &&
+ response.status() === 200 &&
+ historyResponse.status() === 200 &&
+ !historyContainsResearch &&
+ itemRemoved &&
+ itemStillRemoved &&
+ dialogInfo.type === 'confirm' &&
+ dialogInfo.message === CONFIRM_DELETE_MESSAGE &&
+ toastText === 'Research deleted successfully';
+ return {
+ passed,
+ message: passed
+ ? 'One DELETE returned 200, the confirmation and toast appeared, and the item stayed absent after reloading history.'
+ : `Delete failed (deleteRequests=${deleteRequests.length}, deleteStatus=${response.status()}, historyStatus=${historyResponse.status()}, historyContainsResearch=${historyContainsResearch}, itemRemoved=${itemRemoved}, itemStillRemoved=${itemStillRemoved}, type="${dialogInfo.type}", dialog="${dialogInfo.message}", successToast="${toastText}").`
+ };
+ } finally {
+ historyResponseWaiter?.dispose();
+ deleteResponseWaiter.dispose();
+ dialogWaiter.dispose();
+ page.off('request', requestHandler);
+ }
+ }
+};
+
+async function main() {
+ log.section('History Delete CI Tests');
+ const manifest = loadManifest();
+ const results = new TestResults('History Delete CI Tests');
+
+ const ctx = await setupTest({ authenticate: true });
+ const { page } = ctx;
+ const { baseUrl } = ctx.config;
+ const subTestTimeout = ctx.config.isCI ? 60000 : 30000;
+
+ async function run(name, testFn) {
+ try {
+ const result = await withTimeout(testFn(page, baseUrl, manifest.research_id), subTestTimeout, `History Delete/${name}`);
+ if (result.skipped) {
+ results.skip('History Delete', name, result.message);
+ } else {
+ results.add('History Delete', name, result.passed, result.message);
+ }
+ } catch (error) {
+ results.add('History Delete', name, false, `Error: ${error.message}`);
+ }
+ }
+
+ try {
+ await run('Delete Button Exists', HistoryDeleteTests.deleteButtonExists);
+ await run('Cancel Delete Preserves Item', HistoryDeleteTests.cancelDeletePreservesItem);
+ // Destructive: keep last so the first two checks can use the seeded row.
+ await run('Click Delete Removes Item', HistoryDeleteTests.clickDeleteRemovesItem);
+ } finally {
+ results.print();
+ results.save();
+ await teardownTest(ctx);
+ }
+
+ process.exit(results.exitCode());
+}
+
+if (require.main === module) {
+ main().catch(error => {
+ console.error('Test runner failed:', error);
+ process.exit(1);
+ });
+}
+
+module.exports = { HistoryDeleteTests, loadManifest };