~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.
Python academiaanthropicarxivbravedeep-researchencryptionhome-automationhomeserverlocallocal-deep-researchlocal-llmmistralollamaopenaipubmedresearchresearch-toolretrieval-augmented-generationsearxngself-hosted
fix(library): expose duplicate deletion races (#5428)
Ziyang Guo616e49ea744a
diff --git a/src/local_deep_research/research_library/deletion/services/document_deletion.py b/src/local_deep_research/research_library/deletion/services/document_deletion.pyindex eb10d2e80e..9a7cb36321 100644--- a/src/local_deep_research/research_library/deletion/services/document_deletion.py+++ b/src/local_deep_research/research_library/deletion/services/document_deletion.py@@ -41,7 +41,11 @@ _document_delete_locks_guard = threading.Lock()def _hold_document_delete_lock(username: str, document_id: str) -> Iterator[None]:- """Hold the process-local lock for one user's document deletion."""+ """Hold the process-local lock for one user's document deletion.++ The lock is intentionally non-reentrant. Callers must not start a nested+ deletion for the same user and document while this context is active.+ """key = (username, document_id)with _document_delete_locks_guard:lock = _document_delete_locks.get(key)@@ -255,8 +259,9 @@ class DocumentDeletionService:session, document_id)if not actually_deleted:- logger.debug(- f"Document {document_id} was not deleted by CascadeHelper (already removed by concurrent request)"+ logger.info(+ f"Document {document_id[:8]}... was already removed "+ "by a concurrent delete request")session.rollback()return {diff --git a/tests/research_library/deletion/services/test_document_deletion.py b/tests/research_library/deletion/services/test_document_deletion.pyindex 6c59f81964..5fbcf79c4d 100644--- a/tests/research_library/deletion/services/test_document_deletion.py+++ b/tests/research_library/deletion/services/test_document_deletion.py@@ -121,7 +121,7 @@ class TestDocumentDeletionServiceDeleteDocument:patch.object(service, "_purge_document_rag") as mock_purge,patch("local_deep_research.research_library.deletion.services.document_deletion.logger.info"- ) as mock_success_log,+ ) as mock_info_log,):mock_helper.get_document_collections.return_value = ["col-1"]mock_helper.get_document_blob_size.return_value = 0@@ -137,7 +137,10 @@ class TestDocumentDeletionServiceDeleteDocument:mock_session.rollback.assert_called_once()mock_session.commit.assert_not_called()mock_purge.assert_not_called()- mock_success_log.assert_not_called()+ mock_info_log.assert_called_once_with(+ "Document doc-race... was already removed by a concurrent "+ "delete request"+ )def test_serializes_same_document_deletes_across_service_instances(self):"""The second request must wait until the first deletion fully exits."""