Skip to content

~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.

test(ui-tests): real assertions for metrics dashboard (dead-field audit) (#4668)

LearningCircuitda6dca5664cd
diff --git a/tests/ui_tests/test_metrics_dashboard_ci.js b/tests/ui_tests/test_metrics_dashboard_ci.js
index 0392491a87..9c6a37c43b 100644
--- a/tests/ui_tests/test_metrics_dashboard_ci.js
+++ b/tests/ui_tests/test_metrics_dashboard_ci.js
@@ -17,20 +17,23 @@ const MetricsDashboardTests = {
await navigateTo(page, `${baseUrl}/metrics/`);
const result = await page.evaluate(() => {
+ // Page-specific container rendered server-side by pages/metrics.html:
+ // <div class="ldr-page active" id="metrics">
+ const container = document.querySelector('#metrics.ldr-page');
+ const header = container?.querySelector('.ldr-page-header h1');
+
return {
- hasContent: !!document.querySelector('.metrics-container, .ldr-metrics, #metrics, .dashboard'),
- hasHeader: !!document.querySelector('h1, .metrics-header, .page-title'),
- headerText: document.querySelector('h1, .metrics-header, .page-title')?.textContent?.trim(),
- hasCards: document.querySelectorAll('.metric-card, .stats-card, .card, .ldr-card').length
+ hasContainer: !!container,
+ headerText: header?.textContent?.trim()
};
});
- const passed = result.hasContent || result.hasHeader || result.hasCards > 0;
+ const passed = result.hasContainer;
return {
passed,
message: passed
- ? `Metrics dashboard loaded (header: "${result.headerText}", cards: ${result.hasCards})`
- : 'Metrics dashboard failed to load'
+ ? `Metrics dashboard loaded (header: "${result.headerText}")`
+ : 'Metrics dashboard container (#metrics.ldr-page) not found — wrong page loaded'
};
},
@@ -175,29 +178,23 @@ const MetricsDashboardTests = {
await delay(1000);
const result = await page.evaluate(() => {
- const searchSection = document.querySelector(
- '[class*="search"], ' +
- '[id*="search-metrics"], ' +
- '.search-stats'
- );
-
- const hasSearchData = document.body.textContent?.toLowerCase().includes('search') &&
- (document.body.textContent?.toLowerCase().includes('queries') ||
- document.body.textContent?.toLowerCase().includes('engine'));
+ // Dedicated "Search Activity Over Time" chart canvas and the
+ // "Search Engines" breakdown container rendered by pages/metrics.html.
+ const chartCanvas = document.querySelector('canvas#search-activity-chart');
+ const engineBreakdown = document.querySelector('#search-engine-breakdown');
return {
- hasSearchSection: !!searchSection,
- hasSearchData
+ hasChartCanvas: !!chartCanvas,
+ hasEngineBreakdown: !!engineBreakdown
};
});
- if (!result.hasSearchSection && !result.hasSearchData) {
- return { passed: null, skipped: true, message: 'No search metrics section found' };
- }
-
+ const passed = result.hasChartCanvas && result.hasEngineBreakdown;
return {
- passed: true,
- message: 'Search metrics section found'
+ passed,
+ message: passed
+ ? 'Search metrics section found (#search-activity-chart + #search-engine-breakdown)'
+ : `Search metrics elements missing (chart=${result.hasChartCanvas}, engineBreakdown=${result.hasEngineBreakdown})`
};
},
@@ -233,28 +230,23 @@ const MetricsDashboardTests = {
await navigateTo(page, `${baseUrl}/metrics/`);
const result = await page.evaluate(() => {
- const satisfactionSection = document.querySelector(
- '[class*="satisfaction"], ' +
- '[class*="rating"], ' +
- '[id*="satisfaction"]'
- );
-
- const hasSatisfactionData = document.body.textContent?.toLowerCase().includes('satisfaction') ||
- document.body.textContent?.toLowerCase().includes('rating');
+ // Dedicated "User Satisfaction" breakdown container and the
+ // average user rating metric tile, both rendered by pages/metrics.html.
+ const satisfactionSection = document.querySelector('#rating-breakdown');
+ const avgRatingValue = document.querySelector('.ldr-metric-value#avg-user-rating');
return {
hasSatisfactionSection: !!satisfactionSection,
- hasSatisfactionData
+ hasAvgRatingValue: !!avgRatingValue
};
});
- if (!result.hasSatisfactionSection && !result.hasSatisfactionData) {
- return { passed: null, skipped: true, message: 'No satisfaction metrics found' };
- }
-
+ const passed = result.hasSatisfactionSection && result.hasAvgRatingValue;
return {
- passed: true,
- message: 'User satisfaction metrics found'
+ passed,
+ message: passed
+ ? 'User satisfaction metrics found (#rating-breakdown + #avg-user-rating)'
+ : `User satisfaction elements missing (section=${result.hasSatisfactionSection}, avgValue=${result.hasAvgRatingValue})`
};
}
};
@@ -267,21 +259,24 @@ const CostAnalyticsTests = {
await navigateTo(page, `${baseUrl}/metrics/costs`);
const result = await page.evaluate(() => {
+ // Page-specific container rendered server-side by pages/cost_analytics.html:
+ // <div class="ldr-page active" id="cost-analytics">
+ // <div class="ldr-cost-analytics-container"> ...
+ const container = document.querySelector('#cost-analytics.ldr-page .ldr-cost-analytics-container');
+ const header = document.querySelector('#cost-analytics .ldr-cost-header h1');
+
return {
- hasContent: !!document.querySelector('.cost-analytics, .costs-container, #costs, .analytics'),
- hasHeader: !!document.querySelector('h1, .page-title'),
- headerText: document.querySelector('h1, .page-title')?.textContent?.trim(),
- hasCostData: document.body.textContent?.toLowerCase().includes('cost') ||
- document.body.textContent?.toLowerCase().includes('$')
+ hasContainer: !!container,
+ headerText: header?.textContent?.trim()
};
});
- const passed = result.hasContent || result.hasHeader || result.hasCostData;
+ const passed = result.hasContainer;
return {
passed,
message: passed
? `Cost analytics page loaded (header: "${result.headerText}")`
- : 'Cost analytics page failed to load'
+ : 'Cost analytics container (#cost-analytics .ldr-cost-analytics-container) not found — wrong page loaded'
};
},
@@ -385,20 +380,23 @@ const StarReviewsTests = {
await navigateTo(page, `${baseUrl}/metrics/star-reviews`);
const result = await page.evaluate(() => {
+ // Page-specific container rendered server-side by pages/star_reviews.html:
+ // <div class="ldr-star-reviews-container">
+ const container = document.querySelector('.ldr-star-reviews-container');
+ const header = container?.querySelector('.ldr-metrics-header h1');
+
return {
- hasContent: !!document.querySelector('.star-reviews, .reviews-container, #reviews'),
- hasHeader: !!document.querySelector('h1, .page-title'),
- headerText: document.querySelector('h1, .page-title')?.textContent?.trim(),
- hasStars: document.querySelectorAll('.star, [class*="star"], .fa-star, svg[class*="star"]').length
+ hasContainer: !!container,
+ headerText: header?.textContent?.trim()
};
});
- const passed = result.hasContent || result.hasHeader || result.hasStars > 0;
+ const passed = result.hasContainer;
return {
passed,
message: passed
- ? `Star reviews page loaded (header: "${result.headerText}", stars: ${result.hasStars})`
- : 'Star reviews page failed to load'
+ ? `Star reviews page loaded (header: "${result.headerText}")`
+ : 'Star reviews container (.ldr-star-reviews-container) not found — wrong page loaded'
};
},
@@ -476,20 +474,23 @@ const LinkAnalyticsTests = {
await navigateTo(page, `${baseUrl}/metrics/links`);
const result = await page.evaluate(() => {
+ // Page-specific container rendered server-side by pages/link_analytics.html:
+ // <div class="ldr-link-analytics-container">
+ const container = document.querySelector('.ldr-link-analytics-container');
+ const header = container?.querySelector('h1');
+
return {
- hasContent: !!document.querySelector('.link-analytics, .links-container, #links'),
- hasHeader: !!document.querySelector('h1, .page-title'),
- headerText: document.querySelector('h1, .page-title')?.textContent?.trim(),
- hasTable: !!document.querySelector('table')
+ hasContainer: !!container,
+ headerText: header?.textContent?.trim()
};
});
- const passed = result.hasContent || result.hasHeader || result.hasTable;
+ const passed = result.hasContainer;
return {
passed,
message: passed
? `Link analytics page loaded (header: "${result.headerText}")`
- : 'Link analytics page failed to load'
+ : 'Link analytics container (.ldr-link-analytics-container) not found — wrong page loaded'
};
},