Skip to content

~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.

test: delete 10 no-assertion tests across 2 search_integration files (#4281)

LearningCircuitdbbee862ab11
diff --git a/tests/news/test_search_integration_comprehensive.py b/tests/news/test_search_integration_comprehensive.py
index c4e8b1cfcf..5d5c0d40b1 100644
--- a/tests/news/test_search_integration_comprehensive.py
+++ b/tests/news/test_search_integration_comprehensive.py
@@ -71,39 +71,6 @@ class TestTrackingEnabledProperty:
class TestNewsSearchCallbackCall:
"""Tests for NewsSearchCallback __call__ method."""
- def test_accepts_query_and_result(self):
- """Test accepts query and result parameters."""
- from local_deep_research.news.core.search_integration import (
- NewsSearchCallback,
- )
-
- callback = NewsSearchCallback()
-
- # Should not raise
- callback("test query", {"findings": []})
-
- def test_accepts_optional_context(self):
- """Test accepts optional context parameter."""
- from local_deep_research.news.core.search_integration import (
- NewsSearchCallback,
- )
-
- callback = NewsSearchCallback()
-
- # Should not raise
- callback("test query", {}, {"user_id": "user123"})
-
- def test_handles_none_context(self):
- """Test handles None context gracefully."""
- from local_deep_research.news.core.search_integration import (
- NewsSearchCallback,
- )
-
- callback = NewsSearchCallback()
-
- # Should not raise
- callback("test query", {}, None)
-
def test_defaults_is_user_search_to_true(self):
"""Test defaults is_user_search to True in context."""
from local_deep_research.news.core.search_integration import (
@@ -161,34 +128,6 @@ class TestTrackUserSearch:
assert hasattr(callback, "_track_user_search")
assert callable(callback._track_user_search)
- def test_track_user_search_accepts_parameters(self):
- """Test _track_user_search accepts required parameters."""
- from local_deep_research.news.core.search_integration import (
- NewsSearchCallback,
- )
- import inspect
-
- callback = NewsSearchCallback()
- sig = inspect.signature(callback._track_user_search)
- params = list(sig.parameters.keys())
-
- assert "search_id" in params
- assert "user_id" in params
- assert "query" in params
- assert "result" in params
-
- def test_track_user_search_handles_exceptions(self):
- """Test _track_user_search handles exceptions gracefully."""
- from local_deep_research.news.core.search_integration import (
- NewsSearchCallback,
- )
-
- callback = NewsSearchCallback()
-
- # Should not raise even with potential import errors
- # (The actual import happens inside the method)
- callback._track_user_search("id", "user", "query", {})
-
class TestCalculateQuality:
"""Tests for _calculate_quality method."""
diff --git a/tests/news/test_search_integration_extended.py b/tests/news/test_search_integration_extended.py
index bb19af643a..0bb18741c3 100644
--- a/tests/news/test_search_integration_extended.py
+++ b/tests/news/test_search_integration_extended.py
@@ -56,30 +56,6 @@ class TestNewsSearchCallbackInit:
class TestNewsSearchCallbackCall:
"""Tests for NewsSearchCallback.__call__() method."""
- def test_call_does_not_track_when_disabled(self):
- """__call__ does not track when tracking is disabled."""
- from local_deep_research.news.core.search_integration import (
- NewsSearchCallback,
- )
-
- callback = NewsSearchCallback()
- callback._tracking_enabled = False
-
- # Should not raise
- callback("test query", {"findings": []})
-
- def test_call_accepts_none_context(self):
- """__call__ accepts None context."""
- from local_deep_research.news.core.search_integration import (
- NewsSearchCallback,
- )
-
- callback = NewsSearchCallback()
- callback._tracking_enabled = False
-
- # Should not raise
- callback("test query", {"findings": []}, context=None)
-
def test_call_extracts_user_id_from_context(self):
"""__call__ extracts user_id from context."""
from local_deep_research.news.core.search_integration import (
@@ -246,30 +222,6 @@ class TestCalculateQuality:
assert many_findings > few_findings
-class TestTrackUserSearch:
- """Tests for _track_user_search() method."""
-
- def test_handles_missing_search_tracker(self):
- """Handles missing SearchTracker gracefully."""
- from local_deep_research.news.core.search_integration import (
- NewsSearchCallback,
- )
-
- callback = NewsSearchCallback()
-
- # Should not raise even if SearchTracker doesn't exist
- with patch("local_deep_research.news.core.search_integration.logger"):
- callback._track_user_search(
- search_id="test-id",
- user_id="user1",
- query="test query",
- result={"findings": []},
- )
-
- # May log exception if SearchTracker import fails
- # But should not raise
-
-
class TestCreateSearchWrapper:
"""Tests for create_search_wrapper() function."""
@@ -386,37 +338,6 @@ class TestWrappedSearchContext:
mock.__name__ = "test_search_method"
return mock
- def test_context_includes_is_user_search(self):
- """Context includes is_user_search flag."""
- from local_deep_research.news.core.search_integration import (
- create_search_wrapper,
- )
-
- original = self._create_named_mock({"findings": []})
- wrapped = create_search_wrapper(original)
-
- # Just verify the wrapper works without raising
- mock_self = Mock()
- result = wrapped(mock_self, "query", is_user_search=True)
-
- assert result == {"findings": []}
-
- def test_context_has_search_id(self):
- """Context includes search_id."""
- from local_deep_research.news.core.search_integration import (
- create_search_wrapper,
- )
-
- original = self._create_named_mock({"findings": []})
- wrapped = create_search_wrapper(original)
-
- # The search_id is generated inside the wrapper
- mock_self = Mock()
- result = wrapped(mock_self, "query")
-
- # Result is from original, wrapper generates ID internally
- assert result == {"findings": []}
-
class TestNewsSearchCallbackDefaults:
"""Tests for NewsSearchCallback default behavior."""