Skip to content

~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.

fix(history): paginate /api/history to bound memory (#4560) (#4597)

LearningCircuitf0dea74ab705
diff --git a/changelog.d/+paginate-api-history.bugfix.md b/changelog.d/+paginate-api-history.bugfix.md
new file mode 100644
index 0000000000..5b378ef7f6
--- /dev/null
+++ b/changelog.d/+paginate-api-history.bugfix.md
@@ -0,0 +1 @@
+The `/api/history` endpoint now paginates its results (default 200, max 500) instead of loading every research row — and its `research_meta` JSON — into memory at once.
diff --git a/src/local_deep_research/web/routes/research_routes.py b/src/local_deep_research/web/routes/research_routes.py
index 6ec12880b1..8271efd0ed 100644
--- a/src/local_deep_research/web/routes/research_routes.py
+++ b/src/local_deep_research/web/routes/research_routes.py
@@ -1307,9 +1307,17 @@ def get_history():
"""Get research history"""
username = session["username"]
+ # Bound the result set. Without a limit this endpoint loaded every
+ # research row (and its research_meta JSON, which can hold a settings
+ # snapshot) into memory at once (#4560). Mirrors the clamp used by the
+ # symmetric /history/api endpoint.
+ limit = request.args.get("limit", 200, type=int)
+ limit = max(1, min(limit, 500))
+ offset = max(0, request.args.get("offset", 0, type=int))
+
try:
with get_user_db_session(username) as db_session:
- # Query all research history ordered by created_at. Project
+ # Query research history ordered by created_at. Project
# only the metadata columns the loop below consumes — never
# the large ``report_content`` Text body — so this listing
# doesn't pull every report into memory (#4560). This mirrors
@@ -1327,6 +1335,8 @@ def get_history():
ResearchHistory.chat_session_id,
)
.order_by(ResearchHistory.created_at.desc())
+ .limit(limit)
+ .offset(offset)
.all()
)
diff --git a/tests/web/routes/test_research_routes.py b/tests/web/routes/test_research_routes.py
index 45e7305d5c..14627628fa 100644
--- a/tests/web/routes/test_research_routes.py
+++ b/tests/web/routes/test_research_routes.py
@@ -315,7 +315,7 @@ class TestGetHistoryApi:
def test_returns_history_when_authenticated(self, authenticated_client):
"""Should return history when authenticated."""
mock_session = MagicMock()
- mock_session.query.return_value.order_by.return_value.all.return_value = []
+ mock_session.query.return_value.order_by.return_value.limit.return_value.offset.return_value.all.return_value = []
with patch(f"{_RR}.get_user_db_session") as mock_db:
mock_db.return_value.__enter__ = lambda s: mock_session
mock_db.return_value.__exit__ = MagicMock(return_value=False)
@@ -324,6 +324,24 @@ class TestGetHistoryApi:
)
assert response.status_code == 200, response.status_code
+ def test_pagination_is_clamped(self, authenticated_client):
+ """/api/history must bound its result set: ?limit=-1 (which SQLite
+ treats as "no limit") is clamped to >= 1 and offset to >= 0 so the
+ endpoint can't load the whole history into memory (#4560)."""
+ mock_session = MagicMock()
+ mock_session.query.return_value.order_by.return_value.limit.return_value.offset.return_value.all.return_value = []
+ with patch(f"{_RR}.get_user_db_session") as mock_db:
+ mock_db.return_value.__enter__ = lambda s: mock_session
+ mock_db.return_value.__exit__ = MagicMock(return_value=False)
+ response = authenticated_client.get(
+ f"{RESEARCH_PREFIX}/api/history?limit=-1&offset=-5"
+ )
+ assert response.status_code == 200, response.status_code
+
+ records_q = mock_session.query.return_value.order_by.return_value
+ records_q.limit.assert_called_once_with(1)
+ records_q.limit.return_value.offset.assert_called_once_with(0)
+
def test_query_projects_columns_not_full_entity(self, authenticated_client):
"""/api/history must project only metadata columns, never the
full ResearchHistory entity — querying the entity eagerly loads
@@ -333,7 +351,7 @@ class TestGetHistoryApi:
from local_deep_research.database.models import ResearchHistory
mock_session = MagicMock()
- mock_session.query.return_value.order_by.return_value.all.return_value = []
+ mock_session.query.return_value.order_by.return_value.limit.return_value.offset.return_value.all.return_value = []
with patch(f"{_RR}.get_user_db_session") as mock_db:
mock_db.return_value.__enter__ = lambda s: mock_session
mock_db.return_value.__exit__ = MagicMock(return_value=False)
diff --git a/tests/web/routes/test_research_routes_deep_coverage.py b/tests/web/routes/test_research_routes_deep_coverage.py
index 7b5bf11961..f29455f45a 100644
--- a/tests/web/routes/test_research_routes_deep_coverage.py
+++ b/tests/web/routes/test_research_routes_deep_coverage.py
@@ -317,7 +317,7 @@ class TestGetHistory:
title="My Research",
)
ms = _mock_db_session()
- ms.query.return_value.order_by.return_value.all.return_value = [
+ ms.query.return_value.order_by.return_value.limit.return_value.offset.return_value.all.return_value = [
research
]
ms.query.return_value.filter_by.return_value.count.return_value = 3
diff --git a/tests/web/routes/test_research_routes_extra_coverage.py b/tests/web/routes/test_research_routes_extra_coverage.py
index 33f0aac9f9..35065932b3 100644
--- a/tests/web/routes/test_research_routes_extra_coverage.py
+++ b/tests/web/routes/test_research_routes_extra_coverage.py
@@ -918,7 +918,7 @@ class TestGetHistory:
research_meta={"submission": {"model": "gpt4"}},
)
ms = _mock_db_session()
- ms.query.return_value.order_by.return_value.all.return_value = [
+ ms.query.return_value.order_by.return_value.limit.return_value.offset.return_value.all.return_value = [
research
]
# Document count query: now a single GROUP BY query rather than
@@ -945,7 +945,7 @@ class TestGetHistory:
"""History item without completed_at → duration_seconds is None."""
research = _make_research(completed_at=None, title=None)
ms = _mock_db_session()
- ms.query.return_value.order_by.return_value.all.return_value = [
+ ms.query.return_value.order_by.return_value.limit.return_value.offset.return_value.all.return_value = [
research
]
ms.query.return_value.filter.return_value.group_by.return_value.all.return_value = []