Skip to content

~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.

fix(tests): narrow broad status-code tautologies in news/test_flask_api.py (#4136)

LearningCircuitf9d30d980d90
diff --git a/tests/news/test_flask_api.py b/tests/news/test_flask_api.py
index 6c82a971e7..b2aaff4d88 100644
--- a/tests/news/test_flask_api.py
+++ b/tests/news/test_flask_api.py
@@ -137,7 +137,7 @@ class TestNewsFeedEndpoint:
try:
response = client.get("/news/api/feed")
# Route exists - any response is valid (may require auth)
- assert response.status_code in [200, 302, 400, 401, 403, 404, 500]
+ assert response.status_code == 401, response.status_code
except Exception:
# If app context fails, that's okay - we're testing route existence
pass
@@ -154,7 +154,7 @@ class TestSubscriptionEndpoints:
content_type="application/json",
)
# Route exists - any response is valid
- assert response.status_code in [200, 302, 400, 401, 403, 404, 500]
+ assert response.status_code == 401, response.status_code
except Exception:
pass
@@ -167,7 +167,7 @@ class TestSubscriptionEndpoints:
content_type="application/json",
)
# Route exists - any response is valid
- assert response.status_code in [200, 302, 400, 401, 403, 404, 500]
+ assert response.status_code == 401, response.status_code
except Exception:
pass
@@ -180,7 +180,7 @@ class TestFolderEndpoints:
response = client.get("/news/api/folders")
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
def test_create_folder_requires_auth(self, client):
"""Test that create folder endpoint requires authentication."""
@@ -191,7 +191,7 @@ class TestFolderEndpoints:
)
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
class TestSchedulerEndpoints:
@@ -202,7 +202,7 @@ class TestSchedulerEndpoints:
try:
response = client.get("/news/api/scheduler/status")
# Route may or may not exist - any response is valid
- assert response.status_code in [200, 302, 400, 401, 403, 404, 500]
+ assert response.status_code == 401, response.status_code
except Exception:
pass
@@ -215,7 +215,7 @@ class TestRecommenderEndpoints:
response = client.get("/news/api/recommender/status")
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
class TestSubscriptionRunEndpoint:
@@ -226,7 +226,7 @@ class TestSubscriptionRunEndpoint:
response = client.post("/news/api/subscription/sub123/run")
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
class TestGetSubscription:
@@ -237,7 +237,7 @@ class TestGetSubscription:
response = client.get("/news/api/subscription/sub123")
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
class TestUpdateSubscription:
@@ -252,7 +252,7 @@ class TestUpdateSubscription:
)
# Should require auth
- assert response.status_code in [302, 401, 403, 404, 405]
+ assert response.status_code == 404, response.status_code
class TestDeleteSubscription:
@@ -263,7 +263,7 @@ class TestDeleteSubscription:
response = client.delete("/news/api/subscription/sub123")
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
class TestNewsCardInteractions:
@@ -274,14 +274,14 @@ class TestNewsCardInteractions:
response = client.post("/news/api/card/card123/dismiss")
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
def test_bookmark_card_requires_auth(self, client):
"""Test that bookmark card endpoint requires authentication."""
response = client.post("/news/api/card/card123/bookmark")
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
def test_rate_card_requires_auth(self, client):
"""Test that rate card endpoint requires authentication."""
@@ -292,7 +292,7 @@ class TestNewsCardInteractions:
)
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
class TestSubscriptionsList:
@@ -303,7 +303,7 @@ class TestSubscriptionsList:
response = client.get("/news/api/subscriptions")
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
class TestNotificationEndpoints:
@@ -318,7 +318,7 @@ class TestNotificationEndpoints:
)
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
class TestRefreshEndpoint:
@@ -329,7 +329,7 @@ class TestRefreshEndpoint:
response = client.post("/news/api/refresh")
# Should require auth
- assert response.status_code in [302, 401, 403, 404]
+ assert response.status_code == 404, response.status_code
class TestSchedulerControlRequired:
@@ -1045,15 +1045,7 @@ class TestErrorHandling:
response = client.post(endpoint)
# Any response is acceptable
- assert response.status_code in [
- 200,
- 302,
- 400,
- 401,
- 403,
- 404,
- 500,
- ]
+ assert response.status_code == 401, response.status_code
except Exception:
# If dependencies fail, that's okay - routes may exist
pass