Skip to content

~95% on SimpleQA (e.g. Qwen3.6-27B on a 3090). Supports all local and cloud LLMs (llama.cpp, Ollama, Google, ...). 10+ search engines - arXiv, PubMed, your private documents. Everything Local & Encrypted.

fix(strategies): propagate Flask app context to focused-iteration search workers (#5076)

Ehsanff038464c244
diff --git a/changelog.d/4904.bugfix.md b/changelog.d/4904.bugfix.md
new file mode 100644
index 0000000000..cdfa840be1
--- /dev/null
+++ b/changelog.d/4904.bugfix.md
@@ -0,0 +1 @@
+Focused-iteration searches now run inside the request's Flask app context. Previously the per-question searches were dispatched to worker threads with no app context propagated, so any search touching `current_app`/`g` raised "Working outside of application context"; the error was swallowed per query and the strategy silently returned no results. It now passes `context_factory=thread_context` like the source-based strategy.
diff --git a/src/local_deep_research/advanced_search_system/strategies/focused_iteration_strategy.py b/src/local_deep_research/advanced_search_system/strategies/focused_iteration_strategy.py
index 477f67a6ef..261181f42b 100644
--- a/src/local_deep_research/advanced_search_system/strategies/focused_iteration_strategy.py
+++ b/src/local_deep_research/advanced_search_system/strategies/focused_iteration_strategy.py
@@ -30,6 +30,7 @@ from ...utilities.thread_context import (
get_search_context,
preserve_research_context,
)
+from ...utilities.threading_utils import thread_context
from ..candidate_exploration import ProgressiveExplorer
from ..findings.repository import FindingsRepository
from ..parallel_search import run_parallel_searches
@@ -411,11 +412,18 @@ class FocusedIterationStrategy(BaseSearchStrategy):
# Create context-preserving wrapper for the search function
context_aware_search = preserve_research_context(search_question)
- # Run searches in parallel. No Flask app_context is propagated here
- # (pre-existing behavior) — this strategy does not push a context
- # into the worker threads and relies only on the research-context
- # preservation above.
- completed = run_parallel_searches(queries, context_aware_search)
+ # Run searches in parallel. thread_context (the factory, not a call)
+ # is invoked once per query so each worker thread gets its OWN fresh
+ # Flask app context — required so current_app / g stay accessible
+ # inside self.search.run, matching SourceBasedSearchStrategy. Without
+ # it, a search that touches current_app raises "Working outside of
+ # application context" in the worker, which the per-query handler
+ # above swallows into an empty result.
+ completed = run_parallel_searches(
+ queries,
+ context_aware_search,
+ context_factory=thread_context,
+ )
all_results: List[Dict] = []
for _, payload in completed:
all_results.extend(payload.get("results", []))
diff --git a/tests/advanced_search_system/strategies/test_focused_iteration_strategy.py b/tests/advanced_search_system/strategies/test_focused_iteration_strategy.py
index f5f5aec3c5..008e4df31e 100644
--- a/tests/advanced_search_system/strategies/test_focused_iteration_strategy.py
+++ b/tests/advanced_search_system/strategies/test_focused_iteration_strategy.py
@@ -553,6 +553,52 @@ class TestExecuteParallelSearches:
assert results == []
+ def test_propagates_flask_app_context_into_workers(self):
+ """Regression for #4904: workers must carry the Flask app context.
+
+ _execute_parallel_searches fans queries out across a
+ ThreadPoolExecutor. If the request's Flask app context is not
+ propagated, any search that touches ``current_app`` / ``g`` raises
+ "Working outside of application context" inside the worker; the
+ per-query handler swallows that into an empty result, so the strategy
+ silently returns nothing. Driven from inside a real Flask request
+ context, with a search that reads ``current_app``, every query must
+ come back with its result.
+
+ Before the fix (no ``context_factory``) this returns ``[]`` because
+ each worker's ``current_app`` access fails. Passing
+ ``context_factory=thread_context`` returns both results.
+
+ The real context helpers are left unmocked here on purpose: they are
+ what carries the context across the thread boundary.
+ """
+ from flask import Flask, current_app
+ from local_deep_research.advanced_search_system.strategies.focused_iteration_strategy import (
+ FocusedIterationStrategy,
+ )
+
+ app = Flask(__name__)
+ app.config["LDR_MARKER"] = "reachable"
+
+ def run(query, research_context=None):
+ # Mirror the real search path reading a Flask context-local from
+ # inside the worker thread.
+ return [
+ {"title": query, "marker": current_app.config["LDR_MARKER"]}
+ ]
+
+ mock_search = Mock()
+ mock_search.run.side_effect = run
+
+ strategy = FocusedIterationStrategy(model=Mock(), search=mock_search)
+
+ with app.test_request_context("/"):
+ results = strategy._execute_parallel_searches(["q1", "q2"])
+
+ assert len(results) == 2
+ assert {r["title"] for r in results} == {"q1", "q2"}
+ assert all(r["marker"] == "reachable" for r in results)
+
class TestAnalyzeTopic:
"""Tests for analyze_topic method."""