Practical patterns, starters & CLI tools for loop engineering with AI coding agents. Design systems that prompt and orchestrate agents (inspired by Addy Osmani and Boris Cherny). Includes loop-audit, loop-init, loop-cost.
TypeScript agentic-aiai-agentsai-codinganthropicautomationclaudeclaude-codecodexcoding-agentsdevops-automationdevtoolsgithub-actionsgrokllmloop-engineeringmcpprompt-engineering
fix(ci): isolate audit and validation gate temp files (#362)
cyril44383ab945a3
diff --git a/.github/workflows/audit.yml b/.github/workflows/audit.ymlindex 28cb733..89679bf 100644--- a/.github/workflows/audit.yml+++ b/.github/workflows/audit.yml@@ -25,18 +25,22 @@ jobs:cache-dependency-path: tools/loop-audit/package-lock.json- name: Build, test & run loop-audit on the reference + starters+ env:+ LOOP_AUDIT_OUTPUT_FILE: ${{ runner.temp }}/audit.jsonrun: bash scripts/ci-audit-gates.sh- name: Comment PR with loop readiness scoreif: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repositorycontinue-on-error: true+ env:+ LOOP_AUDIT_OUTPUT_FILE: ${{ runner.temp }}/audit.jsonuses: actions/github-script@v9with:script: |const fs = require('fs');let data;try {- data = JSON.parse(fs.readFileSync('/tmp/audit.json', 'utf8'));+ data = JSON.parse(fs.readFileSync(process.env.LOOP_AUDIT_OUTPUT_FILE, 'utf8'));} catch (e) {core.setFailed('Could not read audit JSON for PR comment');return;@@ -58,4 +62,4 @@ jobs:repo: context.repo.repo,issue_number: context.issue.number,body,- });\ No newline at end of file+ });diff --git a/scripts/ci-audit-gates.sh b/scripts/ci-audit-gates.shindex 0b770fd..226a5e0 100755--- a/scripts/ci-audit-gates.sh+++ b/scripts/ci-audit-gates.sh@@ -3,6 +3,9 @@set -euo pipefailREPO_ROOT="$(cd "$(dirname "$0")/.." && pwd)"+AUDIT_TMP_DIR="$(mktemp -d "${TMPDIR:-/tmp}/loop-engineering-audit.XXXXXX")"+trap 'rm -rf "$AUDIT_TMP_DIR"' EXIT+ROOT_AUDIT_FILE="$AUDIT_TMP_DIR/root-audit.json"echo "Building readiness-core…"(@@ -15,35 +18,41 @@ cd "$REPO_ROOT/tools/loop-audit"npm cinpm testecho "=== Audit of repo root ==="-node dist/cli.js "$REPO_ROOT" --json > /tmp/root-audit.json+node dist/cli.js "$REPO_ROOT" --json > "$ROOT_AUDIT_FILE"echo ""echo "=== Audit of starters (L1 gate) ==="FAILED=0for s in "$REPO_ROOT"/starters/*/; doNAME=$(basename "$s")- node dist/cli.js "$s" --json > "/tmp/starter-${NAME}.json"- node -e "- const data = JSON.parse(require('fs').readFileSync('/tmp/starter-${NAME}.json', 'utf8'));- console.log('--- ${NAME}: score=' + data.score + ' level=' + data.level);+ STARTER_AUDIT_FILE="$AUDIT_TMP_DIR/starter-${NAME}.json"+ node dist/cli.js "$s" --json > "$STARTER_AUDIT_FILE"+ STARTER_AUDIT_FILE="$STARTER_AUDIT_FILE" STARTER_NAME="$NAME" node -e '+ const fs = require("fs");+ const data = JSON.parse(fs.readFileSync(process.env.STARTER_AUDIT_FILE, "utf8"));+ console.log("--- " + process.env.STARTER_NAME + ": score=" + data.score + " level=" + data.level);if (data.score < 38) {- console.error('Starter ${NAME} below L1 threshold (38): ' + data.score);+ console.error("Starter " + process.env.STARTER_NAME + " below L1 threshold (38): " + data.score);process.exit(1);}- " || FAILED=1+ ' || FAILED=1doneif [ "$FAILED" -ne 0 ]; thenecho "One or more starters failed L1 gate"exit 1fi-cp /tmp/root-audit.json /tmp/audit.json-node -e '+ROOT_AUDIT_FILE="$ROOT_AUDIT_FILE" node -e 'const fs = require("fs");- const data = JSON.parse(fs.readFileSync("/tmp/audit.json", "utf8"));+ const data = JSON.parse(fs.readFileSync(process.env.ROOT_AUDIT_FILE, "utf8"));console.log("Reference score: " + data.score);if (data.score < 58) {console.error("Reference score below L2 threshold (58). Restore dogfood signals: STATE.md, skills/, AGENTS.md.");process.exit(2);}'-echo "audit gates passed ✓"\ No newline at end of file++if [[ -n "${LOOP_AUDIT_OUTPUT_FILE:-}" ]]; then+ cp "$ROOT_AUDIT_FILE" "$LOOP_AUDIT_OUTPUT_FILE"+fi++echo "audit gates passed ✓"diff --git a/scripts/ci-validate-gates.sh b/scripts/ci-validate-gates.shindex 6741434..850d9d2 100755--- a/scripts/ci-validate-gates.sh+++ b/scripts/ci-validate-gates.sh@@ -2,14 +2,19 @@# Pattern/registry validation gates — shared by validate-patterns.yml and daily-triage.ymlset -euo pipefail+VALIDATE_TMP_DIR="$(mktemp -d "${TMPDIR:-/tmp}/loop-engineering-validate.XXXXXX")"+trap 'rm -rf "$VALIDATE_TMP_DIR"' EXIT+REGISTRY_FILE="$VALIDATE_TMP_DIR/registry.txt"+PATTERN_FILES="$VALIDATE_TMP_DIR/files.txt"+echo "Patterns declared in registry:"-grep '^\s*-\s*id:' patterns/registry.yaml | sed 's/.*id: //' | sort > /tmp/registry.txt+grep '^\s*-\s*id:' patterns/registry.yaml | sed 's/.*id: //' | sort > "$REGISTRY_FILE"echo "Pattern markdown files:"-ls patterns/*.md | xargs -n1 basename | sed 's/.md$//' | grep -v README | sort > /tmp/files.txt-echo "=== Registry ==="; cat /tmp/registry.txt-echo "=== Files ==="; cat /tmp/files.txt-comm -23 /tmp/files.txt /tmp/registry.txt | grep . && (echo "ERROR: pattern md file(s) missing from registry.yaml"; exit 1) || echo "All pattern files registered ✓"-comm -23 /tmp/registry.txt /tmp/files.txt | grep . && (echo "ERROR: registry entry without matching .md"; exit 1) || echo "No orphan registry entries ✓"+ls patterns/*.md | xargs -n1 basename | sed 's/.md$//' | grep -v README | sort > "$PATTERN_FILES"+echo "=== Registry ==="; cat "$REGISTRY_FILE"+echo "=== Files ==="; cat "$PATTERN_FILES"+comm -23 "$PATTERN_FILES" "$REGISTRY_FILE" | grep . && (echo "ERROR: pattern md file(s) missing from registry.yaml"; exit 1) || echo "All pattern files registered ✓"+comm -23 "$REGISTRY_FILE" "$PATTERN_FILES" | grep . && (echo "ERROR: registry entry without matching .md"; exit 1) || echo "No orphan registry entries ✓"echo "Checking that key sections exist in patterns (lightweight)"for f in patterns/*.md; do@@ -97,4 +102,4 @@ cd ../mcp-servernpm cinpm test-echo "validate gates passed ✓"\ No newline at end of file+echo "validate gates passed ✓"