Skip to content

Practical patterns, starters & CLI tools for loop engineering with AI coding agents. Design systems that prompt and orchestrate agents (inspired by Addy Osmani and Boris Cherny). Includes loop-audit, loop-init, loop-cost.

fix(loop-context): don't crash when an --on-exceed hook ignores stdin (#524)

JonyT Agenticb191cef2f6b7
diff --git a/tools/loop-context/dist/cli.js b/tools/loop-context/dist/cli.js
index 676c3f7..06e76e6 100755
--- a/tools/loop-context/dist/cli.js
+++ b/tools/loop-context/dist/cli.js
@@ -276,6 +276,14 @@ function runOnExceedHook(script, decision) {
resolve();
});
child.on('close', () => resolve());
+ // The hook script may exit without ever reading stdin (e.g. a notify
+ // script that ignores its input). Writing to that already-closed pipe
+ // then raises an 'error' event (EPIPE on POSIX, EOF on Windows) on the
+ // stream itself; left unhandled, Node treats that as an uncaught
+ // exception and crashes the whole process. This hook is documented as
+ // fire-and-forget, so a write failure here must not escalate past the
+ // 'close' handler above, which resolves regardless.
+ child.stdin.on('error', () => { });
child.stdin.write(JSON.stringify(decision));
child.stdin.end();
});
diff --git a/tools/loop-context/src/cli.ts b/tools/loop-context/src/cli.ts
index ac3681a..b0592f0 100644
--- a/tools/loop-context/src/cli.ts
+++ b/tools/loop-context/src/cli.ts
@@ -302,6 +302,14 @@ function runOnExceedHook(script: string, decision: BreakerDecision): Promise<voi
resolve();
});
child.on('close', () => resolve());
+ // The hook script may exit without ever reading stdin (e.g. a notify
+ // script that ignores its input). Writing to that already-closed pipe
+ // then raises an 'error' event (EPIPE on POSIX, EOF on Windows) on the
+ // stream itself; left unhandled, Node treats that as an uncaught
+ // exception and crashes the whole process. This hook is documented as
+ // fire-and-forget, so a write failure here must not escalate past the
+ // 'close' handler above, which resolves regardless.
+ child.stdin.on('error', () => {});
child.stdin.write(JSON.stringify(decision));
child.stdin.end();
});
diff --git a/tools/loop-context/test/cli.test.mjs b/tools/loop-context/test/cli.test.mjs
index f2dcb4b..0506f45 100644
--- a/tools/loop-context/test/cli.test.mjs
+++ b/tools/loop-context/test/cli.test.mjs
@@ -10,6 +10,7 @@ import { resolveDailyBudgetFromPattern } from '../dist/budget-resolver.js';
const testDir = path.dirname(fileURLToPath(import.meta.url));
const cli = path.join(testDir, '../dist/cli.js');
const onExceedCaptureScript = path.join(testDir, 'fixtures/on-exceed-capture.mjs');
+const onExceedIgnoreStdinScript = path.join(testDir, 'fixtures/on-exceed-ignore-stdin.mjs');
async function freshDir() {
return mkdtemp(path.join(tmpdir(), 'loop-context-cli-daily-'));
@@ -28,6 +29,9 @@ function runCli(args, input = stagnationLedger) {
return spawnSync(process.execPath, [cli, ...args], {
input,
encoding: 'utf8',
+ // Default 1MB is too small once a decision's JSON echoes back a large
+ // error string (see the --on-exceed EPIPE regression test below).
+ maxBuffer: 20 * 1024 * 1024,
});
}
@@ -154,3 +158,31 @@ test('cli --on-exceed is not invoked when the run continues', async () => {
assert.equal(r.status, 0);
await assert.rejects(() => readFile(outFile, 'utf8'));
});
+
+test('cli --on-exceed does not crash when the hook script exits without reading stdin', async () => {
+ const dir = await freshDir();
+ const outFile = path.join(dir, 'ran.marker');
+
+ // A large first-line error survives errorSignature() unshortened, so the
+ // piped decision JSON is big enough to exceed the OS pipe buffer -- this
+ // makes the write-after-close failure (EPIPE on POSIX, EOF on Windows)
+ // land reliably instead of racing the hook process's own startup time.
+ const bigError = 'e'.repeat(5_000_000);
+ const bigLedger = JSON.stringify({
+ goal: 'x',
+ attempts: [
+ { iteration: 1, action: 'a', outcome: 'failure', error: bigError },
+ { iteration: 2, action: 'a', outcome: 'failure', error: bigError },
+ { iteration: 3, action: 'a', outcome: 'failure', error: bigError },
+ ],
+ });
+
+ const r = runCli(
+ ['--check', '--on-exceed', `node ${onExceedIgnoreStdinScript} ${outFile}`, '--json'],
+ bigLedger,
+ );
+
+ assert.equal(r.status, 2, `expected a clean escalation exit, not a crash. stderr: ${r.stderr}`);
+ assert.doesNotMatch(r.stderr, /Uncaught|EPIPE|EOF/);
+ assert.equal(await readFile(outFile, 'utf8'), 'ran');
+});
diff --git a/tools/loop-context/test/fixtures/on-exceed-ignore-stdin.mjs b/tools/loop-context/test/fixtures/on-exceed-ignore-stdin.mjs
new file mode 100644
index 0000000..e44ff5b
--- /dev/null
+++ b/tools/loop-context/test/fixtures/on-exceed-ignore-stdin.mjs
@@ -0,0 +1,6 @@
+import { writeFileSync } from 'node:fs';
+
+// Deliberately never reads stdin -- simulates an operator's notify script
+// that ignores its input entirely. Writes a marker first so the test can
+// confirm this process actually ran despite draining nothing.
+writeFileSync(process.argv[2], 'ran');