Practical patterns, starters & CLI tools for loop engineering with AI coding agents. Design systems that prompt and orchestrate agents (inspired by Addy Osmani and Boris Cherny). Includes loop-audit, loop-init, loop-cost.
TypeScript agentic-aiai-agentsai-codinganthropicautomationclaudeclaude-codecodexcoding-agentsdevops-automationdevtoolsgithub-actionsgrokllmloop-engineeringmcpprompt-engineering
fix(loop-context): lock the daily-spend state file against concurrent writers (#521)
JonyT Agenticc39ca419b69c
diff --git a/tools/loop-context/dist/daily-spend.js b/tools/loop-context/dist/daily-spend.jsindex 16da555..61acff4 100644--- a/tools/loop-context/dist/daily-spend.js+++ b/tools/loop-context/dist/daily-spend.js@@ -1,5 +1,5 @@import path from 'node:path';-import { mkdir, readFile, writeFile } from 'node:fs/promises';+import { mkdir, readFile, writeFile, open, unlink, stat } from 'node:fs/promises';/** Today's date in UTC, as YYYY-MM-DD — the daily-spend rollover boundary. */export function todayUTC() {return new Date().toISOString().slice(0, 10);@@ -7,6 +7,54 @@ export function todayUTC() {function statePath(dir, pattern) {return path.join(dir, `daily-spend.${pattern}.json`);}+function lockPath(dir, pattern) {+ return path.join(dir, `.daily-spend.${pattern}.lock`);+}+const LOCK_STALE_MS = 30000;+const LOCK_TIMEOUT_MS = 30000;+/**+ * Serializes read-modify-write access to one pattern's state file, the same+ * lock-file-plus-poll shape loop-worktree's manifest mutex uses. Without+ * this, two overlapping invocations (e.g. two scheduled loops hitting the+ * same pattern) both read the same stale total and the second write clobbers+ * the first, silently losing a delta from the daily-budget circuit breaker.+ */+async function withLock(dir, pattern, fn) {+ await mkdir(dir, { recursive: true });+ const lock = lockPath(dir, pattern);+ const deadline = Date.now() + LOCK_TIMEOUT_MS;+ for (;;) {+ try {+ const handle = await open(lock, 'wx');+ await handle.close();+ break;+ }+ catch (err) {+ if (err.code !== 'EEXIST')+ throw err;+ try {+ const st = await stat(lock);+ if (Date.now() - st.mtimeMs > LOCK_STALE_MS) {+ await unlink(lock).catch(() => { });+ continue;+ }+ }+ catch {+ continue;+ }+ if (Date.now() > deadline) {+ throw new Error(`Timed out waiting for daily-spend lock on "${pattern}". If no other loop-context process is running, delete ${lock} manually.`);+ }+ await new Promise((resolve) => setTimeout(resolve, 15 + Math.random() * 35));+ }+ }+ try {+ return await fn();+ }+ finally {+ await unlink(lock).catch(() => { });+ }+}async function readState(dir, pattern) {try {const raw = await readFile(statePath(dir, pattern), 'utf8');@@ -22,11 +70,13 @@ async function readState(dir, pattern) {* file from a previous day is treated as if it didn't exist.*/export async function recordDailySpend(dir, pattern, tokensDelta) {- const today = todayUTC();- const existing = await readState(dir, pattern);- const carryOver = existing && existing.date === today ? existing.tokensUsedToday : 0;- const state = { date: today, tokensUsedToday: carryOver + tokensDelta };- await mkdir(dir, { recursive: true });- await writeFile(statePath(dir, pattern), JSON.stringify(state, null, 2));- return state;+ return withLock(dir, pattern, async () => {+ const today = todayUTC();+ const existing = await readState(dir, pattern);+ const carryOver = existing && existing.date === today ? existing.tokensUsedToday : 0;+ const state = { date: today, tokensUsedToday: carryOver + tokensDelta };+ await mkdir(dir, { recursive: true });+ await writeFile(statePath(dir, pattern), JSON.stringify(state, null, 2));+ return state;+ });}diff --git a/tools/loop-context/src/daily-spend.ts b/tools/loop-context/src/daily-spend.tsindex 023b054..d44253c 100644--- a/tools/loop-context/src/daily-spend.ts+++ b/tools/loop-context/src/daily-spend.ts@@ -1,5 +1,5 @@import path from 'node:path';-import { mkdir, readFile, writeFile } from 'node:fs/promises';+import { mkdir, readFile, writeFile, open, unlink, stat } from 'node:fs/promises';export interface DailySpendState {date: string;@@ -15,6 +15,57 @@ function statePath(dir: string, pattern: string): string {return path.join(dir, `daily-spend.${pattern}.json`);}+function lockPath(dir: string, pattern: string): string {+ return path.join(dir, `.daily-spend.${pattern}.lock`);+}++const LOCK_STALE_MS = 30000;+const LOCK_TIMEOUT_MS = 30000;++/**+ * Serializes read-modify-write access to one pattern's state file, the same+ * lock-file-plus-poll shape loop-worktree's manifest mutex uses. Without+ * this, two overlapping invocations (e.g. two scheduled loops hitting the+ * same pattern) both read the same stale total and the second write clobbers+ * the first, silently losing a delta from the daily-budget circuit breaker.+ */+async function withLock<T>(dir: string, pattern: string, fn: () => Promise<T>): Promise<T> {+ await mkdir(dir, { recursive: true });+ const lock = lockPath(dir, pattern);+ const deadline = Date.now() + LOCK_TIMEOUT_MS;+ for (;;) {+ try {+ const handle = await open(lock, 'wx');+ await handle.close();+ break;+ } catch (err) {+ if ((err as NodeJS.ErrnoException).code !== 'EEXIST') throw err;++ try {+ const st = await stat(lock);+ if (Date.now() - st.mtimeMs > LOCK_STALE_MS) {+ await unlink(lock).catch(() => {});+ continue;+ }+ } catch {+ continue;+ }++ if (Date.now() > deadline) {+ throw new Error(+ `Timed out waiting for daily-spend lock on "${pattern}". If no other loop-context process is running, delete ${lock} manually.`,+ );+ }+ await new Promise((resolve) => setTimeout(resolve, 15 + Math.random() * 35));+ }+ }+ try {+ return await fn();+ } finally {+ await unlink(lock).catch(() => {});+ }+}+async function readState(dir: string, pattern: string): Promise<DailySpendState | null> {try {const raw = await readFile(statePath(dir, pattern), 'utf8');@@ -34,12 +85,14 @@ export async function recordDailySpend(pattern: string,tokensDelta: number,): Promise<DailySpendState> {- const today = todayUTC();- const existing = await readState(dir, pattern);- const carryOver = existing && existing.date === today ? existing.tokensUsedToday : 0;- const state: DailySpendState = { date: today, tokensUsedToday: carryOver + tokensDelta };+ return withLock(dir, pattern, async () => {+ const today = todayUTC();+ const existing = await readState(dir, pattern);+ const carryOver = existing && existing.date === today ? existing.tokensUsedToday : 0;+ const state: DailySpendState = { date: today, tokensUsedToday: carryOver + tokensDelta };- await mkdir(dir, { recursive: true });- await writeFile(statePath(dir, pattern), JSON.stringify(state, null, 2));- return state;+ await mkdir(dir, { recursive: true });+ await writeFile(statePath(dir, pattern), JSON.stringify(state, null, 2));+ return state;+ });}diff --git a/tools/loop-context/test/daily-spend.test.mjs b/tools/loop-context/test/daily-spend.test.mjsindex cefd66d..a72cff3 100644--- a/tools/loop-context/test/daily-spend.test.mjs+++ b/tools/loop-context/test/daily-spend.test.mjs@@ -49,3 +49,17 @@ test('recordDailySpend persists the state to disk', async () => {const parsed = JSON.parse(raw);assert.equal(parsed.tokensUsedToday, 700);});++test('concurrent recordDailySpend calls for the same pattern do not lose an update', async () => {+ const dir = await freshDir();+ // Two overlapping invocations (e.g. two scheduled loops hitting the same+ // pattern) must not both read the same stale total and clobber each+ // other's write -- every delta has to land.+ await Promise.all([+ recordDailySpend(dir, 'ci-sweeper', 1000),+ recordDailySpend(dir, 'ci-sweeper', 1000),+ ]);+ const raw = await readFile(path.join(dir, 'daily-spend.ci-sweeper.json'), 'utf8');+ const parsed = JSON.parse(raw);+ assert.equal(parsed.tokensUsedToday, 2000);+});