Practical patterns, starters & CLI tools for loop engineering with AI coding agents. Design systems that prompt and orchestrate agents (inspired by Addy Osmani and Boris Cherny). Includes loop-audit, loop-init, loop-cost.
TypeScript agentic-aiai-agentsai-codinganthropicautomationclaudeclaude-codecodexcoding-agentsdevops-automationdevtoolsgithub-actionsgrokllmloop-engineeringmcpprompt-engineering
fix(safety): anchor gate.yaml denylist patterns so nested sensitive paths are actually caught (#536)
JonyT Agenticc693f3e2798b
diff --git a/docs/safety.md b/docs/safety.mdindex e98d5ec..c8cb2dd 100644--- a/docs/safety.md+++ b/docs/safety.md@@ -7,18 +7,18 @@ Loops amplify judgment — good and bad. These guardrails are minimum bar for prThe loop must **never** auto-edit these without human approval:```-.env-.env.*+**/.env+**/.env.***/secrets/****/credentials/****/*_key***/*_secret*-.terraform/**-k8s/production/**+**/.terraform/**+**/k8s/production/****/migrations/** # unless explicit migration loop-auth/**-payments/**-billing/**+**/auth/**+**/payments/**+**/billing/**```Encode in `minimal-fix` and implementer skills:diff --git a/gate.yaml b/gate.yamlindex 60da165..976f4b7 100644--- a/gate.yaml+++ b/gate.yaml@@ -4,18 +4,18 @@version: 1denylist:- - ".env"- - ".env.*"+ - "**/.env"+ - "**/.env.*"- "**/secrets/**"- "**/credentials/**"- "**/*_key*"- "**/*_secret*"- - ".terraform/**"- - "k8s/production/**"+ - "**/.terraform/**"+ - "**/k8s/production/**"- "**/migrations/**"- - "auth/**"- - "payments/**"- - "billing/**"+ - "**/auth/**"+ - "**/payments/**"+ - "**/billing/**"maxFiles: 10diff --git a/templates/gate.yaml.template b/templates/gate.yaml.templateindex 0eb433f..2f34892 100644--- a/templates/gate.yaml.template+++ b/templates/gate.yaml.template@@ -5,18 +5,18 @@version: 1denylist:- - ".env"- - ".env.*"+ - "**/.env"+ - "**/.env.*"- "**/secrets/**"- "**/credentials/**"- "**/*_key*"- "**/*_secret*"- - ".terraform/**"- - "k8s/production/**"+ - "**/.terraform/**"+ - "**/k8s/production/**"- "**/migrations/**"- - "auth/**"- - "payments/**"- - "billing/**"+ - "**/auth/**"+ - "**/payments/**"+ - "**/billing/**"# Escalate instead of auto-merging when a change touches more than this many files.maxFiles: 10diff --git a/tools/loop-audit/dist/autofixer.js b/tools/loop-audit/dist/autofixer.jsindex 6cafa8d..c0b4cb2 100644--- a/tools/loop-audit/dist/autofixer.js+++ b/tools/loop-audit/dist/autofixer.js@@ -152,8 +152,8 @@ const GATE_YAML_TEMPLATE = `# Machine-readable twin of docs/safety.md, enforcedversion: 1denylist:- - ".env"- - ".env.*"+ - "**/.env"+ - "**/.env.*"- "**/secrets/**"- "**/credentials/**"- "**/*_key*"diff --git a/tools/loop-audit/src/autofixer.ts b/tools/loop-audit/src/autofixer.tsindex 48f45e0..aba5662 100644--- a/tools/loop-audit/src/autofixer.ts+++ b/tools/loop-audit/src/autofixer.ts@@ -161,8 +161,8 @@ const GATE_YAML_TEMPLATE = `# Machine-readable twin of docs/safety.md, enforcedversion: 1denylist:- - ".env"- - ".env.*"+ - "**/.env"+ - "**/.env.*"- "**/secrets/**"- "**/credentials/**"- "**/*_key*"diff --git a/tools/loop-audit/test/autofixer.test.mjs b/tools/loop-audit/test/autofixer.test.mjsindex 862f7b9..3111e21 100644--- a/tools/loop-audit/test/autofixer.test.mjs+++ b/tools/loop-audit/test/autofixer.test.mjs@@ -46,6 +46,21 @@ test('autoFixProject writes a gate.yaml that loop-gate can actually load', asyncassert.match(written, /version:\s*1/);assert.match(written, /denylist:/);assert.doesNotMatch(written, /^gates:/m);++ // A bare pattern like ".env" only matches a path exactly equal to+ // ".env" under minimatch -- it silently misses "services/api/.env".+ // Every denylist entry here must be **/-anchored (or already contain+ // its own ** segment) so it also catches the nested case, which is+ // what "never auto-edit these" in docs/safety.md actually means.+ const denylistBlock = written.match(/denylist:\n((?:\s+-\s+.+\n)+)/)?.[1] ?? '';+ const entries = [...denylistBlock.matchAll(/-\s+"([^"]+)"/g)].map((m) => m[1]);+ assert.ok(entries.length > 0, 'expected at least one denylist entry to check');+ for (const entry of entries) {+ assert.ok(+ entry.startsWith('**/') || entry.includes('**'),+ `denylist entry "${entry}" is not anchored and would miss a nested match`,+ );+ }} finally {await rm(root, { recursive: true, force: true }).catch(() => {});}diff --git a/tools/loop-gate/test/gate.test.mjs b/tools/loop-gate/test/gate.test.mjsindex abb1103..4a66d8c 100644--- a/tools/loop-gate/test/gate.test.mjs+++ b/tools/loop-gate/test/gate.test.mjs@@ -3,9 +3,13 @@ import assert from 'node:assert/strict';import { mkdtemp, writeFile } from 'node:fs/promises';import { tmpdir } from 'node:os';import path from 'node:path';+import { fileURLToPath } from 'node:url';import { checkGate, loadGateConfig, assertValidAction } from '../dist/gate.js';+const __dirname = path.dirname(fileURLToPath(import.meta.url));+const REPO_GATE_YAML = path.resolve(__dirname, '../../../gate.yaml');+const baseConfig = {version: 1,denylist: ['.env', '**/secrets/**', 'auth/**'],@@ -143,3 +147,26 @@ test('loadGateConfig rejects the wrong version', async () => {const file = await freshGateFile('version: 2\ndenylist: []\n');await assert.rejects(() => loadGateConfig(file), /Invalid gate config/);});++// Dogfoods the actual policy this repo ships at gate.yaml, not just the+// matching mechanism -- a bare (unanchored) pattern like ".env" or "auth/**"+// only matches that exact root-level path and silently misses the same+// file/dir nested anywhere else, which a schema-validity check alone would+// never catch.+test("this repo's own gate.yaml denylist catches sensitive paths nested in a subdirectory, not just at repo root", async () => {+ const config = await loadGateConfig(REPO_GATE_YAML);+ const nestedSensitivePaths = [+ 'services/api/.env',+ 'services/api/.env.production',+ 'infra/.terraform/state.tfstate',+ 'apps/backend/k8s/production/deploy.yaml',+ 'apps/backend/auth/session.ts',+ 'apps/checkout/payments/charge.ts',+ 'apps/checkout/billing/invoice.ts',+ ];+ for (const p of nestedSensitivePaths) {+ const decision = checkGate({ config, action: 'commit', paths: [p] });+ assert.equal(decision.allowed, false, `${p} should be denylisted, got: ${decision.reason}`);+ assert.equal(decision.trigger, 'denylist');+ }+});diff --git a/tools/loop-sync/dist/sync.js b/tools/loop-sync/dist/sync.jsindex d9900da..304255f 100644--- a/tools/loop-sync/dist/sync.js+++ b/tools/loop-sync/dist/sync.js@@ -162,18 +162,18 @@ Run log: (timestamp) | findings | actions | escalationsversion: 1denylist:- - ".env"- - ".env.*"+ - "**/.env"+ - "**/.env.*"- "**/secrets/**"- "**/credentials/**"- "**/*_key*"- "**/*_secret*"- - ".terraform/**"- - "k8s/production/**"+ - "**/.terraform/**"+ - "**/k8s/production/**"- "**/migrations/**"- - "auth/**"- - "payments/**"- - "billing/**"+ - "**/auth/**"+ - "**/payments/**"+ - "**/billing/**"# Escalate instead of auto-merging when a change touches more than this many files.maxFiles: 10diff --git a/tools/loop-sync/src/sync.ts b/tools/loop-sync/src/sync.tsindex f0567f6..12238e5 100644--- a/tools/loop-sync/src/sync.ts+++ b/tools/loop-sync/src/sync.ts@@ -210,18 +210,18 @@ Run log: (timestamp) | findings | actions | escalationsversion: 1denylist:- - ".env"- - ".env.*"+ - "**/.env"+ - "**/.env.*"- "**/secrets/**"- "**/credentials/**"- "**/*_key*"- "**/*_secret*"- - ".terraform/**"- - "k8s/production/**"+ - "**/.terraform/**"+ - "**/k8s/production/**"- "**/migrations/**"- - "auth/**"- - "payments/**"- - "billing/**"+ - "**/auth/**"+ - "**/payments/**"+ - "**/billing/**"# Escalate instead of auto-merging when a change touches more than this many files.maxFiles: 10diff --git a/tools/loop-sync/test/sync.test.mjs b/tools/loop-sync/test/sync.test.mjsindex b649b5a..1e56cce 100644--- a/tools/loop-sync/test/sync.test.mjs+++ b/tools/loop-sync/test/sync.test.mjs@@ -102,6 +102,22 @@ describe('runSync auto-fix', () => {// loop-run-log.md must keep the marker append-run-log.mjs depends on.const runLog = await readFile(path.join(fixDir, 'loop-run-log.md'), 'utf8');assert.match(runLog, /<!-- Loop appends below this line -->/);++ // A bare pattern like ".env" only matches a path exactly equal to+ // ".env" under minimatch (tools/loop-gate's matcher) -- it silently+ // misses "services/api/.env". Every denylist entry must be+ // **/-anchored (or already contain its own ** segment) so the+ // scaffolded policy actually catches a nested match too.+ const gateYaml = await readFile(path.join(fixDir, 'gate.yaml'), 'utf8');+ const denylistBlock = gateYaml.match(/denylist:\n((?:\s+-\s+.+\n)+)/)?.[1] ?? '';+ const entries = [...denylistBlock.matchAll(/-\s+"([^"]+)"/g)].map((m) => m[1]);+ assert.ok(entries.length > 0, 'expected at least one denylist entry to check');+ for (const entry of entries) {+ assert.ok(+ entry.startsWith('**/') || entry.includes('**'),+ `denylist entry "${entry}" is not anchored and would miss a nested match`,+ );+ }});test('does not fabricate LOOP.md or AGENTS.md -- still reported as missing', async () => {