Skip to content

The swiss army knife of lossless video/audio editing

add play/pause hotkey

Mikael Finstad04346f7e856b
diff --git a/src/App.jsx b/src/App.jsx
index 40b88f44..82d4cf8b 100644
--- a/src/App.jsx
+++ b/src/App.jsx
@@ -989,22 +989,29 @@ const App = memo(() => {
const showPlaybackFailedMessage = () => errorToast(i18n.t('Unable to playback this file. Try to convert to supported format from the menu'));
- const togglePlay = useCallback((resetPlaybackRate) => {
- if (!filePath) return;
+ const pause = useCallback(() => {
+ if (!filePath || !playing) return;
+ videoRef.current.pause();
+ }, [filePath, playing]);
- const video = videoRef.current;
- if (playing) {
- video.pause();
- return;
- }
+ const play = useCallback((resetPlaybackRate) => {
+ if (!filePath || playing) return;
+ const video = videoRef.current;
if (resetPlaybackRate) video.playbackRate = 1;
-
video.play().catch((err) => {
showPlaybackFailedMessage();
console.error(err);
});
- }, [playing, filePath]);
+ }, [filePath, playing]);
+
+ const togglePlay = useCallback((resetPlaybackRate) => {
+ if (playing) {
+ pause();
+ return;
+ }
+ play(resetPlaybackRate);
+ }, [playing, play, pause]);
const closeFileWithConfirm = useCallback(() => {
if (!isFileOpened || workingRef.current) return;
@@ -1638,6 +1645,8 @@ const App = memo(() => {
const mainActions = {
togglePlayNoResetSpeed: () => togglePlay(),
togglePlayResetSpeed: () => togglePlay(true),
+ play: () => play(),
+ pause,
reducePlaybackRate: () => changePlaybackRate(-1),
reducePlaybackRateMore: () => changePlaybackRate(-1, 2.0),
increasePlaybackRate: () => changePlaybackRate(1),
@@ -1747,7 +1756,7 @@ const App = memo(() => {
if (match) return bubble;
return true; // bubble the event
- }, [addCutSegment, askSetStartTimeOffset, batchFileJump, captureSnapshot, changePlaybackRate, cleanupFilesDialog, clearSegments, closeBatch, closeExportConfirm, concatCurrentBatch, concatDialogVisible, convertFormatBatch, createFixedDurationSegments, createNumSegments, currentSegIndexSafe, cutSegmentsHistory, exportConfirmVisible, extractAllStreams, goToTimecode, increaseRotation, invertAllCutSegments, jumpCutEnd, jumpCutStart, jumpSeg, jumpTimelineEnd, jumpTimelineStart, keyboardNormalSeekSpeed, keyboardSeekAccFactor, keyboardShortcutsVisible, onExportConfirm, onExportPress, onLabelSegmentPress, removeCutSegment, reorderSegsByStartTime, seekClosestKeyframe, seekRel, seekRelPercent, setCutEnd, setCutStart, shortStep, shuffleSegments, splitCurrentSegment, timelineToggleComfortZoom, toggleCaptureFormat, toggleHelp, toggleKeyboardShortcuts, toggleKeyframeCut, togglePlay, toggleSegmentsList, toggleStreamsSelector, toggleStripAudio, userHtml5ifyCurrentFile, zoomRel]);
+ }, [addCutSegment, askSetStartTimeOffset, batchFileJump, captureSnapshot, changePlaybackRate, cleanupFilesDialog, clearSegments, closeBatch, closeExportConfirm, concatCurrentBatch, concatDialogVisible, convertFormatBatch, createFixedDurationSegments, createNumSegments, currentSegIndexSafe, cutSegmentsHistory, exportConfirmVisible, extractAllStreams, goToTimecode, increaseRotation, invertAllCutSegments, jumpCutEnd, jumpCutStart, jumpSeg, jumpTimelineEnd, jumpTimelineStart, keyboardNormalSeekSpeed, keyboardSeekAccFactor, keyboardShortcutsVisible, onExportConfirm, onExportPress, onLabelSegmentPress, pause, play, removeCutSegment, reorderSegsByStartTime, seekClosestKeyframe, seekRel, seekRelPercent, setCutEnd, setCutStart, shortStep, shuffleSegments, splitCurrentSegment, timelineToggleComfortZoom, toggleCaptureFormat, toggleHelp, toggleKeyboardShortcuts, toggleKeyframeCut, togglePlay, toggleSegmentsList, toggleStreamsSelector, toggleStripAudio, userHtml5ifyCurrentFile, zoomRel]);
useKeyboard({ keyBindings, onKeyPress });
diff --git a/src/components/KeyboardShortcuts.jsx b/src/components/KeyboardShortcuts.jsx
index 3fc707f4..88d3f0d9 100644
--- a/src/components/KeyboardShortcuts.jsx
+++ b/src/components/KeyboardShortcuts.jsx
@@ -149,6 +149,14 @@ const KeyboardShortcuts = memo(({
name: t('Play/pause (no reset speed)'),
category: playbackCategory,
},
+ play: {
+ name: t('Play'),
+ category: playbackCategory,
+ },
+ pause: {
+ name: t('Pause'),
+ category: playbackCategory,
+ },
increasePlaybackRate: {
name: t('Speed up playback'),
category: playbackCategory,