Skip to content

The swiss army knife of lossless video/audio editing

Document that only the bundled FFmpeg version is supported

Claude4fcad58afeda
diff --git a/AGENTS.md b/AGENTS.md
index e96eb48b..b11772a8 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -13,3 +13,7 @@ Changelog: `--settings-json` is now validated; invalid input is logged and ignor
```
When preparing a release, run `yarn release-notes` to collect these since the last tag, and use them to write `versions/<version>.md` (shown in the app's What's New dialog) and the GitHub release notes.
+
+## FFmpeg
+
+Only the bundled FFmpeg version (`script/downloadFfmpeg.ts`) is supported. Don't add or keep code for compatibility with older FFmpeg versions (e.g. old option names or log formats). When upgrading FFmpeg, remove such code.
diff --git a/script/downloadFfmpeg.ts b/script/downloadFfmpeg.ts
index 6428060b..ca79a000 100644
--- a/script/downloadFfmpeg.ts
+++ b/script/downloadFfmpeg.ts
@@ -8,7 +8,7 @@ import { Readable } from 'node:stream';
import { pipeline } from 'node:stream/promises';
import { execa } from 'execa';
-// Bump these when upgrading FFmpeg
+// Bump these when upgrading FFmpeg. This is also the minimum supported FFmpeg version (see `customFfPath` in src/main/ffmpeg.ts)
const macRelease = '8.1.3-1'; // https://github.com/mifi/ffmpeg-build-script/releases
const windowsLinuxRelease = '8.1-1'; // https://github.com/mifi/ffmpeg-builds/releases (mirrors BtbN's n<branch>-latest builds)
diff --git a/src/main/ffmpeg.ts b/src/main/ffmpeg.ts
index 65ef8db9..933e52da 100644
--- a/src/main/ffmpeg.ts
+++ b/src/main/ffmpeg.ts
@@ -27,6 +27,8 @@ const runningFfmpegs = new Set<{
}>();
// setInterval(() => console.log(runningFfmpegs.size), 1000);
+// Only the bundled FFmpeg version (see script/downloadFfmpeg.ts) is supported, also when using a custom FFmpeg path.
+// Don't add code for compatibility with older versions. Older versions are not blocked, but may not work correctly.
let customFfPath: string | undefined;
// Note that this does not work on MAS because of sandbox restrictions