Skip to content

The swiss army knife of lossless video/audio editing

don't use timer if have warnings

Mikael Finstad5ee1df97fae4
diff --git a/src/App.jsx b/src/App.jsx
index a489bbce..c14dbaec 100644
--- a/src/App.jsx
+++ b/src/App.jsx
@@ -73,7 +73,7 @@ import { formatDuration } from './util/duration';
import { adjustRate } from './util/rate-calculator';
import { askExtractFramesAsImages } from './dialogs/extractFrames';
import { askForHtml5ifySpeed } from './dialogs/html5ify';
-import { askForOutDir, askForImportChapters, promptTimeOffset, askForFileOpenAction, confirmExtractAllStreamsDialog, showCleanupFilesDialog, showDiskFull, showExportFailedDialog, showConcatFailedDialog, openYouTubeChaptersDialog, showRefuseToOverwrite, openDirToast, openCutFinishedToast, openConcatFinishedToast, showOpenDialog } from './dialogs';
+import { askForOutDir, askForImportChapters, promptTimeOffset, askForFileOpenAction, confirmExtractAllStreamsDialog, showCleanupFilesDialog, showDiskFull, showExportFailedDialog, showConcatFailedDialog, openYouTubeChaptersDialog, showRefuseToOverwrite, openDirToast, openExportFinishedToast, openConcatFinishedToast, showOpenDialog } from './dialogs';
import { openSendReportDialog } from './reporting';
import { fallbackLng } from './i18n';
import { createSegment, getCleanCutSegments, findSegmentsAtCursor, sortSegments, convertSegmentsToChapters, hasAnySegmentOverlap, isDurationValid, playOnlyCurrentSegment } from './segments';
@@ -1174,7 +1174,7 @@ const App = memo(() => {
if (areWeCutting) notices.push(i18n.t('Cutpoints may be inaccurate.'));
const revealPath = concatOutPath || outFiles[0];
- if (!hideAllNotifications) openCutFinishedToast({ filePath: revealPath, warnings, notices });
+ if (!hideAllNotifications) openExportFinishedToast({ filePath: revealPath, warnings, notices });
if (cleanupChoices.cleanupAfterExport) await cleanupFiles(cleanupChoices);
} catch (err) {
diff --git a/src/dialogs/index.jsx b/src/dialogs/index.jsx
index bb1d5aaa..33d1e09e 100644
--- a/src/dialogs/index.jsx
+++ b/src/dialogs/index.jsx
@@ -545,7 +545,7 @@ const Notices = ({ notices }) => notices.map((msg) => <ListItem key={msg} icon={
const Warnings = ({ warnings }) => warnings.map((msg) => <ListItem key={msg} icon={WarningSignIcon} iconColor="warning">{msg}</ListItem>);
const OutputIncorrectSeeHelpMenu = () => <ListItem icon={HelpIcon}>{i18n.t('If output does not look right, see the Help menu.')}</ListItem>;
-export async function openCutFinishedToast({ filePath, warnings, notices }) {
+export async function openExportFinishedToast({ filePath, warnings, notices }) {
const hasWarnings = warnings.length > 0;
const html = (
<UnorderedList>
@@ -557,7 +557,7 @@ export async function openCutFinishedToast({ filePath, warnings, notices }) {
</UnorderedList>
);
- await openDirToast({ filePath, html, width: 800, position: 'center', timer: 30000 });
+ await openDirToast({ filePath, html, width: 800, position: 'center', timer: hasWarnings ? undefined : 30000 });
}
export async function openConcatFinishedToast({ filePath, warnings, notices }) {