The swiss army knife of lossless video/audio editing
Store release: review fixes
Claude93aff53e541e
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.mdindex 1a4462ce..4e12822e 100644--- a/CONTRIBUTING.md+++ b/CONTRIBUTING.md@@ -134,7 +134,7 @@ This is automated with [`script/storeRelease.ts`](./script/storeRelease.ts), runWhat the script does:-- **Mac App Store**: App Store versions have their own numbering (1.x, e.g. 1.14), separate from the GitHub/build version (`package.json`, e.g. 3.70.1), which is the build attached to it. The script takes the build version, and creates the next App Store version (1.14 → 1.15) or reuses the editable one. It waits for the build to finish processing and attaches it, sets en-US "What's New", manual release, 7-day phased release, and submits for review.+- **Mac App Store**: App Store versions have their own numbering (1.x, e.g. 1.14), separate from the GitHub/build version (`package.json`, e.g. 3.70.1), which is the build attached to it. The script takes the build version, and creates the next App Store version (1.14 → 1.15) or reuses the editable one. It waits for the build to finish processing and attaches it, sets en-US "What's New", the privacy policy URL (from `src/common/websiteUrls.ts`), manual release, 7-day phased release, and submits for review.- **Microsoft Store**: creates a submission, replaces the packages with both `.appx` files from the GitHub release (renamed without `-DONT-USE-THIS-FILE`), sets en-US "What's new", gradual rollout at 0%, "Don't publish until I select Publish now", and submits for certification. Don't edit a submission in Partner Center that the script created, or the API can no longer change it.- If the version is already submitted or released, it says so and does nothing.- It stops before changing anything when a store isn't ready for a new version: Mac App Store while another version is in review or waiting to be released, Microsoft Store while another submission is pending or the previous gradual rollout hasn't finished (finalize it with `msstore-rollout 100`, or halt it).diff --git a/script/storeRelease.ts b/script/storeRelease.tsindex 7c8a7d9c..5962bd70 100644--- a/script/storeRelease.ts+++ b/script/storeRelease.ts@@ -117,15 +117,15 @@ async function findMasBuild(version: string) {return builds?.[0];}-// The privacy policy URL is in the app info (per app, not per version), which can only be changed while a version is being prepared+// The privacy policy URL is in the app info (per app, not per version), which can only be changed while a version is being prepared (or was rejected)async function masPrivacyPolicy() {- const appInfos = (await asc<AscResource[]>('GET', `/v1/apps/${masAppId}/appInfos`))!;+ const appInfos = (await asc<AscResource[]>('GET', `/v1/apps/${masAppId}/appInfos?limit=200`))!;const editable = appInfos.find((i) => ['PREPARE_FOR_SUBMISSION', 'READY_FOR_REVIEW', 'DEVELOPER_REJECTED', 'REJECTED'].includes(String(i.attributes['state'])));if (!editable) {- log(`No editable app info (states: ${appInfos.map((i) => i.attributes['state']).join(', ')}), so the privacy policy URL can't be checked`);+ log(`Warning: no editable app info (states: ${appInfos.map((i) => i.attributes['state']).join(', ')}), so the privacy policy URL can't be checked. Check it in App Store Connect → App Information (should be ${privacyPolicyUrl})`);return;}- const localizations = (await asc<AscResource[]>('GET', `/v1/appInfos/${editable.id}/appInfoLocalizations`))!;+ const localizations = (await asc<AscResource[]>('GET', `/v1/appInfos/${editable.id}/appInfoLocalizations?limit=200`))!;for (const localization of localizations) {const { locale, privacyPolicyUrl: current } = localization.attributes;if (current === privacyPolicyUrl) {