Skip to content

The swiss army knife of lossless video/audio editing

fix performance regression

Mikael Finstadc513c7e144f5
diff --git a/src/hooks/useUserSettingsRoot.js b/src/hooks/useUserSettingsRoot.js
index 235d58f8..01d5a856 100644
--- a/src/hooks/useUserSettingsRoot.js
+++ b/src/hooks/useUserSettingsRoot.js
@@ -32,81 +32,86 @@ export default () => {
return JSON.parse(JSON.stringify(rawVal));
}
- const [captureFormat, setCaptureFormat] = useState(safeGetConfig('captureFormat'));
+ // From https://reactjs.org/docs/hooks-reference.html#lazy-initial-state
+ // If the initial state is the result of an expensive computation, you may provide a function instead, which will be executed only on the initial render
+ // Without this there was a huge performance issue https://github.com/mifi/lossless-cut/issues/1097
+ const safeGetConfigInitial = (...args) => () => safeGetConfig(...args);
+
+ const [captureFormat, setCaptureFormat] = useState(safeGetConfigInitial('captureFormat'));
useEffect(() => safeSetConfig('captureFormat', captureFormat), [captureFormat]);
- const [customOutDir, setCustomOutDir] = useState(safeGetConfig('customOutDir'));
+ const [customOutDir, setCustomOutDir] = useState(safeGetConfigInitial('customOutDir'));
useEffect(() => safeSetConfig('customOutDir', customOutDir), [customOutDir]);
- const [keyframeCut, setKeyframeCut] = useState(safeGetConfig('keyframeCut'));
+ const [keyframeCut, setKeyframeCut] = useState(safeGetConfigInitial('keyframeCut'));
useEffect(() => safeSetConfig('keyframeCut', keyframeCut), [keyframeCut]);
- const [preserveMovData, setPreserveMovData] = useState(safeGetConfig('preserveMovData'));
+ const [preserveMovData, setPreserveMovData] = useState(safeGetConfigInitial('preserveMovData'));
useEffect(() => safeSetConfig('preserveMovData', preserveMovData), [preserveMovData]);
- const [movFastStart, setMovFastStart] = useState(safeGetConfig('movFastStart'));
+ const [movFastStart, setMovFastStart] = useState(safeGetConfigInitial('movFastStart'));
useEffect(() => safeSetConfig('movFastStart', movFastStart), [movFastStart]);
- const [avoidNegativeTs, setAvoidNegativeTs] = useState(safeGetConfig('avoidNegativeTs'));
+ const [avoidNegativeTs, setAvoidNegativeTs] = useState(safeGetConfigInitial('avoidNegativeTs'));
useEffect(() => safeSetConfig('avoidNegativeTs', avoidNegativeTs), [avoidNegativeTs]);
- const [autoMerge, setAutoMerge] = useState(safeGetConfig('autoMerge'));
+ const [autoMerge, setAutoMerge] = useState(safeGetConfigInitial('autoMerge'));
useEffect(() => safeSetConfig('autoMerge', autoMerge), [autoMerge]);
- const [timecodeFormat, setTimecodeFormat] = useState(safeGetConfig('timecodeFormat'));
+ const [timecodeFormat, setTimecodeFormat] = useState(safeGetConfigInitial('timecodeFormat'));
useEffect(() => safeSetConfig('timecodeFormat', timecodeFormat), [timecodeFormat]);
- const [invertCutSegments, setInvertCutSegments] = useState(safeGetConfig('invertCutSegments'));
+ const [invertCutSegments, setInvertCutSegments] = useState(safeGetConfigInitial('invertCutSegments'));
useEffect(() => safeSetConfig('invertCutSegments', invertCutSegments), [invertCutSegments]);
- const [autoExportExtraStreams, setAutoExportExtraStreams] = useState(safeGetConfig('autoExportExtraStreams'));
+ const [autoExportExtraStreams, setAutoExportExtraStreams] = useState(safeGetConfigInitial('autoExportExtraStreams'));
useEffect(() => safeSetConfig('autoExportExtraStreams', autoExportExtraStreams), [autoExportExtraStreams]);
- const [askBeforeClose, setAskBeforeClose] = useState(safeGetConfig('askBeforeClose'));
+ const [askBeforeClose, setAskBeforeClose] = useState(safeGetConfigInitial('askBeforeClose'));
useEffect(() => safeSetConfig('askBeforeClose', askBeforeClose), [askBeforeClose]);
- const [enableAskForImportChapters, setEnableAskForImportChapters] = useState(safeGetConfig('enableAskForImportChapters'));
+ const [enableAskForImportChapters, setEnableAskForImportChapters] = useState(safeGetConfigInitial('enableAskForImportChapters'));
useEffect(() => safeSetConfig('enableAskForImportChapters', enableAskForImportChapters), [enableAskForImportChapters]);
- const [enableAskForFileOpenAction, setEnableAskForFileOpenAction] = useState(safeGetConfig('enableAskForFileOpenAction'));
+ const [enableAskForFileOpenAction, setEnableAskForFileOpenAction] = useState(safeGetConfigInitial('enableAskForFileOpenAction'));
useEffect(() => safeSetConfig('enableAskForFileOpenAction', enableAskForFileOpenAction), [enableAskForFileOpenAction]);
- const [playbackVolume, setPlaybackVolume] = useState(safeGetConfig('playbackVolume'));
+ const [playbackVolume, setPlaybackVolume] = useState(safeGetConfigInitial('playbackVolume'));
useEffect(() => safeSetConfig('playbackVolume', playbackVolume), [playbackVolume]);
- const [autoSaveProjectFile, setAutoSaveProjectFile] = useState(safeGetConfig('autoSaveProjectFile'));
+ const [autoSaveProjectFile, setAutoSaveProjectFile] = useState(safeGetConfigInitial('autoSaveProjectFile'));
useEffect(() => safeSetConfig('autoSaveProjectFile', autoSaveProjectFile), [autoSaveProjectFile]);
- const [wheelSensitivity, setWheelSensitivity] = useState(safeGetConfig('wheelSensitivity'));
+ const [wheelSensitivity, setWheelSensitivity] = useState(safeGetConfigInitial('wheelSensitivity'));
useEffect(() => safeSetConfig('wheelSensitivity', wheelSensitivity), [wheelSensitivity]);
- const [invertTimelineScroll, setInvertTimelineScroll] = useState(safeGetConfig('invertTimelineScroll'));
+ const [invertTimelineScroll, setInvertTimelineScroll] = useState(safeGetConfigInitial('invertTimelineScroll'));
useEffect(() => safeSetConfig('invertTimelineScroll', invertTimelineScroll), [invertTimelineScroll]);
- const [language, setLanguage] = useState(safeGetConfig('language'));
+ const [language, setLanguage] = useState(safeGetConfigInitial('language'));
useEffect(() => safeSetConfig('language', language), [language]);
- const [ffmpegExperimental, setFfmpegExperimental] = useState(safeGetConfig('ffmpegExperimental'));
+ const [ffmpegExperimental, setFfmpegExperimental] = useState(safeGetConfigInitial('ffmpegExperimental'));
useEffect(() => safeSetConfig('ffmpegExperimental', ffmpegExperimental), [ffmpegExperimental]);
- const [hideNotifications, setHideNotifications] = useState(safeGetConfig('hideNotifications'));
+ const [hideNotifications, setHideNotifications] = useState(safeGetConfigInitial('hideNotifications'));
useEffect(() => safeSetConfig('hideNotifications', hideNotifications), [hideNotifications]);
- const [autoLoadTimecode, setAutoLoadTimecode] = useState(safeGetConfig('autoLoadTimecode'));
+ const [autoLoadTimecode, setAutoLoadTimecode] = useState(safeGetConfigInitial('autoLoadTimecode'));
useEffect(() => safeSetConfig('autoLoadTimecode', autoLoadTimecode), [autoLoadTimecode]);
- const [autoDeleteMergedSegments, setAutoDeleteMergedSegments] = useState(safeGetConfig('autoDeleteMergedSegments'));
+ const [autoDeleteMergedSegments, setAutoDeleteMergedSegments] = useState(safeGetConfigInitial('autoDeleteMergedSegments'));
useEffect(() => safeSetConfig('autoDeleteMergedSegments', autoDeleteMergedSegments), [autoDeleteMergedSegments]);
- const [exportConfirmEnabled, setExportConfirmEnabled] = useState(safeGetConfig('exportConfirmEnabled'));
+ const [exportConfirmEnabled, setExportConfirmEnabled] = useState(safeGetConfigInitial('exportConfirmEnabled'));
useEffect(() => safeSetConfig('exportConfirmEnabled', exportConfirmEnabled), [exportConfirmEnabled]);
- const [segmentsToChapters, setSegmentsToChapters] = useState(safeGetConfig('segmentsToChapters'));
+ const [segmentsToChapters, setSegmentsToChapters] = useState(safeGetConfigInitial('segmentsToChapters'));
useEffect(() => safeSetConfig('segmentsToChapters', segmentsToChapters), [segmentsToChapters]);
- const [preserveMetadataOnMerge, setPreserveMetadataOnMerge] = useState(safeGetConfig('preserveMetadataOnMerge'));
+ const [preserveMetadataOnMerge, setPreserveMetadataOnMerge] = useState(safeGetConfigInitial('preserveMetadataOnMerge'));
useEffect(() => safeSetConfig('preserveMetadataOnMerge', preserveMetadataOnMerge), [preserveMetadataOnMerge]);
- const [simpleMode, setSimpleMode] = useState(safeGetConfig('simpleMode'));
+ const [simpleMode, setSimpleMode] = useState(safeGetConfigInitial('simpleMode'));
useEffect(() => safeSetConfig('simpleMode', simpleMode), [simpleMode]);
- const [outSegTemplate, setOutSegTemplate] = useState(safeGetConfig('outSegTemplate'));
+ const [outSegTemplate, setOutSegTemplate] = useState(safeGetConfigInitial('outSegTemplate'));
useEffect(() => safeSetConfig('outSegTemplate', outSegTemplate), [outSegTemplate]);
- const [keyboardSeekAccFactor, setKeyboardSeekAccFactor] = useState(safeGetConfig('keyboardSeekAccFactor'));
+ const [keyboardSeekAccFactor, setKeyboardSeekAccFactor] = useState(safeGetConfigInitial('keyboardSeekAccFactor'));
useEffect(() => safeSetConfig('keyboardSeekAccFactor', keyboardSeekAccFactor), [keyboardSeekAccFactor]);
- const [keyboardNormalSeekSpeed, setKeyboardNormalSeekSpeed] = useState(safeGetConfig('keyboardNormalSeekSpeed'));
+ const [keyboardNormalSeekSpeed, setKeyboardNormalSeekSpeed] = useState(safeGetConfigInitial('keyboardNormalSeekSpeed'));
useEffect(() => safeSetConfig('keyboardNormalSeekSpeed', keyboardNormalSeekSpeed), [keyboardNormalSeekSpeed]);
- const [enableTransferTimestamps, setEnableTransferTimestamps] = useState(safeGetConfig('enableTransferTimestamps'));
+ const [enableTransferTimestamps, setEnableTransferTimestamps] = useState(safeGetConfigInitial('enableTransferTimestamps'));
useEffect(() => safeSetConfig('enableTransferTimestamps', enableTransferTimestamps), [enableTransferTimestamps]);
- const [outFormatLocked, setOutFormatLocked] = useState(safeGetConfig('outFormatLocked'));
+ const [outFormatLocked, setOutFormatLocked] = useState(safeGetConfigInitial('outFormatLocked'));
useEffect(() => safeSetConfig('outFormatLocked', outFormatLocked), [outFormatLocked]);
- const [safeOutputFileName, setSafeOutputFileName] = useState(safeGetConfig('safeOutputFileName'));
+ const [safeOutputFileName, setSafeOutputFileName] = useState(safeGetConfigInitial('safeOutputFileName'));
useEffect(() => safeSetConfig('safeOutputFileName', safeOutputFileName), [safeOutputFileName]);
- const [enableAutoHtml5ify, setEnableAutoHtml5ify] = useState(safeGetConfig('enableAutoHtml5ify'));
+ const [enableAutoHtml5ify, setEnableAutoHtml5ify] = useState(safeGetConfigInitial('enableAutoHtml5ify'));
useEffect(() => safeSetConfig('enableAutoHtml5ify', enableAutoHtml5ify), [enableAutoHtml5ify]);
- const [segmentsToChaptersOnly, setSegmentsToChaptersOnly] = useState(safeGetConfig('segmentsToChaptersOnly'));
+ const [segmentsToChaptersOnly, setSegmentsToChaptersOnly] = useState(safeGetConfigInitial('segmentsToChaptersOnly'));
useEffect(() => safeSetConfig('segmentsToChaptersOnly', segmentsToChaptersOnly), [segmentsToChaptersOnly]);
- const [keyBindings, setKeyBindings] = useState(safeGetConfig('keyBindings'));
+ const [keyBindings, setKeyBindings] = useState(safeGetConfigInitial('keyBindings'));
useEffect(() => safeSetConfig('keyBindings', keyBindings), [keyBindings]);
- const [enableSmartCut, setEnableSmartCut] = useState(safeGetConfig('enableSmartCut'));
+ const [enableSmartCut, setEnableSmartCut] = useState(safeGetConfigInitial('enableSmartCut'));
useEffect(() => safeSetConfig('enableSmartCut', enableSmartCut), [enableSmartCut]);
- const [customFfPath, setCustomFfPath] = useState(safeGetConfig('customFfPath'));
+ const [customFfPath, setCustomFfPath] = useState(safeGetConfigInitial('customFfPath'));
useEffect(() => safeSetConfig('customFfPath', customFfPath), [customFfPath]);
- const [storeProjectInWorkingDir, setStoreProjectInWorkingDir] = useState(safeGetConfig('storeProjectInWorkingDir'));
+ const [storeProjectInWorkingDir, setStoreProjectInWorkingDir] = useState(safeGetConfigInitial('storeProjectInWorkingDir'));
useEffect(() => safeSetConfig('storeProjectInWorkingDir', storeProjectInWorkingDir), [storeProjectInWorkingDir]);
const resetKeyBindings = useCallback(() => {