Skip to content

The swiss army knife of lossless video/audio editing

Apply batched suggestions from code review

Mikael Finstadddaa31906fd1
diff --git a/.gitattributes b/.gitattributes
index 0eacb6d0..92ee1d3f 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -1,15 +1,5 @@
-# Force LF line endings for the source file types `yarn lint` actually checks
-# (see the `lint` script in package.json), regardless of platform or the local
-# core.autocrlf setting. CI (.github/workflows/test.yml) already checks out with
-# core.autocrlf=false (LF); without this, a Windows checkout with the common
-# core.autocrlf=true default gets CRLF working-tree files for these extensions,
-# which then fails ESLint's linebreak-style rule locally even though CI is green.
-#
-# Deliberately scoped to just these extensions: src/renderer/src/test/fixtures/
-# holds real-world sample files (e.g. from DaVinci Resolve, Final Cut Pro,
-# PotPlayer) in other formats (.edl, .csv, .vtt, .xml, .otio, ...) whose exact
-# bytes - including line endings - the parsers under test may depend on, so
-# they're intentionally left with no attribute and are unaffected by this file.
+# Keep files checked by `yarn lint` LF on every platform, regardless of core.autocrlf
+# (ESLint linebreak-style: unix). Keep in sync with the --ext list of the `lint` script.
*.js text eol=lf
*.jsx text eol=lf
*.ts text eol=lf
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 5836ec1b..add5fa88 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -45,28 +45,6 @@ yarn check
Most of these checks are automatically run in GitHub Actions.
-### Line endings
-
-Source files matched by `.gitattributes` (`.js`, `.jsx`, `.ts`, `.tsx`, `.mjs`, `.mts`) are
-checked out with LF line endings regardless of your platform or local `core.autocrlf` setting.
-This keeps `yarn lint`'s `linebreak-style` rule consistent with CI, which always checks out with
-LF. Windows users with the common `core.autocrlf=true` git default previously got CRLF working-tree
-files for these extensions, causing `yarn lint` to report thousands of `linebreak-style` errors
-locally that never showed up in CI.
-
-If your working copy predates `.gitattributes` and still has CRLF files, a fresh `git clone` will
-pick up LF automatically. To fix specific already-checked-out files in place instead, force a
-real re-checkout (a plain `git checkout -- <path>` is skipped if git thinks the file is already
-up to date):
-
-```bash
-rm <path> && git checkout -- <path>
-```
-
-Test fixtures under `src/renderer/src/test/fixtures/` (`.edl`, `.csv`, `.vtt`, `.xml`, `.otio`,
-etc.) are intentionally excluded, since they hold real-world sample files from other tools whose
-exact bytes - including line endings - the parsers under test may depend on.
-
### Other scripts
See [package.json](./package.json) "scripts" section.