Apache Lucene open-source search software
LUCENE-10413: Make default Ukrainian stopword set available (#665)
Alan Woodward2183756f1c82
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txtindex 6f380a4965b..73909964b22 100644--- a/lucene/CHANGES.txt+++ b/lucene/CHANGES.txt@@ -267,6 +267,8 @@ Otherand discover classes to check from module system. The test now checks all analyzer modules,so it may discover new bugs outside of analysis:common module. (Uwe Schindler, Robert Muir)+* LUCENE-10413: Make Ukrainian default stop words list available as a public getter. (Alan Woodward)+======================= Lucene 9.0.0 =======================New Featuresdiff --git a/lucene/analysis/morfologik/src/java/org/apache/lucene/analysis/uk/UkrainianMorfologikAnalyzer.java b/lucene/analysis/morfologik/src/java/org/apache/lucene/analysis/uk/UkrainianMorfologikAnalyzer.javaindex eb29448ca7d..558239a95d9 100644--- a/lucene/analysis/morfologik/src/java/org/apache/lucene/analysis/uk/UkrainianMorfologikAnalyzer.java+++ b/lucene/analysis/morfologik/src/java/org/apache/lucene/analysis/uk/UkrainianMorfologikAnalyzer.java@@ -113,14 +113,11 @@ public final class UkrainianMorfologikAnalyzer extends StopwordAnalyzerBase {return defaultResources;}- private static class DefaultResources {- final CharArraySet stopSet;- final Dictionary dictionary;+ private record DefaultResources(CharArraySet stopSet, Dictionary dictionary) {}- private DefaultResources(CharArraySet stopSet, Dictionary dictionary) {- this.stopSet = stopSet;- this.dictionary = dictionary;- }+ /** Returns the default stopword set for this analyzer */+ public static CharArraySet getDefaultStopwords() {+ return CharArraySet.unmodifiableSet(getDefaultResources().stopSet);}/** Builds an analyzer with the default stop words. */diff --git a/lucene/analysis/morfologik/src/test/org/apache/lucene/analysis/uk/TestUkrainianAnalyzer.java b/lucene/analysis/morfologik/src/test/org/apache/lucene/analysis/uk/TestUkrainianAnalyzer.javaindex e04f62639db..f984ff8c18c 100644--- a/lucene/analysis/morfologik/src/test/org/apache/lucene/analysis/uk/TestUkrainianAnalyzer.java+++ b/lucene/analysis/morfologik/src/test/org/apache/lucene/analysis/uk/TestUkrainianAnalyzer.java@@ -18,6 +18,7 @@ package org.apache.lucene.analysis.uk;import java.io.IOException;import org.apache.lucene.analysis.Analyzer;+import org.apache.lucene.analysis.CharArraySet;import org.apache.lucene.tests.analysis.BaseTokenStreamTestCase;/** Test case for UkrainianAnalyzer. */@@ -99,4 +100,11 @@ public class TestUkrainianAnalyzer extends BaseTokenStreamTestCase {checkRandomData(random(), analyzer, 200 * RANDOM_MULTIPLIER);analyzer.close();}++ public void testDefaultStopWords() {+ CharArraySet stopwords = UkrainianMorfologikAnalyzer.getDefaultStopwords();+ assertTrue(stopwords.contains("аби"));+ stopwords.remove("аби");+ assertTrue(UkrainianMorfologikAnalyzer.getDefaultStopwords().contains("аби"));+ }}