Apache Lucene open-source search software
error-prone: implement BanClassLoader with forbidden-apis instead (#14811)
Robert Muir2c5eb864850f
diff --git a/build-tools/build-infra/src/main/groovy/lucene.validation.error-prone.gradle b/build-tools/build-infra/src/main/groovy/lucene.validation.error-prone.gradleindex fd53032805c..c1ac36e4898 100644--- a/build-tools/build-infra/src/main/groovy/lucene.validation.error-prone.gradle+++ b/build-tools/build-infra/src/main/groovy/lucene.validation.error-prone.gradle@@ -153,7 +153,7 @@ allprojects { prj ->// '-Xep:AutoValueConstructorOrderChecker:OFF', // we don't use autovalue'-Xep:BadAnnotationImplementation:ERROR','-Xep:BadShiftAmount:ERROR',- '-Xep:BanClassLoader:ERROR',+ // '-Xep:BanClassLoader:OFF', // implemented with forbidden APIs instead// '-Xep:BanJNDI:OFF', // implemented with forbidden APIs instead// '-Xep:BoxedPrimitiveEquality:OFF', // TODO: there are problems// '-Xep:BundleDeserializationCast:OFF', // we don't use androiddiff --git a/gradle/validation/forbidden-apis/defaults.all.txt b/gradle/validation/forbidden-apis/defaults.all.txtindex 0d59f24d6c2..2dc3fe3769b 100644--- a/gradle/validation/forbidden-apis/defaults.all.txt+++ b/gradle/validation/forbidden-apis/defaults.all.txt@@ -76,3 +76,11 @@ java.lang.Math#fma(float,float,float)java.lang.Math#fma(double,double,double)java.lang.Thread#sleep(**) @ Thread.sleep makes inefficient use of resources, introduces weird race conditions and slows down the code/tests. Not a scalable and good practice so we should prevent it creeping into lucene code++# rules to prevent defining new code from bytes+@defaultMessage Using dangerous ClassLoader APIs may deserialize untrusted user input into bytecode, leading to remote code execution vulnerabilities+java.lang.ClassLoader#defineClass(**)+java.lang.invoke.MethodHandles$Lookup#defineClass(**)+java.lang.invoke.MethodHandles$Lookup#defineHiddenClass(**)+java.lang.invoke.MethodHandles$Lookup#defineHiddenClassWithClassData(**)+java.rmi.server.RMIClassLoaderdiff --git a/lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java b/lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.javaindex a4d5c4111e5..2c0c2f98068 100644--- a/lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java+++ b/lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java@@ -66,6 +66,7 @@ import org.apache.lucene.expressions.Expression;import org.apache.lucene.expressions.js.JavascriptParser.ExpressionContext;import org.apache.lucene.search.DoubleValues;import org.apache.lucene.util.IOUtils;+import org.apache.lucene.util.SuppressForbidden;/*** An expression compiler for javascript expressions.@@ -199,6 +200,7 @@ public final class JavascriptCompiler {* @return A new compiled expression* @throws ParseException on failure to compile*/+ @SuppressForbidden(reason = "defines new bytecode on purpose, carefully")private Expression compileExpression() throws ParseException {final Map<String, Integer> externalsMap = new LinkedHashMap<>(),constantsMap = new LinkedHashMap<>();diff --git a/lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java b/lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.javaindex 419be8e5a63..ea409135034 100644--- a/lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java+++ b/lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java@@ -52,7 +52,6 @@ public final class AnalysisImpl implements Analysis {private Analyzer analyzer = defaultAnalyzer();- @SuppressWarnings("BanClassLoader")@Overridepublic void addExternalJars(List<String> jarFiles) {List<URL> urls = new ArrayList<>();