Skip to content

Apache Lucene open-source search software

LUCENE-10273: Deprecate SpanishMinimalStemmer in favor of SpanishPluralStemmer (#497)

Robert Muir387e67ec8729
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 2f76a2df68c..fb2969db4d1 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -86,7 +86,8 @@ Bug Fixes
Other
---------------------
-(No changes)
+
+* LUCENE-10273: Deprecate SpanishMinimalStemFilter in favor of SpanishPluralStemFilter. (Robert Muir)
======================= Lucene 9.0.0 =======================
diff --git a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilter.java b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilter.java
index 4033ff178b6..edf68ccc0cc 100644
--- a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilter.java
+++ b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilter.java
@@ -30,7 +30,10 @@ import org.apache.lucene.analysis.tokenattributes.KeywordAttribute;
* <p>To prevent terms from being stemmed use an instance of {@link SetKeywordMarkerFilter} or a
* custom {@link TokenFilter} that sets the {@link KeywordAttribute} before this {@link
* TokenStream}.
+ *
+ * @deprecated Use {@link SpanishPluralStemFilter} instead.
*/
+@Deprecated
public final class SpanishMinimalStemFilter extends TokenFilter {
private final SpanishMinimalStemmer stemmer = new SpanishMinimalStemmer();
private final CharTermAttribute termAtt = addAttribute(CharTermAttribute.class);
diff --git a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilterFactory.java b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilterFactory.java
index f748f5fc27e..9526704a2da 100644
--- a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilterFactory.java
+++ b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemFilterFactory.java
@@ -34,7 +34,9 @@ import org.apache.lucene.analysis.TokenStream;
* &lt;/fieldType&gt;</pre>
*
* @lucene.spi {@value #NAME}
+ * @deprecated Use {@link SpanishPluralStemFilterFactory} instead
*/
+@Deprecated
public class SpanishMinimalStemFilterFactory extends TokenFilterFactory {
/** SPI name */
diff --git a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemmer.java b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemmer.java
index 44cbfcb578f..fd1957cb803 100644
--- a/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemmer.java
+++ b/lucene/analysis/common/src/java/org/apache/lucene/analysis/es/SpanishMinimalStemmer.java
@@ -21,7 +21,10 @@ package org.apache.lucene.analysis.es;
* Minimal plural stemmer for Spanish.
*
* <p>This stemmer implements the "plurals" stemmer for spanish lanugage.
+ *
+ * @deprecated Use {@link SpanishPluralStemmer} instead.
*/
+@Deprecated
public class SpanishMinimalStemmer {
public int stem(char[] s, int len) {
diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilter.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilter.java
index 7c7047d4f3b..7cd511ebb78 100644
--- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilter.java
+++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilter.java
@@ -25,7 +25,12 @@ import org.apache.lucene.analysis.Tokenizer;
import org.apache.lucene.analysis.core.KeywordTokenizer;
import org.apache.lucene.analysis.en.EnglishMinimalStemFilter;
-/** Simple tests for {@link SpanishMinimalStemFilter} */
+/**
+ * Simple tests for {@link SpanishMinimalStemFilter}
+ *
+ * @deprecated Remove with SpanishMinimalStemFilter
+ */
+@Deprecated
public class TestSpanishMinimalStemFilter extends BaseTokenStreamTestCase {
private Analyzer analyzer;
diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilterFactory.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilterFactory.java
index 5c17cffcd53..d71615e6fa3 100644
--- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilterFactory.java
+++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/es/TestSpanishMinimalStemFilterFactory.java
@@ -24,7 +24,12 @@ import org.apache.lucene.analysis.MockTokenizer;
import org.apache.lucene.analysis.TokenStream;
import org.apache.lucene.analysis.Tokenizer;
-/** Simple tests to ensure the spanish minimal stem factory is working. */
+/**
+ * Simple tests to ensure the spanish minimal stem factory is working.
+ *
+ * @deprecated Remove with SpanishMinimalStemFilterFactory
+ */
+@Deprecated
public class TestSpanishMinimalStemFilterFactory extends BaseTokenStreamFactoryTestCase {
public void testStemming() throws Exception {
Reader reader = new StringReader("camisetas");