Skip to content

Apache Lucene open-source search software

Remove deprecated IndexSearcher#getExecutor method (#12580)

Luca Cavanna3deead0ed324
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 288536f297d..61f44825060 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -57,6 +57,9 @@ API Changes
* GITHUB#12407: Removed Scorable#docID. (Adrien Grand)
+* GITHUB#12580: Remove deprecated IndexSearcher#getExecutor in favour of executing concurrent tasks using
+ the TaskExecutor that the searcher holds, retrieved via IndexSearcher#getTaskExecutor (Luca Cavanna)
+
New Features
---------------------
@@ -131,6 +134,8 @@ Other
API Changes
---------------------
+* GITHUB#12578: Deprecate IndexSearcher#getExecutor in favour of executing concurrent tasks using
+ the TaskExecutor that the searcher holds, retrieved via IndexSearcher#getTaskExecutor (Luca Cavanna)
New Features
---------------------
diff --git a/lucene/MIGRATE.md b/lucene/MIGRATE.md
index 09688b87dc5..158ce93c9a7 100644
--- a/lucene/MIGRATE.md
+++ b/lucene/MIGRATE.md
@@ -95,6 +95,11 @@ Callers should remove the parameter when calling this method.
The former `DaciukMihovAutomatonBuilder#build` functionality is exposed through `Automata#makeStringUnion`.
Users should be able to directly migrate to the `Automata` static method as a 1:1 replacement.
+### Remove deprecated IndexSearcher#getExecutor (GITHUB#12580)
+
+The deprecated getter for the `Executor` that was optionally provided to the `IndexSearcher` constructors
+has been removed. Users that want to execute concurrent tasks should rely instead on the `TaskExecutor`
+that the searcher holds, retrieved via `IndexSearcher#getTaskExecutor`.
## Migration from Lucene 9.0 to Lucene 9.1
diff --git a/lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java b/lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java
index 6e66d5c2af1..e3b68879c70 100644
--- a/lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java
+++ b/lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java
@@ -946,11 +946,6 @@ public class IndexSearcher {
return new CollectionStatistics(field, reader.maxDoc(), docCount, sumTotalTermFreq, sumDocFreq);
}
- /** Returns this searchers executor or <code>null</code> if no executor was provided */
- public Executor getExecutor() {
- return executor;
- }
-
/**
* Returns the {@link TaskExecutor} that this searcher relies on to execute concurrent operations
*