Skip to content

Apache Lucene open-source search software

deps(java): bump com.google.errorprone:error_prone_core from 2.47.0 to 2.48.0 (#15810)

dependabot[bot]40eba7db84b3
diff --git a/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/ErrorPronePlugin.java b/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/ErrorPronePlugin.java
index 2947d6f81b1..4b50dc90bca 100644
--- a/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/ErrorPronePlugin.java
+++ b/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/ErrorPronePlugin.java
@@ -280,9 +280,9 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"ArraysAsListPrimitiveArray:OFF", // we don't use guava
"AssertEqualsArgumentOrderChecker:WARN",
"AssertFalse:OFF", // TODO: new, not checked if applicable to Lucene
+ "AssertSameIncompatible:WARN",
"AssertThrowsMultipleStatements:WARN",
"AssertionFailureIgnored:OFF", // TODO: there are problems
- "AssertSameIncompatible:WARN",
"AssignmentExpression:OFF", // TODO: there are problems
"AssistedInjectAndInjectOnConstructors:OFF", // TODO: new, not checked if applicable to Lucene
"AssistedInjectAndInjectOnSameConstructor:OFF", // we don't use this annotation
@@ -297,6 +297,7 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"AutoValueImmutableFields:OFF", // we don't use autovalue
"AutoValueSubclassLeaked:OFF", // we don't use autovalue
"AvoidObjectArrays:OFF", // TODO: new, not checked if applicable to Lucene
+ "AvoidValueSetter:ERROR",
"BadAnnotationImplementation:ERROR",
"BadComparable:WARN",
"BadImport:OFF", // TODO: there are problems
@@ -443,8 +444,8 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"ForEachIterable:OFF", // TODO: new, not checked if applicable to Lucene
"ForOverride:OFF", // we don't use this annotation
"FormatString:ERROR",
- "FormatStringShouldUsePlaceholders:ERROR",
"FormatStringAnnotation:OFF", // we don't use this annotation
+ "FormatStringShouldUsePlaceholders:ERROR",
"FragmentInjection:OFF", // we don't use android
"FragmentNotInstantiable:OFF", // we don't use android
"FromTemporalAccessor:OFF", // we don't use .from(LocalDate) etc
@@ -494,7 +495,6 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"InheritDoc:WARN",
"InitializeInline:OFF", // TODO: new, not checked if applicable to Lucene
"InjectInvalidTargetingOnScopingAnnotation:OFF", // we don't use this annotation
- "InjectMoreThanOneQualifier:OFF", // TODO: new, not checked if applicable to Lucene
"InjectMoreThanOneScopeAnnotationOnClass:OFF", // we don't use this annotation
"InjectOnBugCheckers:OFF", // we don't use this annotation
"InjectOnConstructorOfAbstractClass:OFF", // we don't use this annotation
@@ -510,12 +510,12 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"InsecureCryptoUsage:OFF", // TODO: new, not checked if applicable to Lucene
"InstanceOfAndCastMatchWrongType:WARN",
"InstantTemporalUnit:OFF", // we don't use Instant apis with strange temporal units
- "InterruptedInCatchBlock:OFF", // I don't see the point of this.
"IntFloatConversion:ERROR",
"IntLiteralCast:OFF", // TODO: there are problems
"IntLongMath:OFF", // noisy
"InterfaceWithOnlyStatics:OFF", // TODO: new, not checked if applicable to Lucene
"InterruptedExceptionSwallowed:OFF", // TODO: new, not checked if applicable to Lucene
+ "InterruptedInCatchBlock:OFF", // I don't see the point of this.
"Interruption:OFF", // TODO: new, not checked if applicable to Lucene
"InvalidBlockTag:OFF", // noisy (e.g. lucene.experimental)
"InvalidInlineTag:OFF", // TODO: there are problems
@@ -622,6 +622,7 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"ModifySourceCollectionInStream:WARN",
"ModifyingCollectionWithItself:ERROR",
"MoreThanOneInjectableConstructor:OFF", // we don't use this annotation
+ "MoreThanOneQualifier:OFF", // applies to guice/dagger/di injection frameworks
"MultiVariableDeclaration:OFF", // TODO: new, not checked if applicable to Lucene
"MultimapKeys:WARN",
"MultipleNullnessAnnotations:OFF", // we don't use these annotations
@@ -698,8 +699,7 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"PreferredInterfaceType:OFF", // TODO: new, not checked if applicable to Lucene
"PrimitiveArrayPassedToVarargsMethod:OFF", // TODO: new, not checked if applicable to Lucene
"PrimitiveAtomicReference:WARN",
- "PrivateConstructorForNoninstantiableModule:OFF", // TODO: new, not checked if applicable to
- // Lucene
+ "PrivateConstructorForNoninstantiableModule:OFF", // TODO: new, not checked
"PrivateConstructorForUtilityClass:OFF", // TODO: new, not checked if applicable to Lucene
"PrivateSecurityContractProtoAccess:OFF", // we don't use protobuf
"ProtectedMembersInFinalClass:OFF", // we don't use protobuf
@@ -738,6 +738,7 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"RuleNotRun:ERROR",
"RxReturnValueIgnored:OFF", // we don't use rxjava
"SameNameButDifferent:OFF", // TODO: there are problems
+ "ScannerUseDelimiter:OFF", // not very useful
"ScopeOnModule:OFF", // TODO: new, not checked if applicable to Lucene
"SelfAlwaysReturnsThis:OFF", // we don't use self() methods, this isn't python.
"SelfAssertion:ERROR",
@@ -746,7 +747,6 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"SelfEquals:ERROR",
"SelfSet:ERROR",
"SetUnrecognized:OFF", // we don't use protobuf
- "ScannerUseDelimiter:OFF", // not very useful
"ShortCircuitBoolean:OFF", // TODO: there are problems
"ShouldHaveEvenArgs:OFF", // we don't use truth
"SizeGreaterThanOrEqualsZero:ERROR",
@@ -825,6 +825,7 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"UnicodeDirectionalityCharacters:ERROR",
"UnicodeEscape:OFF", // noisy
"UnicodeInCode:ERROR",
+ "UnnamedVariable:OFF", // ecj does it already.
"UnnecessarilyFullyQualified:OFF", // TODO: new, not checked if applicable to Lucene
"UnnecessarilyUsedValue:OFF", // TODO: new, not checked if applicable to Lucene
"UnnecessarilyVisible:OFF", // TODO: new, not checked if applicable to Lucene
@@ -845,12 +846,12 @@ public class ErrorPronePlugin extends LuceneGradlePlugin {
"UnnecessaryOptionalGet:OFF", // TODO: new, not checked if applicable to Lucene
"UnnecessaryParentheses:OFF", // noisy
"UnnecessaryQualifier:OFF", // we don't use guava
+ "UnnecessarySemicolon:OFF", // TODO: buggy, https://github.com/google/error-prone/issues/5548
"UnnecessarySetDefault:OFF", // TODO: new, not checked if applicable to Lucene
"UnnecessaryStaticImport:OFF", // TODO: new, not checked if applicable to Lucene
"UnnecessaryStringBuilder:WARN",
"UnnecessaryTestMethodPrefix:OFF", // stylistic
"UnnecessaryTypeArgument:ERROR",
- "UnnamedVariable:OFF", // ecj does it already.
"UnrecognisedJavadocTag:WARN",
"UnsafeFinalization:OFF", // we don't use finalizers, deprecated for removal, fails build
"UnsafeLocaleUsage:OFF", // TODO: new, not checked if applicable to Lucene
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index d07e8d2823a..18834d5c239 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -11,7 +11,7 @@ commons-compress = "1.28.0"
# See ecj-lint.gradle (used for more linting).
ecj = "3.44.0"
# java linting
-errorprone = "2.47.0"
+errorprone = "2.48.0"
# markdown documentation generation
flexmark = "0.64.8"
# @keep This is GJF version for java source code formatting
@@ -99,7 +99,7 @@ zstd = { module = "com.github.luben:zstd-jni", version.ref = "zstd" }
benmanes-versions = "com.github.ben-manes.versions:0.53.0"
carrotsearch-buildopts = "com.carrotsearch.gradle.opts:0.2.0"
carrotsearch-dependencychecks = "com.carrotsearch.gradle.dependencychecks:0.2.1"
-errorprone = "net.ltgt.errorprone:5.0.0"
+errorprone = "net.ltgt.errorprone:5.1.0"
forbiddenapis = "de.thetaphi.forbiddenapis:3.10"
jacocolog = "org.barfuin.gradle.jacocolog:4.0.1"
randomizedtesting = "com.carrotsearch.gradle.randomizedtesting:0.0.6"
diff --git a/versions.lock b/versions.lock
index 3a5cc243568..8011d3c02bb 100644
--- a/versions.lock
+++ b/versions.lock
@@ -33,16 +33,16 @@
"com.google.auto.service:auto-service-annotations:1.0.1" : "90685606,refs=39",
"com.google.auto.value:auto-value-annotations:1.9" : "90685606,refs=39",
"com.google.auto:auto-common:1.2.2" : "90685606,refs=39",
- "com.google.errorprone:error_prone_annotation:2.47.0" : "90685606,refs=39",
- "com.google.errorprone:error_prone_annotations:2.47.0" : "90685606,refs=39",
- "com.google.errorprone:error_prone_check_api:2.47.0" : "90685606,refs=39",
- "com.google.errorprone:error_prone_core:2.47.0" : "90685606,refs=39",
- "com.google.googlejavaformat:google-java-format:1.27.0" : "90685606,refs=39",
+ "com.google.errorprone:error_prone_annotation:2.48.0" : "90685606,refs=39",
+ "com.google.errorprone:error_prone_annotations:2.48.0" : "90685606,refs=39",
+ "com.google.errorprone:error_prone_check_api:2.48.0" : "90685606,refs=39",
+ "com.google.errorprone:error_prone_core:2.48.0" : "90685606,refs=39",
+ "com.google.googlejavaformat:google-java-format:1.34.1" : "90685606,refs=39",
"com.google.guava:failureaccess:1.0.3" : "90685606,refs=39",
"com.google.guava:guava:33.5.0-jre" : "90685606,refs=39",
"com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava" : "90685606,refs=39",
"com.google.j2objc:j2objc-annotations:3.1" : "90685606,refs=39",
- "com.google.protobuf:protobuf-java:3.25.5" : "90685606,refs=39",
+ "com.google.protobuf:protobuf-java:4.33.2" : "90685606,refs=39",
"com.ibm.icu:icu4j:78.2" : "ffa00415,refs=8",
"commons-codec:commons-codec:1.21.0" : "9dde4cb5,refs=8",
"commons-io:commons-io:2.20.0" : "6f16ff86,refs=2",