Apache Lucene open-source search software
fix use of wrong array equals() method in test, enable check (#11977)
Robert Muir4885b5f85673
diff --git a/gradle/validation/error-prone.gradle b/gradle/validation/error-prone.gradleindex bdf6701bc3b..294a824c83b 100644--- a/gradle/validation/error-prone.gradle+++ b/gradle/validation/error-prone.gradle@@ -78,7 +78,7 @@ allprojects { prj ->'-Xep:AlwaysThrows:ERROR','-Xep:AndroidInjectionBeforeSuper:ERROR',- // '-Xep:ArrayEquals:OFF',+ '-Xep:ArrayEquals:ERROR','-Xep:ArrayFillIncompatibleType:ERROR',// '-Xep:ArrayHashCode:OFF',// '-Xep:ArrayToString:OFF',diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.javaindex b0a3e35348a..1eb80ea5081 100644--- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.java+++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.java@@ -21,6 +21,7 @@ import java.io.IOException;import java.io.StringReader;import java.text.ParseException;import java.util.ArrayList;+import java.util.Arrays;import java.util.HashSet;import java.util.List;import java.util.Locale;@@ -1401,7 +1402,7 @@ public class TestSynonymGraphFilter extends BaseTokenStreamTestCase {for (int j = 0; j < synCount; j++) {OneSyn syn2 = syns.get(i);keepOrig |= syn2.keepOrig;- if (syn1.in.equals(syn2.in)) {+ if (Arrays.equals(syn1.in, syn2.in)) {count += syn2.out.length;}}