Apache Lucene open-source search software
Forbidden Thread.sleep API (#13001)
Shubham Chaudhary4b5917029f65
diff --git a/gradle/validation/forbidden-apis/defaults.all.txt b/gradle/validation/forbidden-apis/defaults.all.txtindex 0c67167aaf7..8fa8de5a469 100644--- a/gradle/validation/forbidden-apis/defaults.all.txt+++ b/gradle/validation/forbidden-apis/defaults.all.txt@@ -74,3 +74,5 @@ javax.sql.rowset.spi.SyncFactory@defaultMessage Math.fma is insanely slow (2500x) in many environments (e.g. VMs). Use multiply/add and suffer the extra roundingjava.lang.Math#fma(float,float,float)java.lang.Math#fma(double,double,double)++java.lang.Thread#sleep(**) @ Thread.sleep makes inefficient use of resources, introduces weird race conditions and slows down the code/tests. Not a scalable and good practice so we should prevent it creeping into lucene codediff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txtindex c1620c6178f..14c4e434b39 100644--- a/lucene/CHANGES.txt+++ b/lucene/CHANGES.txt@@ -276,6 +276,8 @@ Other* GITHUB#13053: Minor AnyQueryNode code cleanup (Dmitry Cherniachenko)+* GITHUB#13001: Forbidden Thread#sleep API. (Shubham Chaudhary)+======================== Lucene 9.9.2 =======================Bug Fixesdiff --git a/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/NearRealtimeReaderTask.java b/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/NearRealtimeReaderTask.javaindex 1e82fac6193..e250b0746d8 100644--- a/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/NearRealtimeReaderTask.java+++ b/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/NearRealtimeReaderTask.java@@ -20,6 +20,7 @@ import org.apache.lucene.benchmark.byTask.PerfRunData;import org.apache.lucene.index.DirectoryReader;import org.apache.lucene.index.IndexWriter;import org.apache.lucene.util.ArrayUtil;+import org.apache.lucene.util.SuppressForbidden;/*** Spawns a BG thread that periodically (defaults to 3.0 seconds, but accepts param in seconds)@@ -40,6 +41,7 @@ public class NearRealtimeReaderTask extends PerfTask {super(runData);}+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic int doLogic() throws Exception {diff --git a/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/TaskSequence.java b/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/TaskSequence.javaindex afa8d7b4f67..92b2e057f9f 100644--- a/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/TaskSequence.java+++ b/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/TaskSequence.java@@ -25,8 +25,10 @@ import org.apache.lucene.benchmark.byTask.PerfRunData;import org.apache.lucene.benchmark.byTask.feeds.NoMoreDataException;import org.apache.lucene.benchmark.byTask.stats.TaskStats;import org.apache.lucene.util.ArrayUtil;+import org.apache.lucene.util.SuppressForbidden;/** Sequence of parallel or sequential tasks. */+@SuppressForbidden(reason = "Thread sleep")public class TaskSequence extends PerfTask {public static int REPEAT_EXHAUST = -2;private ArrayList<PerfTask> tasks;diff --git a/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/WaitTask.java b/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/WaitTask.javaindex 7c6c22f46b0..2634202e92e 100644--- a/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/WaitTask.java+++ b/lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/WaitTask.java@@ -17,6 +17,7 @@package org.apache.lucene.benchmark.byTask.tasks;import org.apache.lucene.benchmark.byTask.PerfRunData;+import org.apache.lucene.util.SuppressForbidden;/*** Simply waits for the specified (via the parameter) amount of time. For example Wait(30s) waits@@ -58,6 +59,7 @@ public class WaitTask extends PerfTask {}}+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic int doLogic() throws Exception {Thread.sleep((long) (1000 * waitTimeSec));diff --git a/lucene/classification/src/test/org/apache/lucene/classification/Test20NewsgroupsClassification.java b/lucene/classification/src/test/org/apache/lucene/classification/Test20NewsgroupsClassification.javaindex 8366229fb77..eca0b8c2b04 100644--- a/lucene/classification/src/test/org/apache/lucene/classification/Test20NewsgroupsClassification.java+++ b/lucene/classification/src/test/org/apache/lucene/classification/Test20NewsgroupsClassification.java@@ -64,6 +64,7 @@ import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.BytesRef;import org.apache.lucene.util.IOUtils;import org.apache.lucene.util.NamedThreadFactory;+import org.apache.lucene.util.SuppressForbidden;import org.junit.Test;@LuceneTestCase.SuppressSysoutChecks(bugUrl = "none")@@ -79,6 +80,7 @@ public final class Test20NewsgroupsClassification extends LuceneTestCase {private static boolean index = true;private static boolean split = true;+ @SuppressForbidden(reason = "Thread sleep")@Testpublic void test20Newsgroups() throws Exception {diff --git a/lucene/core/src/java/org/apache/lucene/index/CheckIndex.java b/lucene/core/src/java/org/apache/lucene/index/CheckIndex.javaindex 00d79fa8934..6f950fc26a3 100644--- a/lucene/core/src/java/org/apache/lucene/index/CheckIndex.java+++ b/lucene/core/src/java/org/apache/lucene/index/CheckIndex.java@@ -4264,6 +4264,7 @@ public final class CheckIndex implements Closeable {* @param opts The options to use for this check* @return 0 iff the index is clean, 1 otherwise*/+ @SuppressForbidden(reason = "Thread sleep")public int doCheck(Options opts) throws IOException, InterruptedException {setLevel(opts.level);setInfoStream(opts.out, opts.verbose);diff --git a/lucene/core/src/java/org/apache/lucene/search/TimeLimitingCollector.java b/lucene/core/src/java/org/apache/lucene/search/TimeLimitingCollector.javaindex 23c1a4b4ccb..1e701ae9230 100644--- a/lucene/core/src/java/org/apache/lucene/search/TimeLimitingCollector.java+++ b/lucene/core/src/java/org/apache/lucene/search/TimeLimitingCollector.java@@ -19,6 +19,7 @@ package org.apache.lucene.search;import java.io.IOException;import org.apache.lucene.index.LeafReaderContext;import org.apache.lucene.util.Counter;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/**@@ -262,6 +263,7 @@ public class TimeLimitingCollector implements Collector {this(DEFAULT_RESOLUTION, counter);}+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {while (!stop) {diff --git a/lucene/core/src/java/org/apache/lucene/store/RateLimiter.java b/lucene/core/src/java/org/apache/lucene/store/RateLimiter.javaindex 66d1572ea6c..14247ea2d55 100644--- a/lucene/core/src/java/org/apache/lucene/store/RateLimiter.java+++ b/lucene/core/src/java/org/apache/lucene/store/RateLimiter.java@@ -17,6 +17,7 @@package org.apache.lucene.store;import java.io.IOException;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/**@@ -93,6 +94,7 @@ public abstract class RateLimiter {** @return the pause time in nano seconds*/+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic long pause(long bytes) {diff --git a/lucene/core/src/java/org/apache/lucene/store/SleepingLockWrapper.java b/lucene/core/src/java/org/apache/lucene/store/SleepingLockWrapper.javaindex 7bb7ee3756a..581c407f35c 100644--- a/lucene/core/src/java/org/apache/lucene/store/SleepingLockWrapper.java+++ b/lucene/core/src/java/org/apache/lucene/store/SleepingLockWrapper.java@@ -17,6 +17,7 @@package org.apache.lucene.store;import java.io.IOException;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/**@@ -73,6 +74,7 @@ public final class SleepingLockWrapper extends FilterDirectory {}}+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic Lock obtainLock(String lockName) throws IOException {LockObtainFailedException failureReason = null;diff --git a/lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.java b/lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.javaindex 152dcdddc55..9ad5785673a 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.java@@ -53,6 +53,7 @@ import org.apache.lucene.tests.store.MockDirectoryWrapper;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.IOUtils;+import org.apache.lucene.util.SuppressForbidden;public class TestAddIndexes extends LuceneTestCase {@@ -1255,6 +1256,7 @@ public class TestAddIndexes extends LuceneTestCase {}// LUCENE-1335: test simultaneous addIndexes & close+ @SuppressForbidden(reason = "Thread sleep")public void testAddIndexesWithCloseNoWait() throws Throwable {final int NUM_COPY = 50;@@ -1279,6 +1281,7 @@ public class TestAddIndexes extends LuceneTestCase {}// LUCENE-1335: test simultaneous addIndexes & close+ @SuppressForbidden(reason = "Thread sleep")public void testAddIndexesWithRollback() throws Throwable {final int NUM_COPY = TEST_NIGHTLY ? 50 : 5;diff --git a/lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java b/lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.javaindex 06c4b5c9725..809f9463aa6 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestConcurrentMergeScheduler.java@@ -42,6 +42,7 @@ import org.apache.lucene.tests.store.MockDirectoryWrapper;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.InfoStream;+import org.apache.lucene.util.SuppressForbidden;public class TestConcurrentMergeScheduler extends LuceneTestCase {@@ -283,6 +284,7 @@ public class TestConcurrentMergeScheduler extends LuceneTestCase {}// LUCENE-4544+ @SuppressForbidden(reason = "Thread sleep")public void testMaxMergeCount() throws Exception {Directory dir = newDirectory();IndexWriterConfig iwc =@@ -301,7 +303,7 @@ public class TestConcurrentMergeScheduler extends LuceneTestCase {ConcurrentMergeScheduler cms =new ConcurrentMergeScheduler() {-+ @SuppressForbidden(reason = "Thread sleep")@Overrideprotected void doMerge(MergeSource mergeSource, MergePolicy.OneMerge merge)throws IOException {@@ -551,6 +553,7 @@ public class TestConcurrentMergeScheduler extends LuceneTestCase {}// LUCENE-6094+ @SuppressForbidden(reason = "Thread sleep")public void testHangDuringRollback() throws Throwable {Directory dir = newMockDirectory();IndexWriterConfig iwc = new IndexWriterConfig(new MockAnalyzer(random()));diff --git a/lucene/core/src/test/org/apache/lucene/index/TestDeletionPolicy.java b/lucene/core/src/test/org/apache/lucene/index/TestDeletionPolicy.javaindex ac2ff786dd9..178f2e1983a 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestDeletionPolicy.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestDeletionPolicy.java@@ -34,6 +34,7 @@ import org.apache.lucene.store.Directory;import org.apache.lucene.tests.analysis.MockAnalyzer;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.Version;/*@@ -222,6 +223,7 @@ public class TestDeletionPolicy extends LuceneTestCase {*/// TODO: this wall-clock-dependent test doesn't seem to actually test any deletionpolicy logic?@Nightly+ @SuppressForbidden(reason = "Thread sleep")public void testExpirationTimeDeletionPolicy() throws IOException, InterruptedException {final double SECONDS = 2.0;diff --git a/lucene/core/src/test/org/apache/lucene/index/TestDirectoryReader.java b/lucene/core/src/test/org/apache/lucene/index/TestDirectoryReader.javaindex 38f356d012c..026a4b49c78 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestDirectoryReader.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestDirectoryReader.java@@ -48,6 +48,7 @@ import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.Bits;import org.apache.lucene.util.BytesRef;import org.apache.lucene.util.IOUtils;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.Version;import org.junit.Assume;@@ -1005,6 +1006,7 @@ public class TestDirectoryReader extends LuceneTestCase {dir.close();}+ @SuppressForbidden(reason = "Thread sleep")public void testStressTryIncRef() throws IOException, InterruptedException {Directory dir = newDirectory();IndexWriter writer = new IndexWriter(dir, newIndexWriterConfig(new MockAnalyzer(random())));diff --git a/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java b/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.javaindex 33334fd78e5..c141cd60337 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestDocumentsWriterStallControl.java@@ -23,6 +23,7 @@ import java.util.concurrent.CountDownLatch;import java.util.concurrent.TimeUnit;import java.util.concurrent.atomic.AtomicBoolean;import org.apache.lucene.tests.util.LuceneTestCase;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/** Tests for {@link DocumentsWriterStallControl} */@@ -50,6 +51,7 @@ public class TestDocumentsWriterStallControl extends LuceneTestCase {join(waitThreads);}+ @SuppressForbidden(reason = "Thread sleep")public void testRandom() throws InterruptedException {final DocumentsWriterStallControl ctrl = new DocumentsWriterStallControl();ctrl.updateStalled(false);@@ -166,6 +168,7 @@ public class TestDocumentsWriterStallControl extends LuceneTestCase {}}+ @SuppressForbidden(reason = "Thread sleep")private void assertState(int numReleasers,int numStallers,@@ -296,6 +299,7 @@ public class TestDocumentsWriterStallControl extends LuceneTestCase {return true;}+ @SuppressForbidden(reason = "Thread sleep")public static void start(Thread[] tostart) throws InterruptedException {for (Thread thread : tostart) {thread.start();@@ -324,6 +328,7 @@ public class TestDocumentsWriterStallControl extends LuceneTestCase {}/** Waits for all incoming threads to be in wait() methods. */+ @SuppressForbidden(reason = "Thread sleep")public static void awaitState(Thread.State state, Thread... threads) throws InterruptedException {while (true) {boolean done = true;diff --git a/lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java b/lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.javaindex 5db5dbbc72c..eb6413e53a3 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java@@ -41,6 +41,7 @@ import org.apache.lucene.store.Directory;import org.apache.lucene.tests.analysis.MockAnalyzer;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.util.BytesRef;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.TestVectorUtil;/**@@ -67,6 +68,7 @@ public class TestExitableDirectoryReader extends LuceneTestCase {}/** Sleep between iterations to timeout things. */+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic BytesRef next() throws IOException {try {diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.javaindex cb00faeb856..813212cf81d 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java@@ -113,6 +113,7 @@ import org.apache.lucene.util.IOUtils;import org.apache.lucene.util.InfoStream;import org.apache.lucene.util.SetOnce;import org.apache.lucene.util.StringHelper;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;import org.apache.lucene.util.Version;import org.apache.lucene.util.automaton.Automata;@@ -1086,6 +1087,7 @@ public class TestIndexWriter extends LuceneTestCase {}}+ @SuppressForbidden(reason = "Thread sleep")public void testThreadInterruptDeadlock() throws Exception {IndexerThreadInterrupt t = new IndexerThreadInterrupt(1);t.setDaemon(true);@@ -2610,6 +2612,7 @@ public class TestIndexWriter extends LuceneTestCase {}/** Make sure that close waits for any still-running commits. */+ @SuppressForbidden(reason = "Thread sleep")public void testCloseDuringCommit() throws Exception {final CountDownLatch startCommit = new CountDownLatch(1);diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterOnJRECrash.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterOnJRECrash.javaindex 7b084734bb6..296a39af15d 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterOnJRECrash.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterOnJRECrash.java@@ -72,6 +72,7 @@ public class TestIndexWriterOnJRECrash extends TestNRTThreads {final int crashTime = TestUtil.nextInt(random(), 3000, 4000);Thread t =new Thread() {+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {try {diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterThreadsToSegments.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterThreadsToSegments.javaindex 893c72c41e8..c2d601e20d6 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterThreadsToSegments.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterThreadsToSegments.java@@ -38,6 +38,7 @@ import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.IOUtils;import org.apache.lucene.util.StringHelper;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.Version;@LuceneTestCase.SuppressCodecs({"SimpleText", "Direct"})@@ -250,6 +251,7 @@ public class TestIndexWriterThreadsToSegments extends LuceneTestCase {IOUtils.close(checker, w, dir);}+ @SuppressForbidden(reason = "Thread sleep")public void testManyThreadsClose() throws Exception {Directory dir = newDirectory();Random r = random();diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterWithThreads.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterWithThreads.javaindex df8bf0751d7..65dc37b50e5 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterWithThreads.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterWithThreads.java@@ -44,6 +44,7 @@ import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.Bits;import org.apache.lucene.util.BytesRef;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/** MultiThreaded IndexWriter tests */@@ -65,6 +66,7 @@ public class TestIndexWriterWithThreads extends LuceneTestCase {this.syncStart = syncStart;}+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {try {@@ -190,6 +192,7 @@ public class TestIndexWriterWithThreads extends LuceneTestCase {// threads are trying to add documents. Strictly// speaking, this isn't valid us of Lucene's APIs, but we// still want to be robust to this case:+ @SuppressForbidden(reason = "Thread sleep")public void testCloseWithThreads() throws Exception {int NUM_THREADS = 3;int numIterations = TEST_NIGHTLY ? 7 : 3;diff --git a/lucene/core/src/test/org/apache/lucene/index/TestMergePolicy.java b/lucene/core/src/test/org/apache/lucene/index/TestMergePolicy.javaindex a05dbd64203..9e460c7e665 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestMergePolicy.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestMergePolicy.java@@ -29,6 +29,7 @@ import org.apache.lucene.store.Directory;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.StringHelper;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.Version;public class TestMergePolicy extends LuceneTestCase {@@ -82,6 +83,7 @@ public class TestMergePolicy extends LuceneTestCase {}}+ @SuppressForbidden(reason = "Thread sleep")public void testTimeoutLargeNumberOfMerges() throws IOException, InterruptedException {try (Directory dir = newDirectory()) {MergePolicy.MergeSpecification ms = createRandomMergeSpecification(dir, 10000);diff --git a/lucene/core/src/test/org/apache/lucene/index/TestNeverDelete.java b/lucene/core/src/test/org/apache/lucene/index/TestNeverDelete.javaindex ccb7da61db1..9560db4c0d5 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestNeverDelete.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestNeverDelete.java@@ -26,12 +26,14 @@ import org.apache.lucene.tests.index.RandomIndexWriter;import org.apache.lucene.tests.store.BaseDirectoryWrapper;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;+import org.apache.lucene.util.SuppressForbidden;// Make sure if you use NoDeletionPolicy that no file// referenced by a commit point is ever deletedpublic class TestNeverDelete extends LuceneTestCase {+ @SuppressForbidden(reason = "Thread sleep")public void testIndexing() throws Exception {final Path tmpDir = createTempDir("TestNeverDelete");final BaseDirectoryWrapper d = newFSDirectory(tmpDir);diff --git a/lucene/core/src/test/org/apache/lucene/index/TestSnapshotDeletionPolicy.java b/lucene/core/src/test/org/apache/lucene/index/TestSnapshotDeletionPolicy.javaindex 19e1c89901b..a341a10349b 100644--- a/lucene/core/src/test/org/apache/lucene/index/TestSnapshotDeletionPolicy.java+++ b/lucene/core/src/test/org/apache/lucene/index/TestSnapshotDeletionPolicy.java@@ -29,6 +29,7 @@ import org.apache.lucene.store.Directory;import org.apache.lucene.store.IndexInput;import org.apache.lucene.tests.analysis.MockAnalyzer;import org.apache.lucene.tests.util.LuceneTestCase;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;import org.junit.Test;@@ -103,6 +104,7 @@ public class TestSnapshotDeletionPolicy extends LuceneTestCase {fsDir.close();}+ @SuppressForbidden(reason = "Thread sleep")private void runTest(Random random, Directory dir) throws Exception {final int maxIterations = TEST_NIGHTLY ? 100 : 10;@@ -125,6 +127,7 @@ public class TestSnapshotDeletionPolicy extends LuceneTestCase {final Thread t =new Thread() {+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {int iterations = 0;@@ -225,6 +228,7 @@ public class TestSnapshotDeletionPolicy extends LuceneTestCase {byte[] buffer = new byte[4096];+ @SuppressForbidden(reason = "Thread sleep")private void readFile(Directory dir, String name) throws Exception {IndexInput input = dir.openInput(name, newIOContext(random()));try {diff --git a/lucene/core/src/test/org/apache/lucene/search/TestLRUQueryCache.java b/lucene/core/src/test/org/apache/lucene/search/TestLRUQueryCache.javaindex 905263c74dd..352af57f4e0 100644--- a/lucene/core/src/test/org/apache/lucene/search/TestLRUQueryCache.java+++ b/lucene/core/src/test/org/apache/lucene/search/TestLRUQueryCache.java@@ -73,6 +73,7 @@ import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.Accountable;import org.apache.lucene.util.BytesRef;import org.apache.lucene.util.IOUtils;+import org.apache.lucene.util.SuppressForbidden;public class TestLRUQueryCache extends LuceneTestCase {@@ -233,6 +234,7 @@ public class TestLRUQueryCache extends LuceneTestCase {}}+ @SuppressForbidden(reason = "Thread sleep")public void testLRUEviction() throws Exception {Directory dir = newDirectory();final RandomIndexWriter w = new RandomIndexWriter(random(), dir);diff --git a/lucene/core/src/test/org/apache/lucene/search/TestSearcherManager.java b/lucene/core/src/test/org/apache/lucene/search/TestSearcherManager.javaindex 435c386b934..e44855afe87 100644--- a/lucene/core/src/test/org/apache/lucene/search/TestSearcherManager.java+++ b/lucene/core/src/test/org/apache/lucene/search/TestSearcherManager.java@@ -47,6 +47,7 @@ import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.LuceneTestCase.SuppressCodecs;import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.NamedThreadFactory;+import org.apache.lucene.util.SuppressForbidden;@SuppressCodecs({"SimpleText", "Direct"})public class TestSearcherManager extends ThreadedIndexingAndSearchingTestCase {@@ -105,11 +106,13 @@ public class TestSearcherManager extends ThreadedIndexingAndSearchingTestCase {lifetimeMGR = new SearcherLifetimeManager();}+ @SuppressForbidden(reason = "Thread sleep")@Overrideprotected void doSearching(ExecutorService es, final int maxIterations) throws Exception {Thread reopenThread =new Thread() {+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {try {diff --git a/lucene/core/src/test/org/apache/lucene/search/TestTimeLimitingCollector.java b/lucene/core/src/test/org/apache/lucene/search/TestTimeLimitingCollector.javaindex ad8a90c0872..ed90a641392 100644--- a/lucene/core/src/test/org/apache/lucene/search/TestTimeLimitingCollector.java+++ b/lucene/core/src/test/org/apache/lucene/search/TestTimeLimitingCollector.java@@ -32,6 +32,7 @@ import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.LuceneTestCase.SuppressSysoutChecks;import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.Counter;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/**@@ -377,6 +378,7 @@ public class TestTimeLimitingCollector extends LuceneTestCase {// scorer is not needed}+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void collect(final int doc) throws IOException {int docId = doc + docBase;diff --git a/lucene/core/src/test/org/apache/lucene/store/TestRateLimiter.java b/lucene/core/src/test/org/apache/lucene/store/TestRateLimiter.javaindex 8136e37deb3..20c883b93b1 100644--- a/lucene/core/src/test/org/apache/lucene/store/TestRateLimiter.java+++ b/lucene/core/src/test/org/apache/lucene/store/TestRateLimiter.java@@ -22,12 +22,14 @@ import java.util.concurrent.atomic.AtomicLong;import org.apache.lucene.store.RateLimiter.SimpleRateLimiter;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/** Simple testcase for RateLimiter.SimpleRateLimiter */public final class TestRateLimiter extends LuceneTestCase {// LUCENE-6075+ @SuppressForbidden(reason = "Thread sleep")public void testOverflowInt() throws Exception {Thread t =new Thread() {diff --git a/lucene/core/src/test/org/apache/lucene/util/TestSetOnce.java b/lucene/core/src/test/org/apache/lucene/util/TestSetOnce.javaindex 72f4d269ef2..e7329afdc25 100644--- a/lucene/core/src/test/org/apache/lucene/util/TestSetOnce.java+++ b/lucene/core/src/test/org/apache/lucene/util/TestSetOnce.java@@ -32,6 +32,7 @@ public class TestSetOnce extends LuceneTestCase {RAND = new Random(random.nextLong());}+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {try {diff --git a/lucene/core/src/test/org/apache/lucene/util/TestWeakIdentityMap.java b/lucene/core/src/test/org/apache/lucene/util/TestWeakIdentityMap.javaindex 42a212f1f46..596b3566c0b 100644--- a/lucene/core/src/test/org/apache/lucene/util/TestWeakIdentityMap.java+++ b/lucene/core/src/test/org/apache/lucene/util/TestWeakIdentityMap.java@@ -27,6 +27,7 @@ import org.apache.lucene.tests.util.LuceneTestCase;public class TestWeakIdentityMap extends LuceneTestCase {+ @SuppressForbidden(reason = "Thread sleep")public void testSimpleHashMap() {final WeakIdentityMap<String, String> map = WeakIdentityMap.newHashMap(random().nextBoolean());// we keep strong references to the keys,@@ -162,6 +163,7 @@ public class TestWeakIdentityMap extends LuceneTestCase {assertTrue(map.isEmpty());}+ @SuppressForbidden(reason = "Thread sleep")public void testConcurrentHashMap() throws Exception {// don't make threadCount and keyCount random, otherwise easily OOMs or fails otherwise:final int threadCount = TEST_NIGHTLY ? 8 : 2;diff --git a/lucene/facet/src/test/org/apache/lucene/facet/SlowDirectory.java b/lucene/facet/src/test/org/apache/lucene/facet/SlowDirectory.javaindex b0c17742c2f..7942640e872 100644--- a/lucene/facet/src/test/org/apache/lucene/facet/SlowDirectory.java+++ b/lucene/facet/src/test/org/apache/lucene/facet/SlowDirectory.java@@ -25,6 +25,7 @@ import org.apache.lucene.store.FilterIndexOutput;import org.apache.lucene.store.IOContext;import org.apache.lucene.store.IndexInput;import org.apache.lucene.store.IndexOutput;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/** Test utility - slow directory */@@ -63,6 +64,7 @@ public class SlowDirectory extends FilterDirectory {return super.openInput(name, context);}+ @SuppressForbidden(reason = "Thread sleep")void doSleep(Random random, int length) {int sTime = length < 10 ? sleepMillis : (int) (sleepMillis * Math.log(length));if (random != null) {diff --git a/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestSearcherTaxonomyManager.java b/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestSearcherTaxonomyManager.javaindex eab05feb668..d9bf0ce2d7f 100644--- a/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestSearcherTaxonomyManager.java+++ b/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestSearcherTaxonomyManager.java@@ -44,6 +44,7 @@ import org.apache.lucene.tests.analysis.MockAnalyzer;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.IOUtils;+import org.apache.lucene.util.SuppressForbidden;@LuceneTestCase.SuppressCodecs("SimpleText")public class TestSearcherTaxonomyManager extends FacetTestCase {@@ -124,6 +125,7 @@ public class TestSearcherTaxonomyManager extends FacetTestCase {}}+ @SuppressForbidden(reason = "Thread sleep")public void testNRT() throws Exception {Directory dir = newDirectory();Directory taxoDir = newDirectory();@@ -151,6 +153,7 @@ public class TestSearcherTaxonomyManager extends FacetTestCase {Thread reopener =new Thread() {+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {while (!stop.get()) {diff --git a/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyCombined.java b/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyCombined.javaindex 138560208ec..fda98d581b2 100644--- a/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyCombined.java+++ b/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyCombined.java@@ -29,6 +29,7 @@ import org.apache.lucene.facet.taxonomy.directory.DirectoryTaxonomyReader;import org.apache.lucene.facet.taxonomy.directory.DirectoryTaxonomyWriter;import org.apache.lucene.store.Directory;import org.apache.lucene.tests.util.LuceneTestCase.SuppressCodecs;+import org.apache.lucene.util.SuppressForbidden;import org.junit.Test;@SuppressCodecs("SimpleText")@@ -770,6 +771,7 @@ public class TestTaxonomyCombined extends FacetTestCase {indexDirBase.close();}+ @SuppressForbidden(reason = "Thread sleep")private void assertConsistentYoungestChild(final FacetLabel abPath,final int abOrd,@@ -801,6 +803,7 @@ public class TestTaxonomyCombined extends FacetTestCase {Thread thread =new Thread("Child Arrays Verifier") {+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {setPriority(1 + getPriority());diff --git a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/SimplePrimaryNode.java b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/SimplePrimaryNode.javaindex 16892feed08..0822b53947d 100644--- a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/SimplePrimaryNode.java+++ b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/SimplePrimaryNode.java@@ -66,6 +66,7 @@ import org.apache.lucene.tests.analysis.MockAnalyzer;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.IOUtils;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/** A primary node that uses simple TCP connections to send commands and copy files */@@ -175,6 +176,7 @@ class SimplePrimaryNode extends PrimaryNode {return writer;}+ @SuppressForbidden(reason = "Thread sleep")@Overrideprotected void preCopyMergedSegmentFiles(SegmentCommitInfo info, Map<String, FileMetaData> files)throws IOException {@@ -510,6 +512,7 @@ class SimplePrimaryNode extends PrimaryNode {tokenizedWithTermVectors.setStoreTermVectorPositions(true);}+ @SuppressForbidden(reason = "Thread sleep")private void handleIndexing(Socket socket,AtomicBoolean stop,@@ -655,6 +658,7 @@ class SimplePrimaryNode extends PrimaryNode {static final byte CMD_SET_CLOSE_WAIT_MS = 25;/** Handles incoming request to the naive TCP server wrapping this node */+ @SuppressForbidden(reason = "Thread sleep")void handleOneConnection(Random random,ServerSocket ss,diff --git a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/SimpleReplicaNode.java b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/SimpleReplicaNode.javaindex 84dca332d42..3af0915ca25 100644--- a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/SimpleReplicaNode.java+++ b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/SimpleReplicaNode.java@@ -51,6 +51,7 @@ import org.apache.lucene.store.RateLimitedIndexOutput;import org.apache.lucene.store.RateLimiter;import org.apache.lucene.tests.store.MockDirectoryWrapper;import org.apache.lucene.tests.util.LuceneTestCase;+import org.apache.lucene.util.SuppressForbidden;class SimpleReplicaNode extends ReplicaNode {final int tcpPort;@@ -170,6 +171,7 @@ class SimpleReplicaNode extends ReplicaNode {static final byte CMD_PRE_COPY_MERGE = 17;/** Handles incoming request to the naive TCP server wrapping this node */+ @SuppressForbidden(reason = "Thread sleep")void handleOneConnection(ServerSocket ss,AtomicBoolean stop,diff --git a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.javaindex 37ed05af266..9e16af78ca5 100644--- a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java+++ b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java@@ -677,6 +677,7 @@ public class TestNRTReplication extends LuceneTestCase {}@Nightly+ @SuppressForbidden(reason = "Thread sleep")public void testCrashPrimaryWhileCopying() throws Exception {Path path1 = createTempDir("1");@@ -964,6 +965,7 @@ public class TestNRTReplication extends LuceneTestCase {}}+ @SuppressForbidden(reason = "Thread sleep")private void waitForVersionAndHits(NodeProcess node, long expectedVersion, int expectedHitCount)throws Exception {try (Connection c = new Connection(node.tcpPort)) {diff --git a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestSimpleServer.java b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestSimpleServer.javaindex 2cfb6d4486b..c715bd57936 100644--- a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestSimpleServer.java+++ b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestSimpleServer.java@@ -328,6 +328,7 @@ public class TestSimpleServer extends LuceneTestCase {Thread t =new Thread() {+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {long endTime = System.nanoTime() + waitForMS * 1000000L;diff --git a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.javaindex d84de781cf2..d0e2847cb7c 100644--- a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java+++ b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java@@ -188,6 +188,7 @@ public class TestStressNRTReplication extends LuceneTestCase {final Set<Integer> crashingNodes = Collections.synchronizedSet(new HashSet<>());@Nightly+ @SuppressForbidden(reason = "Thread sleep")public void test() throws Exception {Node.globalStartNS = System.nanoTime();@@ -852,6 +853,7 @@ public class TestStressNRTReplication extends LuceneTestCase {}// Periodically wakes up and starts up any down nodes:+ @SuppressForbidden(reason = "Thread sleep")private class RestartThread extends Thread {@Overridepublic void run() {@@ -978,6 +980,7 @@ public class TestStressNRTReplication extends LuceneTestCase {}/** Randomly picks a node and runs a search against it */+ @SuppressForbidden(reason = "Thread sleep")private class SearchThread extends Thread {@Override@@ -1177,6 +1180,7 @@ public class TestStressNRTReplication extends LuceneTestCase {}}+ @SuppressForbidden(reason = "Thread sleep")private class IndexThread extends Thread {@Overridediff --git a/lucene/sandbox/src/test/org/apache/lucene/sandbox/codecs/idversion/TestIDVersionPostingsFormat.java b/lucene/sandbox/src/test/org/apache/lucene/sandbox/codecs/idversion/TestIDVersionPostingsFormat.javaindex fad34e02f41..7f67e4767f6 100644--- a/lucene/sandbox/src/test/org/apache/lucene/sandbox/codecs/idversion/TestIDVersionPostingsFormat.java+++ b/lucene/sandbox/src/test/org/apache/lucene/sandbox/codecs/idversion/TestIDVersionPostingsFormat.java@@ -56,6 +56,7 @@ import org.apache.lucene.tests.index.RandomIndexWriter;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.tests.util.TestUtil;import org.apache.lucene.util.BytesRef;+import org.apache.lucene.util.SuppressForbidden;/** Basic tests for IDVersionPostingsFormat */// Cannot extend BasePostingsFormatTestCase because this PF is not@@ -677,6 +678,7 @@ public class TestIDVersionPostingsFormat extends LuceneTestCase {// Simulates optimistic concurrency in a distributed indexing app and confirms the latest version// always wins:+ @SuppressForbidden(reason = "Thread sleep")public void testGlobalVersions() throws Exception {Directory dir = newDirectory();IndexWriterConfig iwc = newIndexWriterConfig(new MockAnalyzer(random()));@@ -750,6 +752,7 @@ public class TestIDVersionPostingsFormat extends LuceneTestCase {}}+ @SuppressForbidden(reason = "Thread sleep")private void runForReal() throws IOException, InterruptedException {startingGun.await();PerThreadVersionPKLookup lookup = null;diff --git a/lucene/suggest/src/test/org/apache/lucene/search/spell/TestSpellChecker.java b/lucene/suggest/src/test/org/apache/lucene/search/spell/TestSpellChecker.javaindex c5bbfdaed70..350a12342bf 100644--- a/lucene/suggest/src/test/org/apache/lucene/search/spell/TestSpellChecker.java+++ b/lucene/suggest/src/test/org/apache/lucene/search/spell/TestSpellChecker.java@@ -39,6 +39,7 @@ import org.apache.lucene.tests.analysis.MockAnalyzer;import org.apache.lucene.tests.util.English;import org.apache.lucene.tests.util.LuceneTestCase;import org.apache.lucene.util.NamedThreadFactory;+import org.apache.lucene.util.SuppressForbidden;/** Spell checker test case */public class TestSpellChecker extends LuceneTestCase {@@ -430,6 +431,7 @@ public class TestSpellChecker extends LuceneTestCase {* tests if the internally shared indexsearcher is correctly closed* when the spellchecker is concurrently accessed and closed.*/+ @SuppressForbidden(reason = "Thread sleep")public void testConcurrentAccess() throws IOException, InterruptedException {assertEquals(1, searchers.size());final IndexReader r = DirectoryReader.open(userindex);diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/ThreadedIndexingAndSearchingTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/ThreadedIndexingAndSearchingTestCase.javaindex 1dc5f240eeb..6143b7212a9 100644--- a/lucene/test-framework/src/java/org/apache/lucene/tests/index/ThreadedIndexingAndSearchingTestCase.java+++ b/lucene/test-framework/src/java/org/apache/lucene/tests/index/ThreadedIndexingAndSearchingTestCase.java@@ -65,6 +65,7 @@ import org.apache.lucene.util.Bits;import org.apache.lucene.util.BytesRef;import org.apache.lucene.util.NamedThreadFactory;import org.apache.lucene.util.PrintStreamInfoStream;+import org.apache.lucene.util.SuppressForbidden;// TODO// - mix in forceMerge, addIndexes@@ -146,6 +147,7 @@ public abstract class ThreadedIndexingAndSearchingTestCase extends LuceneTestCasfor (int thread = 0; thread < numThreads; thread++) {threads[thread] =new Thread() {+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {// TODO: would be better if this were cross thread, so that we make sure one thread@@ -490,6 +492,7 @@ public abstract class ThreadedIndexingAndSearchingTestCase extends LuceneTestCasprivate final Map<Object, Boolean> warmed = Collections.synchronizedMap(new WeakHashMap<>());+ @SuppressForbidden(reason = "Thread sleep")public void runTest(String testName) throws Exception {failed.set(false);diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/store/SlowClosingMockIndexInputWrapper.java b/lucene/test-framework/src/java/org/apache/lucene/tests/store/SlowClosingMockIndexInputWrapper.javaindex 436f456cd92..490fbaddd6f 100644--- a/lucene/test-framework/src/java/org/apache/lucene/tests/store/SlowClosingMockIndexInputWrapper.java+++ b/lucene/test-framework/src/java/org/apache/lucene/tests/store/SlowClosingMockIndexInputWrapper.java@@ -18,6 +18,7 @@ package org.apache.lucene.tests.store;import java.io.IOException;import org.apache.lucene.store.IndexInput;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/**@@ -32,6 +33,7 @@ class SlowClosingMockIndexInputWrapper extends MockIndexInputWrapper {super(dir, name, delegate, null);}+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void close() throws IOException {try {diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/store/SlowOpeningMockIndexInputWrapper.java b/lucene/test-framework/src/java/org/apache/lucene/tests/store/SlowOpeningMockIndexInputWrapper.javaindex 68e38543ce5..ec31d40e594 100644--- a/lucene/test-framework/src/java/org/apache/lucene/tests/store/SlowOpeningMockIndexInputWrapper.java+++ b/lucene/test-framework/src/java/org/apache/lucene/tests/store/SlowOpeningMockIndexInputWrapper.java@@ -18,6 +18,7 @@ package org.apache.lucene.tests.store;import java.io.IOException;import org.apache.lucene.store.IndexInput;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/**@@ -26,6 +27,7 @@ import org.apache.lucene.util.ThreadInterruptedException;*/class SlowOpeningMockIndexInputWrapper extends MockIndexInputWrapper {+ @SuppressForbidden(reason = "Thread sleep")public SlowOpeningMockIndexInputWrapper(MockDirectoryWrapper dir, String name, IndexInput delegate) throws IOException {super(dir, name, delegate, null);diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/util/ThrottledIndexOutput.java b/lucene/test-framework/src/java/org/apache/lucene/tests/util/ThrottledIndexOutput.javaindex 6e29e79ad69..8456b97331d 100644--- a/lucene/test-framework/src/java/org/apache/lucene/tests/util/ThrottledIndexOutput.java+++ b/lucene/test-framework/src/java/org/apache/lucene/tests/util/ThrottledIndexOutput.java@@ -20,6 +20,7 @@ import java.io.IOException;import java.util.concurrent.TimeUnit;import org.apache.lucene.store.FilterIndexOutput;import org.apache.lucene.store.IndexOutput;+import org.apache.lucene.util.SuppressForbidden;import org.apache.lucene.util.ThreadInterruptedException;/** Intentionally slow IndexOutput for testing. */@@ -115,6 +116,7 @@ public class ThrottledIndexOutput extends FilterIndexOutput {return 0;}+ @SuppressForbidden(reason = "Thread sleep")private static void sleep(long ms) {if (ms <= 0) {return;diff --git a/lucene/test-framework/src/test/org/apache/lucene/tests/util/TestWorstCaseTestBehavior.java b/lucene/test-framework/src/test/org/apache/lucene/tests/util/TestWorstCaseTestBehavior.javaindex e8b4f8eab33..c6b310c4439 100644--- a/lucene/test-framework/src/test/org/apache/lucene/tests/util/TestWorstCaseTestBehavior.java+++ b/lucene/test-framework/src/test/org/apache/lucene/tests/util/TestWorstCaseTestBehavior.java@@ -18,6 +18,7 @@ package org.apache.lucene.tests.util;import com.carrotsearch.randomizedtesting.RandomizedTest;import com.carrotsearch.randomizedtesting.annotations.Timeout;+import org.apache.lucene.util.SuppressForbidden;import org.junit.Ignore;public class TestWorstCaseTestBehavior extends LuceneTestCase {@@ -25,6 +26,7 @@ public class TestWorstCaseTestBehavior extends LuceneTestCase {public void testThreadLeak() {Thread t =new Thread() {+ @SuppressForbidden(reason = "Thread sleep")@Overridepublic void run() {try {@@ -83,12 +85,14 @@ public class TestWorstCaseTestBehavior extends LuceneTestCase {@Ignore@Timeout(millis = 500)+ @SuppressForbidden(reason = "Thread sleep")public void testTimeout() throws Exception {Thread.sleep(5000);}@Ignore@Timeout(millis = 1000)+ @SuppressForbidden(reason = "Thread sleep")public void testZombie() throws Exception {while (true) {try {