Apache Lucene open-source search software
Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet (#16399)
Sagar Upadhyaya5c79921132d8
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txtindex 3a3fdbf3ec7..8f59c576b25 100644--- a/lucene/CHANGES.txt+++ b/lucene/CHANGES.txt@@ -436,6 +436,8 @@ Optimizations* GITHUB#16380: Speed up filtered disjunction queries when the filter is part of theindex sort by advancing the filter before calculating impacts. (Alan Woodward)+* GITHUB#16399: Reuse the previous end offset to skip a redundant addresses.get() in sorted numeric rangeIntoBitSet. (Sagar Upadhyaya)+* GITHUB#16424: Use secondary or lower sorts to accelerate XXDocValuesRangeQueries if the primarysort field is empty or only contains a single value. (Alan Woodward)diff --git a/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java b/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.javaindex fa6d59a149a..cdefbca58ff 100644--- a/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java+++ b/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java@@ -2059,12 +2059,13 @@ final class Lucene90DocValuesProducer extends DocValuesProducer {v, fromDoc, endDoc, cardinality, lo, hi, bitSet, offset);return;}+ long startOffset = addresses.get(fromDoc);for (int currentDoc = fromDoc; currentDoc < endDoc; currentDoc++) {- long startOffset = addresses.get(currentDoc);long endOffset = addresses.get(currentDoc + 1L);if (sortedNumericMatchesRange(v, startOffset, endOffset, lo, hi)) {bitSet.set(currentDoc - offset);}+ startOffset = endOffset;}}