Skip to content

Apache Lucene open-source search software

Use branchless way to speedup filterCompetitiveHits (#14906)

Samuel.G5e771d8218e1
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 804c3a79228..6b9a1796c8c 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -202,6 +202,8 @@ Optimizations
* GITHUB#14827: Pre-calculate minRequiredScore to speedup filterCompetitiveHits. (Ge Song, Adrien Grand)
+* GITHUB#14906: Use branchless way to speedup filterCompetitiveHits. (Adrien Grand, Ge Song)
+
Changes in Runtime Behavior
---------------------
* GITHUB#14823: Decrease TieredMergePolicy's default number of segments per
diff --git a/lucene/core/src/java/org/apache/lucene/search/ScorerUtil.java b/lucene/core/src/java/org/apache/lucene/search/ScorerUtil.java
index bf1b145bc6d..a53994599ab 100644
--- a/lucene/core/src/java/org/apache/lucene/search/ScorerUtil.java
+++ b/lucene/core/src/java/org/apache/lucene/search/ScorerUtil.java
@@ -157,10 +157,12 @@ class ScorerUtil {
int newSize = 0;
for (int i = 0; i < buffer.size; ++i) {
- if (buffer.scores[i] >= minRequiredScore) {
- buffer.docs[newSize] = buffer.docs[i];
- buffer.scores[newSize] = buffer.scores[i];
- newSize++;
+ int doc = buffer.docs[i];
+ double score = buffer.scores[i];
+ buffer.docs[newSize] = doc;
+ buffer.scores[newSize] = score;
+ if (score >= minRequiredScore) {
+ newSize += 1;
}
}
buffer.size = newSize;