Skip to content

Apache Lucene open-source search software

Remove IOException from LeafReader#getDocCount signature (#16059)

Ignacio Vera603d979ed9cc
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 81ac0ac3cff..7a4bfab9c13 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -93,9 +93,8 @@ API Changes
* GITHUB#15605: Remove unused getCollectors() and internal collector tracking from
TopFieldCollectorManager. Clarify thread-safety documentation. (Prudhvi Godithi)
-* GITHUB#16057: Remove IOException from LeafReader#getPointValues signature. (Ignacio Vera)
-
-* GITHUB#16058: Remove IOException from LeafReader#terms signature. (Ignacio Vera)
+* GITHUB#16052: Remove IOException from LeafReader#getPointValues, LeafReader#terms,
+ LeafReader#getDocCount signatures. (Ignacio Vera)
New Features
---------------------
diff --git a/lucene/codecs/src/java/org/apache/lucene/codecs/blockterms/BlockTermsReader.java b/lucene/codecs/src/java/org/apache/lucene/codecs/blockterms/BlockTermsReader.java
index c517d716764..e24b2f3b46b 100644
--- a/lucene/codecs/src/java/org/apache/lucene/codecs/blockterms/BlockTermsReader.java
+++ b/lucene/codecs/src/java/org/apache/lucene/codecs/blockterms/BlockTermsReader.java
@@ -292,7 +292,7 @@ public class BlockTermsReader extends FieldsProducer {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
return docCount;
}
diff --git a/lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilteringPostingsFormat.java b/lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilteringPostingsFormat.java
index 3ca8491412c..7064e66868d 100644
--- a/lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilteringPostingsFormat.java
+++ b/lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilteringPostingsFormat.java
@@ -245,7 +245,7 @@ public final class BloomFilteringPostingsFormat extends PostingsFormat {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
return delegateTerms.getDocCount();
}
diff --git a/lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsReader.java b/lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsReader.java
index b8551723365..397d08827fc 100644
--- a/lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsReader.java
+++ b/lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsReader.java
@@ -251,7 +251,7 @@ public class FSTTermsReader extends FieldsProducer {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
return docCount;
}
diff --git a/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextFieldsReader.java b/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextFieldsReader.java
index 645d67d9e25..71e44fb0f82 100644
--- a/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextFieldsReader.java
+++ b/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextFieldsReader.java
@@ -774,7 +774,7 @@ class SimpleTextFieldsReader extends FieldsProducer {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
return docCount;
}
diff --git a/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextTermVectorsReader.java b/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextTermVectorsReader.java
index 7659ad6967d..5306cee211e 100644
--- a/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextTermVectorsReader.java
+++ b/lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextTermVectorsReader.java
@@ -312,7 +312,7 @@ public class SimpleTextTermVectorsReader extends TermVectorsReader {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
return 1;
}
diff --git a/lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java b/lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java
index 3404eeaf268..5c1e0ed23b8 100644
--- a/lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java
+++ b/lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java
@@ -1027,7 +1027,7 @@ public final class Lucene90CompressingTermVectorsReader extends TermVectorsReade
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
return 1;
}
diff --git a/lucene/core/src/java/org/apache/lucene/index/FilterLeafReader.java b/lucene/core/src/java/org/apache/lucene/index/FilterLeafReader.java
index 378da2faa26..e11dd33c0d0 100644
--- a/lucene/core/src/java/org/apache/lucene/index/FilterLeafReader.java
+++ b/lucene/core/src/java/org/apache/lucene/index/FilterLeafReader.java
@@ -131,7 +131,7 @@ public abstract class FilterLeafReader extends LeafReader {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
return in.getDocCount();
}
diff --git a/lucene/core/src/java/org/apache/lucene/index/LeafReader.java b/lucene/core/src/java/org/apache/lucene/index/LeafReader.java
index edb67b83668..8e010151274 100644
--- a/lucene/core/src/java/org/apache/lucene/index/LeafReader.java
+++ b/lucene/core/src/java/org/apache/lucene/index/LeafReader.java
@@ -113,7 +113,7 @@ public abstract non-sealed class LeafReader extends IndexReader {
}
@Override
- public final int getDocCount(String field) throws IOException {
+ public final int getDocCount(String field) {
final Terms terms = terms(field);
if (terms == null) {
return 0;
diff --git a/lucene/core/src/java/org/apache/lucene/index/MappedMultiFields.java b/lucene/core/src/java/org/apache/lucene/index/MappedMultiFields.java
index 0429c5b8e90..fb87b54e171 100644
--- a/lucene/core/src/java/org/apache/lucene/index/MappedMultiFields.java
+++ b/lucene/core/src/java/org/apache/lucene/index/MappedMultiFields.java
@@ -87,7 +87,7 @@ public class MappedMultiFields extends FilterFields {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
throw new UnsupportedOperationException();
}
}
diff --git a/lucene/core/src/java/org/apache/lucene/index/MultiTerms.java b/lucene/core/src/java/org/apache/lucene/index/MultiTerms.java
index 4acdba6d8bc..9b4f6c48828 100644
--- a/lucene/core/src/java/org/apache/lucene/index/MultiTerms.java
+++ b/lucene/core/src/java/org/apache/lucene/index/MultiTerms.java
@@ -222,7 +222,7 @@ public final class MultiTerms extends Terms {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
int sum = 0;
for (Terms terms : subs) {
final int v = terms.getDocCount();
diff --git a/lucene/core/src/java/org/apache/lucene/index/Terms.java b/lucene/core/src/java/org/apache/lucene/index/Terms.java
index 7174c493ef7..3f3b5bc3802 100644
--- a/lucene/core/src/java/org/apache/lucene/index/Terms.java
+++ b/lucene/core/src/java/org/apache/lucene/index/Terms.java
@@ -118,7 +118,7 @@ public abstract class Terms {
* Returns the number of documents that have at least one term for this field. Note that, just
* like other term measures, this measure does not take deleted documents into account.
*/
- public abstract int getDocCount() throws IOException;
+ public abstract int getDocCount();
/**
* Returns true if documents in this field store per-document term frequency ({@link
@@ -247,7 +247,7 @@ public abstract class Terms {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
return 0;
}
diff --git a/lucene/core/src/test/org/apache/lucene/index/TestMultiTermsEnum.java b/lucene/core/src/test/org/apache/lucene/index/TestMultiTermsEnum.java
index 829aef82044..745526379bb 100644
--- a/lucene/core/src/test/org/apache/lucene/index/TestMultiTermsEnum.java
+++ b/lucene/core/src/test/org/apache/lucene/index/TestMultiTermsEnum.java
@@ -149,7 +149,7 @@ public class TestMultiTermsEnum extends LuceneTestCase {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
throw new UnsupportedOperationException();
}
diff --git a/lucene/core/src/test/org/apache/lucene/util/TestDocIdSetBuilder.java b/lucene/core/src/test/org/apache/lucene/util/TestDocIdSetBuilder.java
index 02fa1ff54cd..efc8642383c 100644
--- a/lucene/core/src/test/org/apache/lucene/util/TestDocIdSetBuilder.java
+++ b/lucene/core/src/test/org/apache/lucene/util/TestDocIdSetBuilder.java
@@ -293,7 +293,7 @@ public class TestDocIdSetBuilder extends LuceneTestCase {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
return docCount;
}
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/codecs/ramonly/RAMOnlyPostingsFormat.java b/lucene/test-framework/src/java/org/apache/lucene/tests/codecs/ramonly/RAMOnlyPostingsFormat.java
index 4077fa1344c..c26a65f9b76 100644
--- a/lucene/test-framework/src/java/org/apache/lucene/tests/codecs/ramonly/RAMOnlyPostingsFormat.java
+++ b/lucene/test-framework/src/java/org/apache/lucene/tests/codecs/ramonly/RAMOnlyPostingsFormat.java
@@ -119,7 +119,7 @@ public final class RAMOnlyPostingsFormat extends PostingsFormat {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
return docCount;
}
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java
index 25085e5e95f..8964507556b 100644
--- a/lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java
+++ b/lucene/test-framework/src/java/org/apache/lucene/tests/index/AssertingLeafReader.java
@@ -231,7 +231,7 @@ public class AssertingLeafReader extends FilterLeafReader {
}
@Override
- public int getDocCount() throws IOException {
+ public int getDocCount() {
assertThread("Terms", creationThread);
final int docCount = in.getDocCount();
assert docCount > 0;