Skip to content

Apache Lucene open-source search software

Fix container inefficiencies in FieldInfos.java (#13254)

cinsttool7c3ee797a9d3
diff --git a/lucene/core/src/java/org/apache/lucene/index/FieldInfos.java b/lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
index 5d483f7ece1..b212d14f726 100644
--- a/lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
+++ b/lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
@@ -24,7 +24,6 @@ import static org.apache.lucene.index.FieldInfo.verifySameStoreTermVectors;
import static org.apache.lucene.index.FieldInfo.verifySameVectorOptions;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
@@ -157,7 +156,7 @@ public class FieldInfos implements Iterable<FieldInfo> {
this.softDeletesField = softDeletesField;
this.parentField = parentField;
- List<FieldInfo> valuesTemp = new ArrayList<>();
+ List<FieldInfo> valuesTemp = new ArrayList<>(infos.length);
byNumber = new FieldInfo[size];
for (int i = 0; i < size; i++) {
byNumber[i] = byNumberTemp[i];
@@ -165,8 +164,7 @@ public class FieldInfos implements Iterable<FieldInfo> {
valuesTemp.add(byNumberTemp[i]);
}
}
- values =
- Collections.unmodifiableCollection(Arrays.asList(valuesTemp.toArray(new FieldInfo[0])));
+ values = Collections.unmodifiableCollection(valuesTemp);
}
/**