Apache Lucene open-source search software
ci: populate missing job timeout-minutes, fail build if missing (#15373)
Robert Muirc3d8ba013154
diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.ymlindex 32b20f105e6..46a77ee9bfd 100644--- a/.github/workflows/actions.yml+++ b/.github/workflows/actions.yml@@ -20,6 +20,7 @@ jobs:actionlint:name: Run actionlintruns-on: ubuntu-latest+ timeout-minutes: 15steps:- name: Checkout repositoryuses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0@@ -32,6 +33,7 @@ jobs:zizmor:name: Run zizmorruns-on: ubuntu-latest+ timeout-minutes: 15permissions:security-events: write # integration with github advanced securitysteps:diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.ymlindex 668f229c7e4..bcce054d8cc 100644--- a/.github/workflows/codeql.yml+++ b/.github/workflows/codeql.yml@@ -18,6 +18,7 @@ jobs:name: Analyze (${{ matrix.language }})# Consider using larger runners or machines with greater resources for possible analysis time improvements.runs-on: ubuntu-24.04+ timeout-minutes: 15permissions:security-events: write # integrate with Github Advanced Securitydiff --git a/.github/workflows/dependency-submission.yml b/.github/workflows/dependency-submission.ymlindex a94193e9bb3..968678934c3 100644--- a/.github/workflows/dependency-submission.yml+++ b/.github/workflows/dependency-submission.yml@@ -15,6 +15,7 @@ jobs:dependency-submission:name: Submit gradle dependenciesruns-on: ubuntu-latest+ timeout-minutes: 15permissions:contents: write # see action's documentationsteps:diff --git a/.github/workflows/label-pull-request.yml b/.github/workflows/label-pull-request.ymlindex 395539b49cb..0832ba38e6f 100644--- a/.github/workflows/label-pull-request.yml+++ b/.github/workflows/label-pull-request.yml@@ -26,6 +26,7 @@ jobs:pull-requests: write # manipulate existing labelsruns-on: ubuntu-latest+ timeout-minutes: 15steps:- name: Run Labeler actiondiff --git a/.github/workflows/mark-stale-PRs.yml b/.github/workflows/mark-stale-PRs.ymlindex f7e91018a35..30708cb5123 100644--- a/.github/workflows/mark-stale-PRs.yml+++ b/.github/workflows/mark-stale-PRs.yml@@ -21,6 +21,8 @@ jobs:pull-requests: write # must comment/label PRsactions: write # must manipulate actions cache to split workload across multiple runs+ timeout-minutes: 15+steps:- name: Run stale PR actionuses: actions/stale@5f858e3efba33a5ca4407a664cc011ad407f2008 # v10.1.0diff --git a/.github/workflows/run-nightly-smoketester.yml b/.github/workflows/run-nightly-smoketester.ymlindex 05f70a87d6e..4ea4f174601 100644--- a/.github/workflows/run-nightly-smoketester.yml+++ b/.github/workflows/run-nightly-smoketester.yml@@ -25,6 +25,7 @@ jobs:java-version: [ '25' ]runs-on: ${{ matrix.os }}+ timeout-minutes: 30env:LUCENE_RELEASE_DIR: /tmp/lucene-release-dirdiff --git a/.github/workflows/verify-changelog-and-set-milestone.yml b/.github/workflows/verify-changelog-and-set-milestone.ymlindex 2b736b9159d..3427c5a9cef 100644--- a/.github/workflows/verify-changelog-and-set-milestone.yml+++ b/.github/workflows/verify-changelog-and-set-milestone.yml@@ -8,6 +8,7 @@ permissions: {}jobs:changelog-verifier-and-milestone-setter:name: Verify Change Log Entry and Set Milestone+ timeout-minutes: 15runs-on: ubuntu-latestif: github.event.pull_request.draft == falsepermissions:diff --git a/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/astgrep/AstGrepPlugin.java b/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/astgrep/AstGrepPlugin.javaindex b30092e11ee..8f13fc23b25 100644--- a/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/astgrep/AstGrepPlugin.java+++ b/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/astgrep/AstGrepPlugin.java@@ -70,9 +70,16 @@ public class AstGrepPlugin implements Plugin<Project> {}var args = new ArrayList<String>();- // fail on any rule match regardless of severity level+ // fail on any rule match regardless of severity level. Scan hidden files/directories+ // too.args.addAll(- List.of("scan", "-c", "gradle/validation/ast-grep/sgconfig.yml", "--error"));+ List.of(+ "scan",+ "-c",+ "gradle/validation/ast-grep/sgconfig.yml",+ "--error",+ "--no-ignore",+ "hidden"));// use the github format when being run as a workflowif (System.getenv("CI") != null && System.getenv("GITHUB_WORKFLOW") != null) {args.addAll(List.of("--format", "github"));diff --git a/gradle/validation/ast-grep/rules/actions.yml b/gradle/validation/ast-grep/rules/actions.ymlnew file mode 100644index 00000000000..e5abe516d42--- /dev/null+++ b/gradle/validation/ast-grep/rules/actions.yml@@ -0,0 +1,50 @@+# Checks for github actions+---+# yaml-language-server: $schema=https://raw.githubusercontent.com/ast-grep/ast-grep/refs/heads/main/schemas/yaml_rule.json+id: missing-job-timeout+language: yaml+files:+ - ".github/workflows/**.yml"+rule:+ kind: block_mapping_pair+ all:+ - has:+ kind: flow_node+ field: key+ pattern: $JOBNAME+ - has:+ kind: block_node+ field: value+ has:+ kind: block_mapping+ # doesn't have timeout minutes+ not:+ has:+ kind: block_mapping_pair+ has:+ field: key+ kind: flow_node+ has:+ pattern: timeout-minutes+ stopBy: end+ inside:+ kind: block_mapping+ inside:+ kind: block_node+ inside:+ # top-level "jobs:"+ kind: block_mapping_pair+ inside:+ kind: block_mapping+ inside:+ kind: block_node+ inside:+ kind: document+ has:+ field: key+ kind: flow_node+ has:+ pattern: jobs+ stopBy: end+severity: error+message: workflow job `$JOBNAME` missing `timeout-minutes:`diff --git a/gradle/validation/ast-grep/tests/actions.yml b/gradle/validation/ast-grep/tests/actions.ymlnew file mode 100644index 00000000000..5f350600bc7--- /dev/null+++ b/gradle/validation/ast-grep/tests/actions.yml@@ -0,0 +1,18 @@+---+id: missing-job-timeout+invalid:+ - |+ jobs:+ foobar:+ runs-on: supercomputer+valid:+ - |+ jobs:+ foobar:+ runs-on: supercomputer+ timeout-minutes: 30+ - |+ somethingelse:+ jobs:+ foobar:+ unrelated: stuff