Skip to content

Apache Lucene open-source search software

LUCENE-10144:fix resource leak due to Files.list (#354)

lujiefsicbb5b6e331fa
diff --git a/buildSrc/src/main/java/org/apache/lucene/gradle/datasets/ExtractReuters.java b/buildSrc/src/main/java/org/apache/lucene/gradle/datasets/ExtractReuters.java
index b8d6735c908..34f046ffbe3 100644
--- a/buildSrc/src/main/java/org/apache/lucene/gradle/datasets/ExtractReuters.java
+++ b/buildSrc/src/main/java/org/apache/lucene/gradle/datasets/ExtractReuters.java
@@ -27,6 +27,7 @@ import java.nio.file.Paths;
import java.nio.file.StandardCopyOption;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
+import java.util.stream.Stream;
/**
* Split the Reuters SGML documents into Simple Text files containing:
@@ -44,9 +45,10 @@ public class ExtractReuters {
public void extract() throws IOException {
long count = 0;
Files.createDirectories(outputDir);
-
- if (Files.list(outputDir).count() > 0) {
- throw new IOException("The output directory must be empty: " + outputDir);
+ try(Stream<Path> files = Files.list(outputDir)) {
+ if (files.count() > 0) {
+ throw new IOException("The output directory must be empty: " + outputDir);
+ }
}
try (DirectoryStream<Path> stream = Files.newDirectoryStream(reutersDir, "*.sgm")) {