Skip to content

Apache Lucene open-source search software

Simplify SearchImpl#createSimilarity in luke module (#15828)

gaobinlongcf1cad062171
diff --git a/lucene/luke/src/java/org/apache/lucene/luke/models/search/SearchImpl.java b/lucene/luke/src/java/org/apache/lucene/luke/models/search/SearchImpl.java
index e95ca09060d..440751471ff 100644
--- a/lucene/luke/src/java/org/apache/lucene/luke/models/search/SearchImpl.java
+++ b/lucene/luke/src/java/org/apache/lucene/luke/models/search/SearchImpl.java
@@ -391,18 +391,9 @@ public final class SearchImpl extends LukeModel implements Search {
}
private Similarity createSimilarity(SimilarityConfig config) {
- Similarity similarity;
-
- if (config.isUseClassicSimilarity()) {
- ClassicSimilarity tfidf = new ClassicSimilarity(config.isDiscountOverlaps());
- similarity = tfidf;
- } else {
- BM25Similarity bm25 =
- new BM25Similarity(config.getK1(), config.getB(), config.isDiscountOverlaps());
- similarity = bm25;
- }
-
- return similarity;
+ return config.isUseClassicSimilarity()
+ ? new ClassicSimilarity(config.isDiscountOverlaps())
+ : new BM25Similarity(config.getK1(), config.getB(), config.isDiscountOverlaps());
}
@Override