Skip to content

Apache Lucene open-source search software

Fix an interesting errorprone warning about System.console() never returning null. I opted to suppress the warning because the docs don't guarantee this but added isTerminal to detect non-terminal Console implementations. #15388

Dawid Weissd0e7099625e2
diff --git a/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/scripts/StageArtifacts.java b/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/scripts/StageArtifacts.java
index 368e5263436..c1b069c8548 100644
--- a/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/scripts/StageArtifacts.java
+++ b/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/scripts/StageArtifacts.java
@@ -80,6 +80,7 @@ public class StageArtifacts {
}
}
+ @SuppressWarnings("SystemConsoleNull")
static Params parse(String[] args) {
try {
var params = new Params();
@@ -138,11 +139,12 @@ public class StageArtifacts {
params.userPass = envVar("ASF_PASSWORD");
if (params.userPass == null) {
Console console = System.console();
- if (console != null) {
+ if (console != null && console.isTerminal()) {
System.out.println("Enter password for " + params.userName + ":");
params.userPass = console.readPassword();
} else {
- throw new RuntimeException("No console, can't prompt for password.");
+ throw new RuntimeException(
+ "No console or console isn't a terminal, can't prompt for password.");
}
}
}