Skip to content

Apache Lucene open-source search software

Fix test failure with zero-length vector (#12493)

Benjamin Trentdd4e66dad672
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
index e7760185824..7f5dce9aa5e 100644
--- a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
+++ b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
@@ -1222,15 +1222,23 @@ public abstract class BaseKnnVectorsFormatTestCase extends BaseIndexFileFormatTe
}
private float[] randomVector(int dim) {
+ assert dim > 0;
float[] v = new float[dim];
- for (int i = 0; i < dim; i++) {
- v[i] = random().nextFloat();
+ double squareSum = 0.0;
+ // keep generating until we don't get a zero-length vector
+ while (squareSum == 0.0) {
+ squareSum = 0.0;
+ for (int i = 0; i < dim; i++) {
+ v[i] = random().nextFloat();
+ squareSum += v[i] * v[i];
+ }
}
VectorUtil.l2normalize(v);
return v;
}
private byte[] randomVector8(int dim) {
+ assert dim > 0;
float[] v = randomVector(dim);
byte[] b = new byte[dim];
for (int i = 0; i < dim; i++) {