Skip to content

Apache Lucene open-source search software

Reduce K in KNN test to avoid occasional (expected) random test fails (#16275)

Michael Sokolove5742cfec54d
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
index 106e3f320be..7556c0b020a 100644
--- a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
+++ b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
@@ -148,14 +148,6 @@ public abstract class BaseKnnVectorsFormatTestCase extends BaseIndexFileFormatTe
}
}
- @Override
- protected boolean mergeIsStable() {
- // suppress this test from base class: merges for knn graphs are not stable due to connected
- // components
- // logic
- return false;
- }
-
private int getVectorsMaxDimensions(String fieldName) {
return Codec.getDefault().knnVectorsFormat().getMaxDimensions(fieldName);
}
@@ -1681,7 +1673,7 @@ public abstract class BaseKnnVectorsFormatTestCase extends BaseIndexFileFormatTe
// assert that searchNearestVectors returns the expected number of documents,
// in descending score order
int size = ctx.reader().getFloatVectorValues(fieldName).size();
- int k = random().nextInt(size / 10 + 1) + 1;
+ int k = random().nextInt(size / 50 + 1) + 1;
if (k > numLiveDocsWithVectors) {
k = numLiveDocsWithVectors;
}