Apache Lucene open-source search software
LUCENE-9573 Add Vectors to TestBackwardsCompatibility (#636)
Mayya Sharipovaea4ab26e5200
diff --git a/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java b/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.javaindex ceb2029d844..83480a97db1 100644--- a/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java+++ b/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java@@ -17,7 +17,7 @@package org.apache.lucene.backward_index;import static org.apache.lucene.search.DocIdSetIterator.NO_MORE_DOCS;-import static org.apache.lucene.util.Version.LUCENE_10_0_0;+import static org.apache.lucene.util.Version.LUCENE_9_0_0;import java.io.ByteArrayOutputStream;import java.io.IOException;@@ -163,8 +163,7 @@ public class TestBackwardsCompatibility extends LuceneTestCase {private static final int DOCS_COUNT = 35;private static final int DELETED_ID = 7;- // change version to 9 when we update 9 backward indices to include KNN field- private static final int KNN_VECTOR_MIN_SUPPORTED_VERSION = LUCENE_10_0_0.major;+ private static final int KNN_VECTOR_MIN_SUPPORTED_VERSION = LUCENE_9_0_0.major;private static final String KNN_VECTOR_FIELD = "knn_field";private static final FieldType KNN_VECTOR_FIELD_TYPE =KnnVectorField.createFieldType(3, VectorSimilarityFunction.COSINE);@@ -1038,9 +1037,10 @@ public class TestBackwardsCompatibility extends LuceneTestCase {}}- public void testSearchOldIndex() throws IOException {+ public void testSearchOldIndex() throws Exception {for (String name : oldNames) {- searchIndex(oldIndexDirs.get(name), name, Version.MIN_SUPPORTED_MAJOR);+ Version version = Version.parse(name.substring(0, name.indexOf('-')));+ searchIndex(oldIndexDirs.get(name), name, Version.MIN_SUPPORTED_MAJOR, version);}if (TEST_NIGHTLY) {@@ -1048,7 +1048,8 @@ public class TestBackwardsCompatibility extends LuceneTestCase {Path oldIndexDir = createTempDir(name);TestUtil.unzip(getDataInputStream("unsupported." + name + ".zip"), oldIndexDir);try (BaseDirectoryWrapper dir = newFSDirectory(oldIndexDir)) {- searchIndex(dir, name, MIN_BINARY_SUPPORTED_MAJOR);+ Version version = Version.parse(name.substring(0, name.indexOf('-')));+ searchIndex(dir, name, MIN_BINARY_SUPPORTED_MAJOR, version);}}}@@ -1085,7 +1086,8 @@ public class TestBackwardsCompatibility extends LuceneTestCase {}}- public void searchIndex(Directory dir, String oldName, int minIndexMajorVersion)+ public void searchIndex(+ Directory dir, String oldName, int minIndexMajorVersion, Version nameVersion)throws IOException {// QueryParser parser = new QueryParser("contents", new MockAnalyzer(random));// Query query = parser.parse("handle:1");@@ -1296,7 +1298,7 @@ public class TestBackwardsCompatibility extends LuceneTestCase {searcher.getIndexReader());// test vector values and KNN search- if (minIndexMajorVersion >= KNN_VECTOR_MIN_SUPPORTED_VERSION) {+ if (nameVersion.major >= KNN_VECTOR_MIN_SUPPORTED_VERSION) {// test vector valuesint cnt = 0;for (LeafReaderContext ctx : reader.leaves()) {diff --git a/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/index.9.0.0-cfs.zip b/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/index.9.0.0-cfs.zipindex 2783c4bb2cf..71a6557a062 100644Binary files a/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/index.9.0.0-cfs.zip and b/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/index.9.0.0-cfs.zip differdiff --git a/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/index.9.0.0-nocfs.zip b/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/index.9.0.0-nocfs.zipindex 98dfb5f8c79..75926c92119 100644Binary files a/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/index.9.0.0-nocfs.zip and b/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/index.9.0.0-nocfs.zip differ