Skip to content

Apache Lucene open-source search software

deps(java): bump com.google.errorprone:error_prone_core from 2.36.0 to 2.38.0 (#14589)

dependabot[bot]eeedbba4b1e6
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index 5181edee84b..6226b765b95 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -13,7 +13,7 @@ commons-compress = "1.19"
# @keep This version refers to ECJ batch compiler from p2 repositories ("drops").
ecjP2Drop = "ecj-4.36M1"
# java linting
-errorprone = "2.36.0"
+errorprone = "2.38.0"
# markdown documentation generation
flexmark = "0.64.8"
# @keep This is GJF version for spotless/ tidy source code formatting
diff --git a/gradle/validation/error-prone.gradle b/gradle/validation/error-prone.gradle
index 0d52956dd69..057e694d67e 100644
--- a/gradle/validation/error-prone.gradle
+++ b/gradle/validation/error-prone.gradle
@@ -123,6 +123,7 @@ allprojects { prj ->
// On by Default : ERROR
+ // '-Xep:AddNullMarkedToPackageInfo:OFF', // we don't use jspecify
// '-Xep:AlwaysThrows:OFF', // we don't use google collections
// '-Xep:AndroidInjectionBeforeSuper:OFF', // we don't use android
'-Xep:ArrayEquals:ERROR',
@@ -130,6 +131,7 @@ allprojects { prj ->
'-Xep:ArrayHashCode:ERROR',
'-Xep:ArrayToString:ERROR',
// '-Xep:ArraysAsListPrimitiveArray:OFF', // we don't use guava
+ // '-Xep:AssignmentExpression:OFF', // TODO: there are problems
// '-Xep:AsyncCallableReturnsNull:OFF', // we don't use guava
// '-Xep:AsyncFunctionReturnsNull:OFF', // we don't use guava
// '-Xep:AutoValueBuilderDefaultsInConstructor:OFF', // we don't use autovalue
@@ -138,7 +140,7 @@ allprojects { prj ->
'-Xep:BadShiftAmount:ERROR',
'-Xep:BanClassLoader:ERROR',
// '-Xep:BanJNDI:OFF', // implemented with forbidden APIs instead
- '-Xep:BoxedPrimitiveEquality:ERROR',
+ // '-Xep:BoxedPrimitiveEquality:OFF', // TODO: there are problems
// '-Xep:BundleDeserializationCast:OFF', // we don't use android
'-Xep:ChainingConstructorIgnoresParameter:ERROR',
// '-Xep:CheckNotNullMultipleTimes:OFF', // we don't use guava
@@ -205,8 +207,11 @@ allprojects { prj ->
// '-Xep:InjectOnMemberAndConstructor:OFF', // we don't use this annotation
// '-Xep:InlineMeValidator:OFF', // we don't use this annotation
// '-Xep:InstantTemporalUnit:OFF', // we don't use Instant apis with strange temporal units
+ '-Xep:IntFloatConversion:ERROR',
+ // '-Xep:IntLiteralCast:OFF', // TODO: there are problems
// '-Xep:InvalidJavaTimeConstant:OFF', // we don't use impacted java.time classes (Month, etc)
// '-Xep:InvalidPatternSyntax:OFF',
+ '-Xep:InvalidSnippet:ERROR',
// '-Xep:InvalidTimeZoneID:OFF', // we don't use getTimeZone with constant IDs except UTC/GMT
// '-Xep:InvalidZoneId:OFF', // we don't use ZoneId.of
'-Xep:IsInstanceIncompatibleType:ERROR',
@@ -214,6 +219,7 @@ allprojects { prj ->
// '-Xep:IsLoggableTagLength:OFF', // we don't use android
// '-Xep:JUnit3TestNotRun:OFF', // we don't use junit3
'-Xep:JUnit4ClassAnnotationNonStatic:ERROR',
+ '-Xep:JUnit4EmptyMethods:ERROR',
// '-Xep:JUnit4SetUpNotRun:OFF', // LuceneTestCase takes care
// '-Xep:JUnit4TearDownNotRun:OFF', // LuceneTestCase takes care
// '-Xep:JUnit4TestNotRun:OFF', // noisy
@@ -230,6 +236,7 @@ allprojects { prj ->
'-Xep:LossyPrimitiveCompare:ERROR',
'-Xep:MathRoundIntLong:ERROR',
// '-Xep:MislabeledAndroidString:OFF', // we don't use android
+ '-Xep:MisleadingEmptyVarargs:ERROR',
'-Xep:MisleadingEscapedSpace:ERROR',
// '-Xep:MissingRuntimeRetention:OFF', // we don't use this annotation
// '-Xep:MisplacedScopeAnnotations:OFF', // we don't use this annotation
@@ -238,11 +245,13 @@ allprojects { prj ->
// '-Xep:MisusedDayOfYear:OFF', // we don't use date patterns
// '-Xep:MisusedWeekYear:OFF', // we don't use date patterns
// '-Xep:MixedDescriptors:OFF', // we don't use protobuf
+ // '-Xep:MockIllegalThrows:OFF', // we don't use mockito
// '-Xep:MockitoUsage:OFF', // we don't use mockito
'-Xep:ModifyingCollectionWithItself:ERROR',
// '-Xep:MoreThanOneInjectableConstructor:OFF', // we don't use this annotation
// '-Xep:MustBeClosedChecker:OFF', // we don't use this annotation
'-Xep:NCopiesOfChar:ERROR',
+ // '-Xep:NegativeBoolean:OFF', // TODO: there are problems
// '-Xep:NoCanIgnoreReturnValueOnClasses:OFF', // we don't use this annotation
'-Xep:NonCanonicalStaticImport:ERROR',
// '-Xep:NonFinalCompileTimeConstant:OFF', // we don't use this annotation
@@ -262,6 +271,7 @@ allprojects { prj ->
// '-Xep:PeriodGetTemporalUnit:OFF', // we don't use Period
// '-Xep:PeriodTimeMath:OFF', // we don't use Period
// '-Xep:PreconditionsInvalidPlaceholder:OFF', // we don't use guava
+ // '-Xep:PreconditionsExpensiveString:OFF', // we don't use guava
// '-Xep:PrivateSecurityContractProtoAccess:OFF', // we don't use protobuf
// '-Xep:ProtoBuilderReturnValueIgnored:OFF', // we don't use protobuf
// '-Xep:ProtoFieldNullComparison:OFF', // we don't use protobuf
@@ -275,15 +285,18 @@ allprojects { prj ->
// '-Xep:RequiredModifiers:OFF', // we don't use this annotation
// '-Xep:RestrictedApiChecker:OFF', // we don't use this annotation
// '-Xep:ReturnValueIgnored:OFF', // noisy
+ '-Xep:RuleNotRun:ERROR',
'-Xep:SelfAssertion:ERROR',
'-Xep:SelfAssignment:ERROR',
'-Xep:SelfComparison:ERROR',
'-Xep:SelfEquals:ERROR',
+ '-Xep:SelfSet:ERROR',
// '-Xep:SetUnrecognized:OFF', // we don't use protobuf
// '-Xep:ShouldHaveEvenArgs:OFF', // we don't use truth
'-Xep:SizeGreaterThanOrEqualsZero:ERROR',
'-Xep:StreamToString:ERROR',
'-Xep:StringBuilderInitWithChar:ERROR',
+ // '-Xep:StringConcatToTextBlock:OFF', // TODO: there are problems
'-Xep:SubstringOfZero:ERROR',
'-Xep:SuppressWarningsDeprecated:ERROR',
// '-Xep:TemporalAccessorGetChronoField:OFF', // we don't use TemporalAccessor.get
@@ -291,12 +304,14 @@ allprojects { prj ->
// '-Xep:TheoryButNoTheories:OFF', // we don't use junit theory apis/runner
// '-Xep:ThrowIfUncheckedKnownChecked:OFF', // we don't use this annotation
// '-Xep:ThrowNull:OFF', // noisy (LuceneTestCase)
+ '-Xep:TimeInStaticInitializer:ERROR',
// '-Xep:TreeToString:OFF', // we don't use javac API
// '-Xep:TryFailThrowable:OFF',
'-Xep:TypeParameterQualifier:ERROR',
'-Xep:UnicodeDirectionalityCharacters:ERROR',
'-Xep:UnicodeInCode:ERROR',
'-Xep:UnnecessaryCheckNotNull:ERROR',
+ // '-Xep:UnnecessaryCopy:OFF', // we don't use google collections
'-Xep:UnnecessaryTypeArgument:ERROR',
'-Xep:UnsafeWildcard:ERROR',
'-Xep:UnusedAnonymousClass:ERROR',
@@ -509,7 +524,7 @@ allprojects { prj ->
'-Xep:Overrides:WARN',
// '-Xep:OverridesGuiceInjectableMethod:OFF', // we don't use guice
'-Xep:OverridingMethodInconsistentArgumentNamesChecker:WARN',
- '-Xep:PatternMatchingInstanceof:WARN',
+ // '-Xep:PatternMatchingInstanceof:OFF', // there are problems and check seems not great
// '-Xep:ParameterName:OFF', // we don't pass parameters with comments in this way
// '-Xep:PreconditionsCheckNotNullRepeated:OFF', // we don't use guava
'-Xep:PrimitiveAtomicReference:WARN',
@@ -530,7 +545,7 @@ allprojects { prj ->
// '-Xep:SameNameButDifferent:OFF', // TODO: there are problems
// '-Xep:SelfAlwaysReturnsThis:OFF', // we don't use self() methods, this isn't python.
// '-Xep:ShortCircuitBoolean:OFF', // TODO: there are problems
- '-Xep:StatementSwitchToExpressionSwitch:WARN',
+ // '-Xep:StatementSwitchToExpressionSwitch:OFF', // TODO: there are problems
// '-Xep:StaticAssignmentInConstructor:OFF',
// '-Xep:StaticAssignmentOfThrowable:OFF', // noisy
// '-Xep:StaticGuardedByInstance:OFF',
diff --git a/versions.lock b/versions.lock
index ef5a0f1367a..60b5e45a620 100644
--- a/versions.lock
+++ b/versions.lock
@@ -34,16 +34,15 @@
"com.google.auto.service:auto-service-annotations:1.0.1" : "6897bc09,refs=38",
"com.google.auto.value:auto-value-annotations:1.9" : "6897bc09,refs=38",
"com.google.auto:auto-common:1.2.2" : "6897bc09,refs=38",
- "com.google.code.findbugs:jsr305:3.0.2" : "6897bc09,refs=38",
- "com.google.errorprone:error_prone_annotation:2.36.0" : "6897bc09,refs=38",
- "com.google.errorprone:error_prone_annotations:2.36.0" : "6897bc09,refs=38",
- "com.google.errorprone:error_prone_check_api:2.36.0" : "6897bc09,refs=38",
- "com.google.errorprone:error_prone_core:2.36.0" : "6897bc09,refs=38",
- "com.google.errorprone:error_prone_type_annotations:2.36.0" : "6897bc09,refs=38",
- "com.google.googlejavaformat:google-java-format:1.19.1" : "6897bc09,refs=38",
- "com.google.guava:failureaccess:1.0.1" : "6897bc09,refs=38",
- "com.google.guava:guava:32.1.3-jre" : "6897bc09,refs=38",
+ "com.google.errorprone:error_prone_annotation:2.38.0" : "6897bc09,refs=38",
+ "com.google.errorprone:error_prone_annotations:2.38.0" : "6897bc09,refs=38",
+ "com.google.errorprone:error_prone_check_api:2.38.0" : "6897bc09,refs=38",
+ "com.google.errorprone:error_prone_core:2.38.0" : "6897bc09,refs=38",
+ "com.google.googlejavaformat:google-java-format:1.24.0" : "6897bc09,refs=38",
+ "com.google.guava:failureaccess:1.0.3" : "6897bc09,refs=38",
+ "com.google.guava:guava:33.4.6-jre" : "6897bc09,refs=38",
"com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava" : "6897bc09,refs=38",
+ "com.google.j2objc:j2objc-annotations:3.0.0" : "6897bc09,refs=38",
"com.google.protobuf:protobuf-java:3.25.5" : "6897bc09,refs=38",
"com.ibm.icu:icu4j:77.1" : "ffa00415,refs=8",
"commons-codec:commons-codec:1.18.0" : "733734f0,refs=6",
@@ -63,7 +62,7 @@
"org.carrot2:morfologik-fsa:2.1.9" : "e077a675,refs=8",
"org.carrot2:morfologik-polish:2.1.9" : "cb00cecf,refs=5",
"org.carrot2:morfologik-stemming:2.1.9" : "e077a675,refs=8",
- "org.checkerframework:checker-qual:3.37.0" : "6897bc09,refs=38",
+ "org.checkerframework:checker-qual:3.19.0" : "6897bc09,refs=38",
"org.hamcrest:hamcrest:3.0" : "b35e5d7a,refs=74",
"org.jspecify:jspecify:1.0.0" : "6897bc09,refs=38",
"org.locationtech.jts:jts-core:1.20.0" : "180518e6,refs=2",