Skip to content

Apache Lucene open-source search software

Refactor for loop at PointRangeQuery hot path (#14991)

Samuel.Gfbc74a5aafd0
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index a53e5892cb9..78b096401ab 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -220,6 +220,8 @@ Optimizations
* GITHUB#14970: Further speed up filtering hits by score. (Adrien Grand)
+* GITHUB#14991: Refactor for loop at PointRangeQuery hot path. (Ge Song)
+
Changes in Runtime Behavior
---------------------
* GITHUB#14823: Decrease TieredMergePolicy's default number of segments per
diff --git a/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java b/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
index 77f7465769e..c198fecb4b3 100644
--- a/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
+++ b/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
@@ -210,7 +210,7 @@ public abstract class PointRangeQuery extends Query {
@Override
public void visit(IntsRef ref) {
- for (int i = ref.offset; i < ref.offset + ref.length; i++) {
+ for (int i = ref.offset, to = ref.offset + ref.length; i < to; i++) {
result.set(ref.ints[i]);
}
cost[0] += ref.length;
diff --git a/lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java b/lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java
index 2521a16727d..3ac9293681d 100644
--- a/lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java
+++ b/lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java
@@ -60,8 +60,8 @@ public final class DocIdSetBuilder {
@Override
public void add(IntsRef docs) {
- for (int i = 0; i < docs.length; i++) {
- bitSet.set(docs.ints[docs.offset + i]);
+ for (int i = docs.offset, to = docs.offset + docs.length; i < to; i++) {
+ bitSet.set(docs.ints[i]);
}
}