Self-hosted fitness tracker. Log workouts, track nutrition, and monitor progress. Docker deployment, mobile-friendly.
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
import { render, screen, fireEvent, waitFor, act } from '@testing-library/react'
import ExercisePicker from './ExercisePicker'
import { types, i18n } from '@lyftr/shared'
type ListParams = {
q?: string
muscle_group?: string
category?: string
equipment?: string
limit?: number
page?: number
}
const listMock = vi.fn()
vi.mock('../services/api', () => ({
exerciseAPI: { list: (params?: ListParams) => listMock(params) },
}))
// @tanstack/react-virtual measures a real scroll container, which jsdom has no
// layout for — every row would render at zero height and none would be visible.
// Reporting one row per loaded exercise keeps the list assertable without making
// the test about virtualization.
vi.mock('@tanstack/react-virtual', () => ({
useVirtualizer: ({ count }: { count: number }) => ({
getTotalSize: () => count * 64,
getVirtualItems: () =>
Array.from({ length: count }, (_, index) => ({ index, key: index, start: index * 64, size: 64 })),
}),
}))
const exercise = (id: number, name: string): types.Exercise => ({
id,
name,
muscle_group: 'quadriceps',
secondary_muscles: [],
category: 'strength',
equipment: 'barbell',
description: '',
})
// A page of exactly PAGE_SIZE rows, so the component does not treat it as the end.
const fullPage = (prefix: string) =>
Array.from({ length: 50 }, (_, i) => exercise(i + 1, `${prefix} ${i + 1}`))
beforeEach(() => {
listMock.mockReset()
})
afterEach(async () => { await i18n.changeLanguage('en') })
describe('ExercisePicker', () => {
// The picker opens with an unfiltered first page in flight. If typing a query
// while that request is outstanding is treated as "a load is already running,
// skip it", the search is silently dropped: the user is left looking at the
// alphabetical first page, having typed a query that appears to do nothing. This
// is not hypothetical — it took an e2e run 30s to fail on exactly this.
it('runs a search typed while the initial page is still loading', async () => {
let releaseInitial: (v: types.Exercise[]) => void = () => {}
listMock
.mockImplementationOnce(() => new Promise(resolve => { releaseInitial = resolve }))
.mockImplementation(() => Promise.resolve([exercise(999, 'Barbell Squat')]))
render(<ExercisePicker selectedIds={[]} onSelect={() => {}} onClose={() => {}} />)
// Type before the first page resolves.
fireEvent.change(screen.getByPlaceholderText(/search exercises/i), { target: { value: 'squat' } })
await waitFor(() => {
expect(listMock).toHaveBeenCalledWith(expect.objectContaining({ q: 'squat', page: 1 }))
})
releaseInitial(fullPage('Unfiltered'))
expect(await screen.findByText('Barbell Squat')).toBeTruthy()
})
// A slow earlier response must not overwrite a newer one. Without a sequence
// guard the list ends up showing results for a query the user has moved past.
it('ignores a stale response that arrives after a newer one', async () => {
let releaseFirst: (v: types.Exercise[]) => void = () => {}
listMock
.mockImplementationOnce(() => new Promise(resolve => { releaseFirst = resolve }))
.mockImplementation(() => Promise.resolve([exercise(2, 'Front Squat')]))
render(<ExercisePicker selectedIds={[]} onSelect={() => {}} onClose={() => {}} />)
fireEvent.change(screen.getByPlaceholderText(/search exercises/i), { target: { value: 'squat' } })
expect(await screen.findByText('Front Squat')).toBeTruthy()
// The initial unfiltered page lands late; it must not replace the search results.
releaseFirst([exercise(1, 'Stale Unfiltered Row')])
await waitFor(() => {
expect(screen.queryByText('Stale Unfiltered Row')).toBeNull()
})
expect(screen.getByText('Front Squat')).toBeTruthy()
})
it('asks the server for each page rather than filtering locally', async () => {
listMock.mockResolvedValue(fullPage('Exercise'))
render(<ExercisePicker selectedIds={[]} onSelect={() => {}} onClose={() => {}} />)
await waitFor(() => expect(listMock).toHaveBeenCalled())
// page is always explicit, and no call asks for the whole catalog.
for (const call of listMock.mock.calls) {
expect(call[0]).toHaveProperty('page')
expect(call[0]?.limit ?? 50).toBeLessThanOrEqual(100)
}
})
// A list that failed to load is not an empty list. Before useServerList reported its
// error, the catch set hasMore=false and nothing else, so the picker fell through to
// "No exercises found" — an empty catalogue, rather than a connection that dropped.
it('says the load failed instead of reporting an empty catalogue', async () => {
const err: any = new Error("timeout of 20000ms exceeded")
err.code = 'ECONNABORTED'
listMock.mockRejectedValue(err)
render(<ExercisePicker selectedIds={[]} onSelect={() => {}} onClose={() => {}} />)
await waitFor(() =>
expect(screen.getByText(/didn't respond in time/i)).toBeTruthy())
expect(screen.queryByText(/no exercises found/i)).toBeNull()
expect(screen.getByRole('button', { name: /try again/i })).toBeTruthy()
})
// Retry resumes rather than reloading, and a success clears the message.
it('recovers when Try again succeeds', async () => {
const err: any = new Error("Network Error")
listMock
.mockRejectedValueOnce(err)
.mockResolvedValue([exercise(1, 'Barbell Squat')])
render(<ExercisePicker selectedIds={[]} onSelect={() => {}} onClose={() => {}} />)
await waitFor(() => expect(screen.getByRole('button', { name: /try again/i })).toBeTruthy())
fireEvent.click(screen.getByRole('button', { name: /try again/i }))
await waitFor(() => expect(screen.getByText('Barbell Squat')).toBeTruthy())
expect(screen.queryByRole('button', { name: /try again/i })).toBeNull()
})
it('names the title, count, muscle and equipment from the catalog, and follows a switch to Spanish', async () => {
listMock.mockResolvedValue([exercise(1, 'Barbell Squat')])
render(<ExercisePicker selectedIds={[]} onSelect={() => {}} onClose={() => {}} />)
await screen.findByText('Barbell Squat')
expect(screen.getByText('Add Exercise')).toBeTruthy()
expect(screen.getByText('1 loaded')).toBeTruthy()
expect(screen.getByText('quadriceps')).toBeTruthy()
expect(screen.getByText('Barbell')).toBeTruthy()
await act(async () => { await i18n.changeLanguage('es') })
expect(screen.getByText('Agregar ejercicio')).toBeTruthy()
expect(screen.getByText('1 cargado')).toBeTruthy()
expect(screen.getByText('cuádriceps')).toBeTruthy()
expect(screen.getByText('Barra')).toBeTruthy()
expect(screen.getByPlaceholderText('Buscar ejercicios…')).toBeTruthy()
})
it('says the library is still loading when an unfiltered list comes back empty', async () => {
listMock.mockResolvedValue([])
render(<ExercisePicker selectedIds={[]} onSelect={() => {}} onClose={() => {}} />)
expect(await screen.findByText('The exercise library is still loading')).toBeTruthy()
expect(screen.getByText('Try again in a moment.')).toBeTruthy()
expect(screen.queryByText(/no exercises found/i)).toBeNull()
expect(screen.queryByRole('alert')).toBeNull()
})
it('Try again on an empty library re-requests and shows what arrives', async () => {
let release: (v: types.Exercise[]) => void = () => {}
listMock
.mockResolvedValueOnce([])
.mockImplementationOnce(() => new Promise(resolve => { release = resolve }))
render(<ExercisePicker selectedIds={[]} onSelect={() => {}} onClose={() => {}} />)
fireEvent.click(await screen.findByRole('button', { name: /try again/i }))
const retrying = await screen.findByRole('button', { name: /retrying/i })
expect((retrying as HTMLButtonElement).disabled).toBe(true)
expect(screen.getByText('The exercise library is still loading')).toBeTruthy()
expect(screen.queryByText(/no exercises found/i)).toBeNull()
await act(async () => { release([exercise(1, 'Barbell Squat')]) })
expect(await screen.findByText('Barbell Squat')).toBeTruthy()
expect(screen.queryByText('The exercise library is still loading')).toBeNull()
const last = listMock.mock.calls[listMock.mock.calls.length - 1][0]
expect(last.page).toBe(1)
expect(last).not.toHaveProperty('q')
})
it('a search with no matches keeps No exercises found', async () => {
listMock.mockImplementation((params?: ListParams) =>
Promise.resolve(params?.q || params?.page !== 1 ? [] : fullPage('Exercise')))
render(<ExercisePicker selectedIds={[]} onSelect={() => {}} onClose={() => {}} />)
await screen.findByText('Exercise 1')
fireEvent.change(screen.getByPlaceholderText(/search exercises/i), { target: { value: 'zzz' } })
expect(await screen.findByText('No exercises found')).toBeTruthy()
expect(screen.queryByText('The exercise library is still loading')).toBeNull()
})
it('the empty-library state follows a switch to Spanish (es)', async () => {
listMock.mockResolvedValue([])
render(<ExercisePicker selectedIds={[]} onSelect={() => {}} onClose={() => {}} />)
await screen.findByText('The exercise library is still loading')
await act(async () => { await i18n.changeLanguage('es') })
expect(screen.getByText('La biblioteca de ejercicios todavía se está cargando')).toBeTruthy()
expect(screen.getByText('Intentar de nuevo')).toBeTruthy()
})
})