Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.
TypeScript agentaiai-agentsall-in-onecrmcrm-systememaillinearmcpmessagingnotesnotionofficerustslackslack-alternativestartupstartup-toolstypescriptworkspace
fix(email-compose): stop the Attach tooltip from dropping picked files (#9270)
teo050b4970ad62
diff --git a/apps/web/src/lib/core/directive/fileSelector.ts b/apps/web/src/lib/core/directive/fileSelector.tsindex 3cbaeb6731..f75a487554 100644--- a/apps/web/src/lib/core/directive/fileSelector.ts+++ b/apps/web/src/lib/core/directive/fileSelector.ts@@ -38,44 +38,43 @@ export function fileSelector(return false;};- const handleFileInputChange = () => {- const files = Array.from(input.files || []);- const validFiles = files.filter(isFileTypeValid);-- if (validFiles.length > 0) {- accessor()?.onSelect(validFiles);- }- };-- let options = accessor();- let input = document.createElement('input');- input.type = 'file';- if (options?.id) {- input.id = options.id;- }- input.style.display = 'none';- const mimeTypes = options?.acceptedMimeTypes?.join(',');- const fileExtensions = options?.acceptedFileExtensions?.join(',.');- let acceptString = '';- if (mimeTypes) {- acceptString += `${mimeTypes},`;- }- if (fileExtensions) {- acceptString += `.${fileExtensions}`;- }- input.accept = acceptString;- input.multiple = options?.multiple ?? false;-+ // Each click opens a picker on its own input. This setup can run again+ // while a picker is open (a Button's tooltip re-runs its ref when it opens+ // or closes), so the input must not be replaced or unhooked by a cleanup.const clickInput = (e: MouseEvent) => {e.stopPropagation();+ const options = accessor();+ const input = document.createElement('input');+ input.type = 'file';+ if (options?.id) {+ input.id = options.id;+ }+ input.style.display = 'none';+ const mimeTypes = options?.acceptedMimeTypes?.join(',');+ const fileExtensions = options?.acceptedFileExtensions?.join(',.');+ let acceptString = '';+ if (mimeTypes) {+ acceptString += `${mimeTypes},`;+ }+ if (fileExtensions) {+ acceptString += `.${fileExtensions}`;+ }+ input.accept = acceptString;+ input.multiple = options?.multiple ?? false;+ input.addEventListener('change', () => {+ // The control was removed while the picker was open.+ if (!element.isConnected) return;+ const validFiles = Array.from(input.files || []).filter(isFileTypeValid);+ if (validFiles.length > 0) {+ accessor()?.onSelect(validFiles);+ }+ });input.click();};- input.addEventListener('change', handleFileInputChange);element.addEventListener('click', clickInput);onCleanup(() => {- input.removeEventListener('change', handleFileInputChange);element.removeEventListener('click', clickInput);});}