Macro is a unified workspace for teams: email, chat, docs, tasks, agents, calls, and CRM — @-linked together with shared AI memory.
TypeScript agentaiai-agentsall-in-onecrmcrm-systememaillinearmcpmessagingnotesnotionofficerustslackslack-alternativestartupstartup-toolstypescriptworkspace
chore: remove new inbox feature flag (#5782)
Peter Chinman0655ac4740f7
diff --git a/apps/web/src/features/next-soup/actions/make-mark-done-action.test.ts b/apps/web/src/features/next-soup/actions/make-mark-done-action.test.tsindex 48efbda921..ae918549e4 100644--- a/apps/web/src/features/next-soup/actions/make-mark-done-action.test.ts+++ b/apps/web/src/features/next-soup/actions/make-mark-done-action.test.ts@@ -15,7 +15,6 @@ const mocks = vi.hoisted(() => ({executeMarkEntitiesUndone: vi.fn(async () => {}),graphqlSoupEnabled: vi.fn(() => false),mutateAsync: vi.fn(async (_variables: unknown) => {}),- newInboxEnabled: vi.fn(() => false),openEntityInSplitFromUnifiedList: vi.fn(async () => {}),resolveMarkEntitiesDoneVariables: vi.fn(() => ({emailIds: [] as string[],@@ -30,14 +29,8 @@ vi.mock('@components/app/split-layout/layoutUtils', () => ({useSplitPanel: () => ({ handle: mocks.controller }),}));-vi.mock('@app/lib/analytics/posthog', () => ({- useFeatureFlag: () => () => ({ enabled: mocks.newInboxEnabled() }),-}));-vi.mock('@core/constant/featureFlags', () => ({ENABLE_GRAPHQL_SOUP: mocks.graphqlSoupEnabled,- ENABLE_NEW_INBOX_FLAG: 'new-inbox',- ENABLE_NEW_INBOX_OVERRIDE: undefined,}));vi.mock(@@ -130,7 +123,6 @@ describe('makeMarkDoneAction', () => {mocks.executeMarkEntitiesUndone.mockClear();mocks.graphqlSoupEnabled.mockReturnValue(false);mocks.mutateAsync.mockClear();- mocks.newInboxEnabled.mockReturnValue(false);mocks.openEntityInSplitFromUnifiedList.mockClear();mocks.resolveMarkEntitiesDoneVariables.mockReset();mocks.resolveMarkEntitiesDoneVariables.mockReturnValue({@@ -217,7 +209,6 @@ describe('makeMarkDoneAction', () => {it('keeps whole-channel inbox writes ID-based to exclude thread rows', async () => {mocks.graphqlSoupEnabled.mockReturnValue(true);- mocks.newInboxEnabled.mockReturnValue(true);mocks.controller.content.mockReturnValue({ id: 'inbox' });mocks.resolveMarkEntitiesDoneVariables.mockReturnValue({emailIds: [],@@ -244,7 +235,6 @@ describe('makeMarkDoneAction', () => {it('uses the canonical message entity for inbox channel-thread rows', async () => {mocks.graphqlSoupEnabled.mockReturnValue(true);- mocks.newInboxEnabled.mockReturnValue(true);mocks.controller.content.mockReturnValue({ id: 'inbox' });mocks.resolveMarkEntitiesDoneVariables.mockReturnValue({emailIds: [],diff --git a/apps/web/src/features/next-soup/actions/make-mark-done-action.ts b/apps/web/src/features/next-soup/actions/make-mark-done-action.tsindex f917ec142c..90a618823a 100644--- a/apps/web/src/features/next-soup/actions/make-mark-done-action.ts+++ b/apps/web/src/features/next-soup/actions/make-mark-done-action.ts@@ -8,14 +8,9 @@ import {resolveMarkEntitiesDoneVariables,restoreSoupFocus,} from '@app/features/next-soup/utils';-import { useFeatureFlag } from '@app/lib/analytics/posthog';import { useSplitPanel } from '@components/app/split-layout/layoutUtils';import { toast } from '@core/component/Toast/Toast';-import {- ENABLE_GRAPHQL_SOUP,- ENABLE_NEW_INBOX_FLAG,- ENABLE_NEW_INBOX_OVERRIDE,-} from '@core/constant/featureFlags';+import { ENABLE_GRAPHQL_SOUP } from '@core/constant/featureFlags';import type { HotkeyGroup } from '@core/hotkey/types';import type { EntityData } from '@entity';import type { NotificationSource } from '@notifications';@@ -99,21 +94,16 @@ type MarkDoneExecuteWithSoupOpts = MarkDoneExecuteOpts & {export const makeMarkDoneAction = (options: MakeMarkDoneOptions) => {const splitPanel = useSplitPanel();- const newInboxFlag = useFeatureFlag(ENABLE_NEW_INBOX_FLAG, {- enabledOverride: ENABLE_NEW_INBOX_OVERRIDE,- });-// Channel and channel_thread entities share the same notification bucket.- // The new inbox renders them as separate rows, so marking a channel as done+ // The inbox renders them as separate rows, so marking a channel as done// should not clear thread notifications.//- // TODO: This should probably be the default case after the new inbox is released- // or we should rework how notifications are sent to not be under just the 'channel'+ // TODO: This should probably be the default case everywhere, or we should+ // rework how notifications are sent to not be under just the 'channel'// entityconst scopeChannelNotificationsToEntity = () =>- newInboxFlag().enabled &&- (splitPanel?.handle.content().id === 'inbox' ||- splitPanel?.handle.referredFrom() === 'inbox');+ splitPanel?.handle.content().id === 'inbox' ||+ splitPanel?.handle.referredFrom() === 'inbox';const { notificationSource, hotkeyGroup } = options;const mutation = useUndoableMutation<diff --git a/apps/web/src/features/next-soup/sidebar/soup-filter-presets.test.ts b/apps/web/src/features/next-soup/sidebar/soup-filter-presets.test.tsindex de4e8b8875..e67b1491e2 100644--- a/apps/web/src/features/next-soup/sidebar/soup-filter-presets.test.ts+++ b/apps/web/src/features/next-soup/sidebar/soup-filter-presets.test.ts@@ -7,7 +7,6 @@ const mocks = vi.hoisted(() => ({vi.mock('@core/constant/featureFlags', () => ({ENABLE_CALENDAR_UI: () => mocks.calendarUiEnabled,- ENABLE_NEW_INBOX: () => false,ENABLE_REMINDERS: () => mocks.remindersEnabled,ENABLE_SNIPPETS: () => true,ENABLE_SUPPORTED_SOUP_FOREIGN_ENTITIES_OVERRIDE: false,@@ -26,7 +25,7 @@ import { getViewPreset, VIEW_TAB_PRESETS } from './soup-filter-presets';const mailTabs = Object.keys(VIEW_TAB_PRESETS.mail.tabs);describe('mail view presets', () => {- it('groups every mail tab by date independently of the new inbox flag', () => {+ it('groups every mail tab by date', () => {for (const tab of mailTabs) {expect(getViewPreset('mail', tab)?.groupBy).toBe('date');}diff --git a/apps/web/src/features/next-soup/sidebar/soup-filter-presets.ts b/apps/web/src/features/next-soup/sidebar/soup-filter-presets.tsindex ef9a3009f1..97b4a4d3de 100644--- a/apps/web/src/features/next-soup/sidebar/soup-filter-presets.ts+++ b/apps/web/src/features/next-soup/sidebar/soup-filter-presets.ts@@ -8,7 +8,6 @@ import {} from '@app/features/next-soup/filters/filter-store';import {ENABLE_CALENDAR_UI,- ENABLE_NEW_INBOX,ENABLE_REMINDERS,ENABLE_SNIPPETS,ENABLE_SUPPORTED_SOUP_FOREIGN_ENTITIES_OVERRIDE,@@ -186,12 +185,12 @@ export const VIEW_TAB_PRESETS: Record<ListView, ViewTabConfig> = {signal: () => ({filters: getInboxSignalFilters(),clientFilters: { and: ['inbox'] },- groupBy: ENABLE_NEW_INBOX() ? 'date' : undefined,+ groupBy: 'date',}),noise: () => ({filters: getInboxNoiseFilters(),clientFilters: { and: ['noise'] },- groupBy: ENABLE_NEW_INBOX() ? 'date' : undefined,+ groupBy: 'date',}),all: () => ({filters: {@@ -218,7 +217,7 @@ export const VIEW_TAB_PRESETS: Record<ListView, ViewTabConfig> = {emailView: 'all',},clientFilters: { and: ['explicit-noise'] },- groupBy: ENABLE_NEW_INBOX() ? 'date' : undefined,+ groupBy: 'date',}),// Pending reminders only: scheduled but not yet fired. A fired reminder// has already hit the inbox — Signal surfaces it through its not-donediff --git a/apps/web/src/features/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx b/apps/web/src/features/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsxindex 7f77048713..1667ff3119 100644--- a/apps/web/src/features/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx+++ b/apps/web/src/features/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx@@ -158,8 +158,9 @@ export const MobileFilterDrawer = (props: {return next.length ? picker.onChange(next) : picker.reset();};+ // The inbox is deliberately absent: its order is fixed to updated_at, and+ // the desktop toolbar hides SoupViewContextSort there for the same reason.const VIEW_SORT_OPTIONS: Partial<Record<ListView, SortOption[]>> = {- inbox: DEFAULT_SORT_OPTIONS,agents: DEFAULT_SORT_OPTIONS,mail: EMAIL_SORT_OPTIONS,documents: DOCUMENT_SORT_OPTIONS,diff --git a/apps/web/src/features/next-soup/soup-view/filters-bar/soup-filters-bar.tsx b/apps/web/src/features/next-soup/soup-view/filters-bar/soup-filters-bar.tsxindex 329c3ee068..e01f460784 100644--- a/apps/web/src/features/next-soup/soup-view/filters-bar/soup-filters-bar.tsx+++ b/apps/web/src/features/next-soup/soup-view/filters-bar/soup-filters-bar.tsx@@ -8,7 +8,6 @@ import {CompanyDisplayMenu,CompanyViewsMenu,} from '@app/features/next-soup/soup-view/views/companies/CompanyViewsMenu';-import { useFeatureFlag } from '@app/lib/analytics/posthog';import { CollapsibleToolbarItem } from '@components/app/split-layout/components/CollapsibleItem';import { PreviewButton } from '@components/app/split-layout/components/PreviewButton';import {@@ -16,10 +15,6 @@ import {SplitToolbarRight,} from '@components/app/split-layout/components/SplitToolbar';import { useSplitPanelOrThrow } from '@components/app/split-layout/layoutUtils';-import {- ENABLE_NEW_INBOX_FLAG,- ENABLE_NEW_INBOX_OVERRIDE,-} from '@core/constant/featureFlags';import { isTouchDevice } from '@core/mobile/isTouchDevice';import { createMemo, createSignal, Show } from 'solid-js';@@ -46,17 +41,10 @@ export function SoupFiltersBar(props: {});const isTagView = createMemo(() => props.variant === 'tag');- // The new inbox hides sort (it's fixed to updated_at for this view).- const newInboxFlag = useFeatureFlag(ENABLE_NEW_INBOX_FLAG, {- enabledOverride: ENABLE_NEW_INBOX_OVERRIDE,- });- const isNewInbox = createMemo(() => {+ // The inbox hides sort (it's fixed to updated_at for this view).+ const isInboxView = createMemo(() => {const content = panel.handle.content();- return (- content.type === 'component' &&- content.id === 'inbox' &&- newInboxFlag().enabled- );+ return content.type === 'component' && content.id === 'inbox';});const CollapsibleGroup = () => (@@ -84,14 +72,14 @@ export function SoupFiltersBar(props: {when={!isSearchView() && !isTagView()}fallback={<Show when={isTagView()} fallback={<SearchFiltersRow />}>- <Show when={!isNewInbox()}>+ <Show when={!isInboxView()}><SoupViewContextSort /></Show><CollapsibleGroup /></Show>}>- <Show when={!isNewInbox()}>+ <Show when={!isInboxView()}><SoupViewContextSort /></Show><CollapsibleGroup />diff --git a/apps/web/src/features/next-soup/soup-view/filters-bar/unified-filter-dropdown.tsx b/apps/web/src/features/next-soup/soup-view/filters-bar/unified-filter-dropdown.tsxindex 2806739990..539df925dc 100644--- a/apps/web/src/features/next-soup/soup-view/filters-bar/unified-filter-dropdown.tsx+++ b/apps/web/src/features/next-soup/soup-view/filters-bar/unified-filter-dropdown.tsx@@ -21,16 +21,11 @@ import {type ReadFilter,useSoupView,} from '@app/features/next-soup/soup-view/soup-view-context';-import { useFeatureFlag } from '@app/lib/analytics/posthog';import { useDealStages } from '@companies/crm/deal-stages';import { CrmStageIcon } from '@companies/crm/StageIcon';import { useSplitPanelOrThrow } from '@components/app/split-layout/layoutUtils';import { EntityIcon } from '@core/component/EntityIcon';import { UserIcon } from '@core/component/UserIcon';-import {- ENABLE_NEW_INBOX_FLAG,- ENABLE_NEW_INBOX_OVERRIDE,-} from '@core/constant/featureFlags';import { useUserId } from '@core/context/user';import { registerHotkey } from '@core/hotkey/hotkeys';import { TOKENS } from '@core/hotkey/tokens';@@ -583,10 +578,7 @@ export const UnifiedFilterDropdown = (return content.id;});- const newInboxFlag = useFeatureFlag(ENABLE_NEW_INBOX_FLAG, {- enabledOverride: ENABLE_NEW_INBOX_OVERRIDE,- });- const isNewInbox = () => currentView() === 'inbox' && newInboxFlag().enabled;+ const isInboxView = () => currentView() === 'inbox';const githubLinkStatus = useGithubLinkStatusQuery({enabled: () => currentView() === 'inbox',});@@ -941,7 +933,7 @@ export const UnifiedFilterDropdown = (categories().length > 0 ||isTasksView() ||isCompaniesView() ||- isNewInbox() ||+ isInboxView() ||showTagsFilter()}>@@ -972,7 +964,7 @@ export const UnifiedFilterDropdown = (<Dropdown.Content class={cn('shadow-menu min-w-32')}><Dropdown.Group>- <Show when={isNewInbox()}>+ <Show when={isInboxView()}><ReadStatusSubmenuvalue={readFilter()}onChange={setReadFilter}@@ -984,7 +976,7 @@ export const UnifiedFilterDropdown = (!isDocumentsView() &&!isTasksView() &&!isCompaniesView() &&- !isNewInbox()+ !isInboxView()}fallback={<>diff --git a/apps/web/src/features/next-soup/soup-view/soup-view-context.tsx b/apps/web/src/features/next-soup/soup-view/soup-view-context.tsxindex bc45548fc9..ef2750852c 100644--- a/apps/web/src/features/next-soup/soup-view/soup-view-context.tsx+++ b/apps/web/src/features/next-soup/soup-view/soup-view-context.tsx@@ -53,8 +53,6 @@ import { useEntryState } from '@components/app/split-layout/entry-state';import { useSplitPanelOrThrow } from '@components/app/split-layout/layoutUtils';import {ENABLE_FEATURED_SEARCH_RESULTS,- ENABLE_NEW_INBOX_FLAG,- ENABLE_NEW_INBOX_OVERRIDE,ENABLE_REMINDERS,ENABLE_SUPPORTED_SOUP_FOREIGN_ENTITIES_FLAG,ENABLE_SUPPORTED_SOUP_FOREIGN_ENTITIES_OVERRIDE,@@ -718,15 +716,11 @@ export const SoupViewContextProvider: FlowComponent<: groupByField());- // The new inbox surfaces channel threads the current user participates in —+ // The inbox surfaces channel threads the current user participates in —// the root sender, anyone who replied, or anyone @-mentioned — via the// `channelThreadParticipantId` filter, since soup otherwise only surfaces// whole channels.- const newInboxFlag = useFeatureFlag(ENABLE_NEW_INBOX_FLAG, {- enabledOverride: ENABLE_NEW_INBOX_OVERRIDE,- });- const isNewInbox = () =>- activeListView() === 'inbox' && newInboxFlag().enabled;+ const isInboxView = () => activeListView() === 'inbox';const applyInboxFilter = (state: QueryState): QueryState => {const inboxes = inboxFilter();@@ -741,7 +735,7 @@ export const SoupViewContextProvider: FlowComponent<};const applyInboxThreadFilter = (state: QueryState): QueryState => {- if (!isNewInbox()) {+ if (!isInboxView()) {return {...state,include: { ...state.include, channelThreadId: [NIL_UUID] },@@ -759,10 +753,10 @@ export const SoupViewContextProvider: FlowComponent<};};- // Unread/read/all filter for the new inbox: injects the per-entity-type seen+ // Unread/read/all filter for the inbox: injects the per-entity-type seen// filters ('all' leaves them unset). Matches the experimental inbox.const applyInboxReadFilter = (state: QueryState): QueryState => {- if (!isNewInbox()) return state;+ if (!isInboxView()) return state;const filter = readFilter();if (filter === 'all') return state;const seen = filter === 'read';@@ -905,7 +899,7 @@ export const SoupViewContextProvider: FlowComponent<return {...entityWithoutRawNotifications,notifications: () =>- isNewInbox()+ isInboxView()? scopeChannelNotificationsForEntity(entityWithoutRawNotifications,rawNotifications@@ -921,7 +915,7 @@ export const SoupViewContextProvider: FlowComponent<return {...entity,notifications: () =>- isNewInbox()+ isInboxView()? scopeChannelNotificationsForEntity(entity, notifications()): notifications(),};diff --git a/apps/web/src/features/next-soup/soup-view/soup-view.tsx b/apps/web/src/features/next-soup/soup-view/soup-view.tsxindex 798bbe6c86..b97fa7a8d6 100644--- a/apps/web/src/features/next-soup/soup-view/soup-view.tsx+++ b/apps/web/src/features/next-soup/soup-view/soup-view.tsx@@ -38,7 +38,7 @@ import {SoupViewTabs,useApplyPreset,} from '@app/features/next-soup/soup-view/soup-view-tabs';-import { useIsNewInboxEnabled } from '@app/features/next-soup/soup-view/use-is-new-inbox-enabled';+import { useIsInboxView } from '@app/features/next-soup/soup-view/use-is-inbox-view';import { CompanyKanban } from '@app/features/next-soup/soup-view/views/companies/CompanyKanban';import { CompanyListEntity } from '@app/features/next-soup/soup-view/views/companies/CompanyListEntity';import { ResponsiveCompanyListHeader } from '@app/features/next-soup/soup-view/views/companies/CompanyListHeader';@@ -259,7 +259,7 @@ export const SoupView = (props: SoupViewProps) => {const soup = useSoup();const panel = useSplitPanelOrThrow();const soupView = useSoupView();- const isNewInboxEnabled = useIsNewInboxEnabled();+ const isInboxView = useIsInboxView();const openFocusedEntityInPreview = () => {const focusedRow = soup.focus.row();if (@@ -362,7 +362,15 @@ export const SoupView = (props: SoupViewProps) => {? (initialCrmView.groupBy ?? undefined): (persistedGroupBy ?? props.initialGroupBy);- let initialSortIds = initialCrmView?.sort ?? sortPref();+ // The inbox exposes no sort control on either desktop (the toolbar+ // hides SoupViewContextSort) or mobile, so its order is always+ // updated_at. Ignore any sort persisted back when the control was+ // reachable: honoring it would pin the list to an order the user can+ // no longer change.+ let initialSortIds =+ contentId === 'inbox'+ ? ['updated_at']+ : (initialCrmView?.sort ?? sortPref());if (initialSortIds.length === 0) {initialSortIds = props.initialClientSort ?? ['updated_at'];}@@ -705,7 +713,7 @@ export const SoupView = (props: SoupViewProps) => {when={ENABLE_UNIFIED_LIST_AI_INPUT &&!isTouchDevice() &&- !isNewInboxEnabled() &&+ !isInboxView() &&!panel.handle.isControllerSplit() &&!isBoardRendered() &&!isComponentListView('search')@@ -885,13 +893,13 @@ const SoupViewListContent = (props: SoupViewListProps) => {// Register soup view hotkeys (jump navigation, enter, escape, cmd+k, etc.)const { applyTabPreset } = useApplyPreset();- const isNewInboxEnabled = useIsNewInboxEnabled();+ const isInboxView = useIsInboxView();- // The per-row component depends on the active view (and the inbox flag).+ // The per-row component depends on the active view.const listEntityComponent = () => {if (currentView() === 'tasks') return TaskListEntity;if (currentView() === 'companies') return CompanyListEntity;- if (isNewInboxEnabled()) return InboxListEntity;+ if (isInboxView()) return InboxListEntity;return ListEntity;};diff --git a/apps/web/src/features/next-soup/soup-view/use-is-inbox-view.ts b/apps/web/src/features/next-soup/soup-view/use-is-inbox-view.tsnew file mode 100644index 0000000000..d15d345eaf--- /dev/null+++ b/apps/web/src/features/next-soup/soup-view/use-is-inbox-view.ts@@ -0,0 +1,14 @@+import { isListViewID } from '@app/constants/list-views';+import { useSplitPanelOrThrow } from '@components/app/split-layout/layoutUtils';++export function useIsInboxView() {+ const panel = useSplitPanelOrThrow();++ const currentView = () => {+ const { type, id } = panel.handle.content();+ if (type !== 'component') return;+ return isListViewID(id) ? id : undefined;+ };++ return () => currentView() === 'inbox';+}diff --git a/apps/web/src/features/next-soup/soup-view/use-is-new-inbox-enabled.ts b/apps/web/src/features/next-soup/soup-view/use-is-new-inbox-enabled.tsdeleted file mode 100644index 7d01d4c888..0000000000--- a/apps/web/src/features/next-soup/soup-view/use-is-new-inbox-enabled.ts+++ /dev/null@@ -1,23 +0,0 @@-import { isListViewID } from '@app/constants/list-views';-import { useFeatureFlag } from '@app/lib/analytics/posthog';-import { useSplitPanelOrThrow } from '@components/app/split-layout/layoutUtils';-import {- ENABLE_NEW_INBOX_FLAG,- ENABLE_NEW_INBOX_OVERRIDE,-} from '@core/constant/featureFlags';--export function useIsNewInboxEnabled() {- const panel = useSplitPanelOrThrow();-- const currentView = () => {- const { type, id } = panel.handle.content();- if (type !== 'component') return;- return isListViewID(id) ? id : undefined;- };-- const newInboxFlag = useFeatureFlag(ENABLE_NEW_INBOX_FLAG, {- enabledOverride: ENABLE_NEW_INBOX_OVERRIDE,- });-- return () => currentView() === 'inbox' && newInboxFlag().enabled;-}diff --git a/apps/web/src/lib/core/constant/featureFlags.ts b/apps/web/src/lib/core/constant/featureFlags.tsindex a1d124c1fd..572eb6d442 100644--- a/apps/web/src/lib/core/constant/featureFlags.ts+++ b/apps/web/src/lib/core/constant/featureFlags.ts@@ -559,20 +559,6 @@ export const ENABLE_HOME_RECOMMENDATIONS_OVERRIDE =export const ENABLE_NEW_PRICING_OVERRIDE =resolveFeatureFlag('ENABLE_NEW_PRICING', DEV_MODE_ENV) || undefined;-// New inbox: renders the Inbox list view with the notification card layout and-// expandable thread reply sub-items. PostHog-gated with a dev-mode default;-// override with VITE_ENABLE_NEW_INBOX.-export const ENABLE_NEW_INBOX_FLAG = 'enable-new-inbox-view';-export const ENABLE_NEW_INBOX_OVERRIDE =- resolveFeatureFlag('ENABLE_NEW_INBOX', DEV_MODE_ENV) || undefined;-export function ENABLE_NEW_INBOX() {- if (ENABLE_NEW_INBOX_OVERRIDE !== undefined) {- return ENABLE_NEW_INBOX_OVERRIDE;- }-- return analytics.posthog.isFeatureEnabled(ENABLE_NEW_INBOX_FLAG) ?? false;-}-// Channel mode where replying and editing do not happen inline, but in a single unified input instead.export const UNIFIED_CHANNEL_INPUT = resolveFeatureFlag('UNIFIED_CHANNEL_INPUT',